2012-05-24 275 views
1

我正在制作一个程序来构建二进制消息。我使用char字符串来保存二进制值。所以我已经初始化了一堆具有默认值的char字符串。然后我通过运行for循环将它们结合起来,并将它们读入一个大字符串(aismsg/ais_packet)中。并且一切正常,直到我添加msg14Text [],然后我建立的字符串(aismsg/ais_packet)被缩短,如下所示(即使我没有使用变量)。看起来像我添加msg14Text []时,它改变了其他字符串之一的值。这可能是内存分配问题吗?代码的字符串覆盖其他字符串

部分:

char ais_packet[257];       //Allokerer array for ais data pakke. 
char aismsg[175];        //Allokerer array for meldingen. 
int burst_nr = 1;        //Indicates with burst it is transmittin (1-7). 

char ramp_up[] = "00000000";     //Ramp up buffer. 
char train_seq[] = "010101010101010101010101"; //Training sequence 24 bits of alternating 0-1.s 
char hdlc_flag[] = "01111110";     //HDLC Start and END flag. 
char buffer[] = "000000000000000000000000";  //Data packet buffer. 
char msgID1[] = "000001";      //msg. 1. 
char msgID14[] ="010100";      //msg. 14. 
char repeat[] = "00";       //repetert 0 ganger. 
char mmsi[] = "000111010110111100110100010101"; //Gir 123456789 som MMSI. 
char nav_stat[] = "1111";      //Gir 15= AIS-SART test, endres til 14 (1110) for aktiv AIS-SART.x' 
char rot[] = "10000000";      //Rate of Turn -128 betyr ikkje tilgjengelig. 
char sogBin[] = "1111111111";     //Tilsvarer 1023 = not available = default. 
char pos_acc[] = "0";       //Posisjonsnøyaktighet over 10m. 1 = under 10m. 
char lonBin[] = "0110011110010001101011000000"; // Tilsvarer 181 grader som er default verdi for Longitude. 
char latBin[] = "011010000010010000101000000"; // Tilsvarer 91 grader som er default verdi for Latitude. 
char cogBin[] = "111000010000";     //Tilsvarer 3600 = not available = default. 
char headingBin[] = "111111111";    //511 = not available = default 
char timestamp[] = "111100";     //Tid siden melding er generert, 60 = default = ts not available. 
char spec_man[] = "01";       //Special manouver 0 = default, 1 = not engaged in special manouver 
char spare[] = "000"; 
char spareMSG14[] = "00";       //Reserved. 
char raim[] = "0";        //RAIM 0 = not in use. 
char comm_state[] = "00011100000000000000";  // First 2bit: Sync state: 3 = no UTC sync = default, 0 = UTC sync. 0011100000000000000 
char msg14Text[] = "100100101101111011111100"; //CAUSING TROUBLE!!!! for AIS melding 14 står "Test" med 6-bit ASCII koding. 

该函数的enitre代码可以在pastebin.com/wj0RxyLX

输出AIS的分组中找到与msg14Text []:

00000000 

AIS的输出没有msg14Text []的数据包:

0000000001010101010101010101010101111110000001000001110101101111001101000101011111100000000011010000000000000110100011000101111000000101100100000100001100101110000100000000110011111000100000011100000000000000001000100110100101111110000000000000000000000000 

aispacket应包括以下变量:

ramp_up[] + train_seq[] + hdlc_flag[] + Datapacket(168bit) + crc(16bit) + hdlc_flag[] + buffer[] + '\0' 
+2

Pleae创建一个[简短自包含的测试用例](http://sscce.org),并将其粘贴到您的问题中。 –

+1

为什么您将_strings_用于_binary_数据有特殊原因吗? – JimmyB

回答

1

“这可能是内存分配的问题?”

您没有在代码中明确分配任何内存。请注意,char repeat[] = "00";是静态分配的数组,其大小等于3 char s,其内容正在通过字符串文字"00"进行初始化。

问题是最有可能在这些字符串复制到ais_packet因为你这样做,在非标准的方式(逐字符),这将导致你的代码难以阅读,它很容易犯一个错误有:

for(int k=0; k<256; k++) 
{ 
    ... 
    if(k==256) // are you sure that value of k will reach 256 ? 

我建议你使用已经为此创建C风格的功能:通过使用strcpy通过复制第一串进去了解创建ais_packet并保留通过使用strcat追加其他字符串扩展该ais_packet的内容。

这个问题也将帮助你:Using strcat in C

1

在丑陋for (k=0; k < 168; k++) { if ... else if ...}循环结束

else if(k==168) 
     { 
     aismsg[k] = '\0'; 
     k=0; 
     } 

这将使要么(K < = 168)的循环运行里永恒,要么(K < 168)从未被执行。 (有这种模式的多个实例)

BTW另一种方式做同样的(也更快)将

.... 
unsigned dst=0; 
memcpy (array+dst, src1, 123); 
dst += 123; 
memcpy(array+dst, src2, 234); 
dst += 234; 
... 
array[dst] = 0; 
0

只是一个想法,但如果你正在构建二进制消息,为什么不使用实际的二进制而不是char数组?这里有一种使用联合内的结构来位二进制数据的方法。

// declaration 
typedef union 
{ 
    uint32_t packed; 
    struct { 
     uint16_t sample1: 12; // 12 bits long 
     uint16_t sample2: 14; 
      uint16_t 6;   // unused bits 
    } data; 
} u1; 

// instantiation 
u1 pack1; 

// setting 
pack1.data.sample1 = 1234; 
//getting 
uint16_t newval = pack1.data.sample2; 
// setting bit 6 in sample 1 
pack1.data.sample1 |= (1 << 6); 
// setting lo nibble in sample1 to 0101 
pack1.data.sample1 &= 0b11110101; 
// getting the whole packed value 
uint32_t binmsg = pack1.packed;