2014-05-24 38 views
0

我试图让我的第一个应用程序(yahtzee)。当你点击滚动按钮时,我想切换骰子的图像,现在每当我调用setImageResource时,我都会崩溃。setImageResource崩溃应用程序

主要活动:

public class MainActivity extends ActionBarActivity { 

Button button; 
ImageView image1; 
ImageView image2; 
ImageView image3; 
ImageView image4; 
ImageView image5; 
TextView hold1; 
TextView hold2; 
TextView hold3; 
TextView hold4; 
TextView hold5; 

@Override 
protected void onCreate(Bundle savedInstanceState) { 
    super.onCreate(savedInstanceState); 
    setContentView(R.layout.activity_main); 

    image1 = (ImageView) findViewById(R.id.dice1); 
    image2 = (ImageView) findViewById(R.id.dice2); 
    image3 = (ImageView) findViewById(R.id.dice3); 
    image4 = (ImageView) findViewById(R.id.dice4); 
    image5 = (ImageView) findViewById(R.id.dice5); 

    button = (Button) findViewById(R.id.Roll); 

    if (savedInstanceState == null) { 
     getSupportFragmentManager().beginTransaction() 
       .add(R.id.container, new PlaceholderFragment()).commit(); 
    } 
} 

@Override 
public boolean onCreateOptionsMenu(Menu menu) { 

    // Inflate the menu; this adds items to the action bar if it is present. 
    getMenuInflater().inflate(R.menu.main, menu); 
    return true; 
} 

@Override 
public boolean onOptionsItemSelected(MenuItem item) { 
    // Handle action bar item clicks here. The action bar will 
    // automatically handle clicks on the Home/Up button, so long 
    // as you specify a parent activity in AndroidManifest.xml. 
    int id = item.getItemId(); 
    if (id == R.id.action_settings) { 
     return true; 
    } 
    return super.onOptionsItemSelected(item); 
} 

/** 
* A placeholder fragment containing a simple view. 
*/ 
public static class PlaceholderFragment extends Fragment { 

    public PlaceholderFragment() { 
    } 

    @Override 
    public View onCreateView(LayoutInflater inflater, ViewGroup container, 
      Bundle savedInstanceState) { 
     View rootView = inflater.inflate(R.layout.fragment_main, container, 
       false); 
     return rootView; 
    } 
} 


public void rollDice(View view) { 

    Random rand = new Random(); 
    int r1, r2, r3, r4, r5; 

    r1 = rand.nextInt(5) + 1; 
    r2 = rand.nextInt(5) + 1; 
    r3 = rand.nextInt(5) + 1; 
    r4 = rand.nextInt(5) + 1; 
    r5 = rand.nextInt(5) + 1; 

    //image1.setImageDrawable(getResources().getDrawable(R.drawable.die2)); 
    image1.setImageResource(R.drawable.die2); 

    /* 
    if (hold1.getVisibility() == 0) 
    { 
     if (r1 == 1) 
      image1.setImageResource(R.drawable.die1); 
     else if (r1 == 2) 
      image1.setImageResource(R.drawable.die2); 
     else if (r1 == 3) 
      //image1.setImageResource(R.drawable.die3); 
     else if (r1 == 4) 
      image1.setImageResource(R.drawable.die4); 
     else 
      image1.setImageResource(R.drawable.die5); 
    } 

    if (hold2.getVisibility() == 0) 
    { 
     if (r2 == 1) 
     image2.setImageResource(R.drawable.die1); 
     else if (r2 == 2) 
      image2.setImageResource(R.drawable.die2); 
     else if (r2 == 3) 
      image2.setImageResource(R.drawable.die3); 
     else if (r2 == 4) 
      image2.setImageResource(R.drawable.die4); 
     else 
      image2.setImageResource(R.drawable.die5); 
    } 
    if (hold3.getVisibility() == 0) 
    { 
     if (r3 == 1) 
      image3.setImageResource(R.drawable.die1); 
     else if (r3 == 2) 
      image3.setImageResource(R.drawable.die2); 
     else if (r3 == 3) 
      image3.setImageResource(R.drawable.die3); 
     else if (r3 == 4) 
      image3.setImageResource(R.drawable.die4); 
     else 
      image3.setImageResource(R.drawable.die5); 
    } 
    if (hold4.getVisibility() == 0) 
    { 
     if (r4 == 1) 
      image4.setImageResource(R.drawable.die1); 
     else if (r4 == 2) 
      image4.setImageResource(R.drawable.die2); 
     else if (r4 == 3) 
      image4.setImageResource(R.drawable.die3); 
     else if (r4 == 4) 
      image4.setImageResource(R.drawable.die4); 
     else 
      image4.setImageResource(R.drawable.die5); 
    } 
    if (hold5.getVisibility() == 0) 
    { 
     if (r5 == 1) 
      image5.setImageResource(R.drawable.die1); 
     else if (r5 == 2) 
      image5.setImageResource(R.drawable.die2); 
     else if (r5 == 3) 
      image5.setImageResource(R.drawable.die3); 
     else if (r5 == 4) 
      image5.setImageResource(R.drawable.die4); 
     else 
      image5.setImageResource(R.drawable.die5); 
    } 
    */ 
} 

}

片段main.xml中:

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" 
xmlns:tools="http://schemas.android.com/tools" 
android:layout_width="match_parent" 
android:layout_height="match_parent" 
android:paddingBottom="@dimen/activity_vertical_margin" 
android:paddingLeft="@dimen/activity_horizontal_margin" 
android:paddingRight="@dimen/activity_horizontal_margin" 
android:paddingTop="@dimen/activity_vertical_margin" 
tools:context="com.example.yahtz.MainActivity$PlaceholderFragment" > 

<Button 
    android:id="@+id/Roll" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_alignParentBottom="true" 
    android:layout_alignParentLeft="true" 
    android:layout_alignParentRight="true" 
    android:text="Roll" 
    android:onClick="rollDice" /> 

<ImageView 
    android:id="@+id/dice1" 
    android:layout_width="50dp" 
    android:layout_height="50dp" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="10dp" 
    android:layout_marginLeft="0dp" 
    android:clickable="true" 
    android:src="@drawable/die1" /> 

<ImageView 
    android:id="@+id/dice2" 
    android:layout_width="50dp" 
    android:layout_height="50dp" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="10dp" 
    android:layout_marginLeft="60dp" 
    android:clickable="true" 
    android:src="@drawable/die2" /> 

<ImageView 
    android:id="@+id/dice3" 
    android:layout_width="50dp" 
    android:layout_height="50dp" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="10dp" 
    android:layout_marginLeft="120dp" 
    android:clickable="true" 
    android:src="@drawable/die3" /> 

<ImageView 
    android:id="@+id/dice4" 
    android:layout_width="50dp" 
    android:layout_height="50dp" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="10dp" 
    android:layout_marginLeft="180dp" 
    android:clickable="true" 
    android:src="@drawable/die4" /> 

<ImageView 
    android:id="@+id/dice5" 
    android:layout_width="50dp" 
    android:layout_height="50dp" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="10dp" 
    android:layout_marginLeft="240dp" 
    android:clickable="true" 
    android:src="@drawable/die5" /> 

<TextView 
    android:id="@+id/hold1" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="70dp" 
    android:layout_marginLeft="10dp" 
    android:visibility="invisible" 
    android:text="Hold" 
    android:textAppearance="?android:attr/textAppearanceSmall" /> 

<TextView 
    android:id="@+id/hold2" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="70dp" 
    android:layout_marginLeft="70dp" 
    android:visibility="invisible" 
    android:text="Hold" 
    android:textAppearance="?android:attr/textAppearanceSmall" /> 

<TextView 
    android:id="@+id/hold3" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="70dp" 
    android:layout_marginLeft="130dp" 
    android:visibility="invisible" 
    android:text="Hold" 
    android:textAppearance="?android:attr/textAppearanceSmall" /> 

<TextView 
    android:id="@+id/hold4" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="70dp" 
    android:layout_marginLeft="190dp" 
    android:visibility="invisible" 
    android:text="Hold" 
    android:textAppearance="?android:attr/textAppearanceSmall" /> 

<TextView 
    android:id="@+id/hold5" 
    android:layout_width="wrap_content" 
    android:layout_height="wrap_content" 
    android:layout_above="@+id/Roll" 
    android:layout_marginBottom="70dp" 
    android:layout_marginLeft="250dp" 
    android:visibility="invisible" 
    android:text="Hold" 
    android:textAppearance="?android:attr/textAppearanceSmall" /> 

logcat的 i.stack.imgur.com/n3R2k.png

+0

请编辑的问题,包括它的堆栈跟踪。尽量避免代码和堆栈跟踪图片。 – Emmanuel

+0

当你调用'setContentView(R.layout.activity_main)'时,你所有的UI都是'null',因为它们在'fragment_main'中。看[这里](http://stackoverflow.com/questions/23820314/android-text-view-giving-an-error-when-trying-to-set-text/23820638#23820638)在哪里考虑类似的问题。 – Onik

回答

1

您试图夸大布局,然后从另一个布局使用视图..

,因为你使用R.layout.activity_main你只能使用该布局罢了..

内,但在你的情况,你所用的image1 = (ImageView) findViewById(R.id.dice1);意见它将引用一个空值,因为它驻留在您的MAIN.xml而不是activity_main中。

所以,你需要做的是什么,而不是使用activity_main布局使用适当的布局,是setContentView(R.layout.MAIN);