2012-12-28 176 views
0

首先,SQL是由服务器动态处理的,因此我的WHERE子句中的某些项目对您来说可能很奇怪,请忽略这些因为它们不是问题。SQL Server 2008 - 需要更新SQL帮助

每我的客户的要求,他们需要UNION其他两个条件我的更新报告(A/患者无一患者就诊 /)和(/ 患者无预约 /)。我需要帮助将这两个子集的患者添加到我的最终更新查询中。在目前的状态下,它只会增加#Temp患者,我需要纳入额外的患者。

任何帮助非常感谢。

我现在的SQL更新 -

DECLARE @Inactive INT 
DECLARE @Active INT 
DECLARE @PatientProfileId INT 

SELECT 
    @Inactive = MedlistsId 
FROM 
    Medlists 
WHERE 
    TableName = 'PatientProfileStatus' 
    AND Code = 'I' 

SELECT 
    @Active = MedlistsId 
FROM 
    Medlists 
WHERE 
    TableName = 'PatientProfileStatus' 
    AND Code = 'A' 

CREATE TABLE #Temp 
    (
     PatientName VARCHAR(120) , 
     PatientProfileId INT , 
     RecentId INT , 
     Recent DATETIME 
    ) 

INSERT INTO #Temp 
     SELECT 
      dbo.FormatName(pp.Prefix , pp.First , pp.Middle , pp.Last , pp.Suffix) AS Name , 
      pp.PatientProfileId , 
      MAX(pv.PatientVisitId) AS RecentId , 
      MAX(pv.Visit) AS Recent 
     FROM 
      PatientVisit pv 
      INNER JOIN PatientProfile pp ON pv.PatientProfileId = pp.PatientProfileId 
              AND pp.PatientStatusMId = @Active 
     WHERE 
      pp.PatientProfileId IN (SELECT 
             a.OwnerId 
            FROM 
             Appointments a 
             INNER JOIN PatientProfile pp ON a.OwnerId = pp.PatientProfileId 
                     AND a.ApptKind = 1 
                     AND pp.PatientStatusMId = @Active 
            GROUP BY 
             a.OwnerId , 
             a.ApptKind 
            HAVING 
             MAX(a.ApptStart) < '07/30/2005') 
     GROUP BY 
      dbo.FormatName(pp.Prefix , pp.First , pp.Middle , pp.Last , pp.Suffix) , 
      pp.PatientProfileId 
     HAVING 
      MAX(pv.Visit) < '07/30/2005' 

/*Patients without a Appointment*/ 

IF 1 = 1 
    INSERT INTO #Temp 
      SELECT 
       dbo.FormatName(pp.Prefix , pp.First , pp.Middle , pp.Last , pp.Suffix) AS Name , 
       pp.PatientProfileId , 
       NULL AS RecentId , 
       NULL AS Recent 
      FROM 
       PatientProfile pp 
       LEFT JOIN (SELECT * FROM Medlists WHERE TableName = 'PatientProfileStatus') ml1 ON pp.PatientStatusMId = ml1.MedlistsId 
       LEFT JOIN Appointments a ON a.Ownerid = pp.PatientProfileId 
              AND a.ApptKind = 1 
       LEFT JOIN PatientVisit pv ON a.PatientVisitId = pv.PatientVisitId 
      WHERE 
       ml1.Code = 'A' 
       AND a.ownerid IS NULL 
       AND --Filter on Age 
       (
        ((
        '-1' = '-1' 
        AND '40' = '125' 
        ) 
        OR (CAST((DATEDIFF(DAY , pp.Birthdate , GETDATE())/365.25) AS INT) BETWEEN ('-1') AND ('40'))) 
       ) 

/*Patients without a Patient Visit*/ 

IF 0 = 1 
    INSERT INTO #Temp 
      SELECT 
       dbo.FormatName(pp.Prefix , pp.First , pp.Middle , pp.Last , pp.Suffix) AS Name , 
       pp.PatientProfileId , 
       NULL AS RecentId , 
       NULL AS Recent 
      FROM 
       PatientProfile pp 
       LEFT JOIN PatientVisit pv ON pv.PatientProfileid = pp.PatientProfileid 
       LEFT JOIN (SELECT * FROM Medlists WHERE TableName = 'PatientProfileStatus') ml1 ON pp.PatientStatusMId = ml1.MedlistsId 
      WHERE 
       ml1.Code = 'A' 
       AND pv.patientprofileid IS NULL 
       AND --Filter on Age 
       (
        ((
        '-1' = '-1' 
        AND '40' = '125' 
        ) 
        OR (CAST((DATEDIFF(DAY , pp.Birthdate , GETDATE())/365.25) AS INT) BETWEEN ('-1') AND ('40'))) 
       ) 

DECLARE curPatient CURSOR FORWARD_ONLY READ_ONLY LOCAL 
FOR 
    SELECT 
     t.PatientProfileId 
    FROM 
     #Temp t 
     JOIN PatientProfile pp ON t.PatientProfileId = pp.PatientProfileId 
     JOIN PatientVisit pv ON pp.PatientProfileId = pv.PatientProfileId 
           AND pv.PatientVisitId = t.RecentId 
    WHERE 
     --Filter on Age 
     (
      ((
      '-1' = '-1' 
      AND '40' = '125' 
      ) 
      OR (CAST((DATEDIFF(DAY , pp.Birthdate , GETDATE())/365.25) AS INT) BETWEEN ('-1') AND ('40'))) 
     ) 

OPEN curPatient 
FETCH NEXT FROM curPatient INTO @PatientProfileId 

WHILE @@FETCH_STATUS = 0 
    BEGIN 

     UPDATE 
      PatientProfile 
     SET 
      PatientStatusMId = @Inactive , 
      pstatus = 'I' 
     FROM 
      PatientProfile P 
      INNER JOIN #Temp t ON t.PatientProfileID = P.PatientProfileID 
     WHERE 
      p.PatientProfileId = @PatientProfileId 


     FETCH NEXT FROM curPatient INTO @PatientProfileId 
    END 

CLOSE curPatient 
DEALLOCATE curPatient 

DROP TABLE #Temp 
+1

...您的表“MedLists”似乎是多域(给定'tablename'列),可能应该分解。有没有我不知道的东西,或者'DATEDIFF(年,pp.birthdate,GETDATE())'年返回一个人的年龄(注意你现在的方法除以365.25,并不总是给出正确的结果)。您似乎正在加入大量表格,以获取最终不会使用的信息 - 为什么,以及是否可以删除引用(例如,不使用'patientName')?以这种方式旋转游标是**不是**更新表的最有效方法。 –

回答

0

这将限制给患者预约

LEFT JOIN Appointments a 
     ON a.Ownerid = pp.PatientProfileId 
     AND a.ApptKind = 1 

这将限制对患者进行了访问

LEFT JOIN PatientVisit pv 
     ON pv.PatientProfileid = pp.PatientProfileid 

尝试

LEFT OUTER JOIN Appointments a 
      ON a.Ownerid = pp.PatientProfileId 
      AND a.ApptKind = 1 
Where a.Ownerid is null 


LEFT OUTER JOIN PatientVisit pv 
     ON pv.PatientProfileid = pp.PatientProfileid 
Where pv.PatientProfileid is null