2013-12-16 43 views
1

在我们的基于Music Store Tutorial的Entity Framework 4.0的MVC4应用程序中,我们使用Moq来模拟DbContext,单元测试是逻辑。我们的一种方法很难测试,因为它使用了HttpContextHttpContextBase。一个示例方法是这样的:如何在ShoppingCart控制器/模型中模拟HttpContext

public static ShoppingCart GetCart(HttpContextBase context) 
    { 
     var cart = new ShoppingCart(); 
     cart.ShoppingCartId = cart.GetCartId(context); 
     return cart; 
    } 

HttpContextBase收集的唯一属性是[CartSessionKey]因为可以在这里看到:

public string GetCartId(HttpContextBase context) 
{ 
    if (context.Session[CartSessionKey] == null) 
    { 
     if (!string.IsNullOrWhiteSpace(context.User.Identity.Name)) 
     { 
      context.Session[CartSessionKey] = 
       context.User.Identity.Name; 
     } 
     else 
     { 
      // Generate a new random GUID using System.Guid class 
      Guid tempCartId = Guid.NewGuid(); 
      // Send tempCartId back to client as a cookie 
      context.Session[CartSessionKey] = tempCartId.ToString(); 
     } 
    } 
    return context.Session[CartSessionKey].ToString(); 
} 

我们听说的恐怖故事HttpContext是一个非常复杂的类和如果你打印它,你有足够的纸张八次环绕地球。

不过我们想嘲笑它。问题是如何。我们想要模拟的属性是[CartSessionKey],以及来自上下文的属性为contest.User.Identity.Name

我们怀疑,我们需要使用这样的事情:

 var mockData = new Mock<FakeContext>(); 
     mockData.Setup(m => m.Orders).Returns(memoryOrderItems); 
     mockData.Setup(m => m.Carts).Returns(memoryCartItems); 

     Mock<HttpContextBase> mockHttpContext = new Mock<HttpContextBase>(); 
     Mock<HttpRequestBase> mockHttpRequest = new Mock<HttpRequestBase>(); 

     mockHttpRequest.Setup(x => x.CartSessionKey).Returns(1); 
     mockHttpContext.Setup(x => x.Request).Returns(mockHttpRequest.Object); 

,但我们无法找到如何具体实现这个,所以我们没有得到在使用context.Session[CartSessionKey]context.User.Identity.Name方法的任何错误。

我们希望有人能帮助我们。

/编辑

当我们这样做:

var memoryUserItems = new FakeDbSet<User>() 
     { 
      new User { Email = "[email protected]", 
         FullName = "Test Person", 
         isAvailable = true, 
         Name = "WHat" 
      }, 
      new User { Email = "[email protected]", 
         FullName = "Test Person 2", 
         isAvailable = true, 
         Name = "WHat 2" 
      } 
     }; 
(...) Other memory...Items 

然后将此:

 // Create mock units of work 
     var mockData = new Mock<FakeContext>(); 
     mockData.Setup(m => m.Orders).Returns(memoryOrderItems); 
     mockData.Setup(m => m.Carts).Returns(memoryCartItems); 
     mockData.Setup(m => m.Users).Returns(memoryUserItems); 

     var principalMock = new Mock<IPrincipal>(); 
     var identityMock = new Mock<IIdentity>(); 
     var userMock = 
     identityMock.Setup(x => x.Name).Returns("Test!"); 
     identityMock.Setup(x => x.IsAuthenticated).Returns(true); // optional ;) 
     mockData.Setup(x => x.Identity).Returns(identityMock.Object); 
     var httpReqBase = new Mock<HttpRequestBase>(); // this is useful if you want to test Ajax request checks or cookies in the controller. 
     var httpContextBase = new Mock<HttpContextBase>(); 

     httpContextBase.Setup(x => x.User).Returns(principalMock.Object); 
     httpContextBase.Setup(x => x.Session[It.IsAny<string>()]).Returns(1); //Here is the session indexer. You can swap 'any' string for specific string. 
     httpContextBase.Setup(x => x.Request).Returns(httpReqBase.Object); 

我们得到的错误是:

错误3“项目。 Models.FakeContext'确实不是 包含“身份”和没有扩展方法 “身份”接受 类型“project.Models.FakeContext”的第一个参数的定义可以发现 (是否缺少使用指令或程序集 引用?)

/edit2

为了更清楚。我测试的实际方法如下:

public ActionResult Complete(int id) 
    { 
     // Make sure that user is currentuser and otherwise bring user to our Thief page 
     if (id != db.GetCurrentUserId()) 
     { 
      return View("Thief"); 
     } 

     var cart = ShoppingCart.GetCart(this.HttpContext); 
     var currentDate = DateTime.Today; 
     var viewModel = new ShoppingCartViewModel 
     { 
      CartItems = cart.GetCartItems(), 
      CartTotal = cart.GetTotal(), 
      ProductItems = db.Products.ToList() 
     }; 

     if (viewModel.CartItems.Count() == 0) 
     { 
      return View("Empty"); 
     } 

     // Try to write cart to order table 
     try 
     { 
      foreach (var item in viewModel.CartItems) 
      { 
       ProcessOrder(item, id, currentDate); 

      } 
      // after this we empty the shopping cart 
      cart.EmptyCart(); 
      return View(); 
     } 
     catch 
     { 
      // Invalid - display error page 
      return View("Error"); 
     } 

    } 

可以看出该var cart = ShoppingCart.GetCart(this.HttpContext);使用this.HttpContext。在测试中,我只是做controller.Complete(1)。我猜想我无法将新的HttpContext传递给控制器​​?

/编辑3

虽然使用下面的代码与嘲笑我得到以下信息:

Test Name: TestCheckoutCompleteShouldWithEmptyCart 
Test FullName: Controllers.CheckoutControllerTest.TestCheckoutCompleteShouldWithEmptyCart 
Test Source: Controllers\CheckoutControllerTest.cs : line 141 
Test Outcome: Failed 
Test Duration: 0:00:00.0158591 

Result Message: 
Test method Controllers.CheckoutControllerTest.TestCheckoutCompleteShouldWithEmptyCart threw exception: 
System.NullReferenceException: Object reference not set to an instance of an object. 
Result StackTrace: 
at Models\ShoppingCart.cs:line 170 
    at \Models\ShoppingCart.cs:line 20 
    at \Controllers\CheckoutController.cs:line 48 
    at Controllers\CheckoutControllerTest.cs:line 143 
+0

您是否正在测试公共字符串GetCartId(HttpContextBase上下文)方法?你的MUT是什么? GetCart或GetCartId? – Spock

+0

Hi @Spock Hi,什么是MUT? 'GetCartId'是GetCart依赖的主要关注点。 –

+0

对不起,这是测试方法。你试图达到的目标非常简单。看到我的答案,还有其他几种做法。乐于帮助 – Spock

回答

2

OK,这里去。下面在AD中使用MVC5,我不确定它是否完全向后兼容,你必须检查。

var principalMock = new Mock<IPrincipal>(); 
var identityMock = new Mock<IIdentity>(); 
identityMock.Setup(x => x.Name).Returns("Test!"); 
identityMock.Setup(x => x.IsAuthenticated).Returns(true); // optional ;) 
userMock.Setup(x => x.Identity).Returns(identityMock.Object); 
var httpReqBase = new Mock<HttpRequestBase>(); // this is useful if you want to test Ajax request checks or cookies in the controller. 
var httpContextBase = new Mock<HttpContextBase>(); 

httpContextBase.Setup(x => x.User).Returns(principalMock.Object); 
httpContextBase.Setup(x => x.Session[It.IsAny<string>()]).Returns(1); //Here is the session indexer. You can swap 'any' string for specific string. 
httpContextBase.Setup(x => x.Request).Returns(httpReqBase.Object); 
+0

谢谢。我编辑了一个与userMock对象有关的新问题。你能解释一下如何使x.Identity部分工作吗? –

+0

@ user2609980你的'FakeContext'看起来像什么?它使用'IIdentity'吗? –

+0

它由用于每个'Model'(例如'public virtual IDbSet Products {get; set;}'的公共虚拟IDbSet'和两个空方法如public int SaveChanges() { return 1; } '和 '公共无效的Dispose(){ 扔 新NotImplementedException();} ?'所以,它不使用'IIdentity'我们应该 –

1

这将帮助您使用Moq编写适当的单元测试。

[TestClass] 
public class SutTest 
{ 
    [TestMethod] 
    public void GetCartId_WhenUserNameIsNotNull_SessionContainsUserName() 
    { 
     var httpContextStub = new Mock<HttpContextBase>(); 
     var httpSessionStub = new Mock<ISessionSettings>(); 
     httpSessionStub.Setup(x => x.Get<string>(It.IsAny<string>())).Returns(() => null); 

     httpSessionStub.SetupSequence(x => x.Get<string>(It.IsAny<string>())) 
      .Returns(null) 
      .Returns("FakeName"); 

     var httpUserStub = new Mock<IPrincipal>(); 
     var httpIdenttyStub = new Mock<IIdentity>(); 
     httpUserStub.SetupGet(x => x.Identity).Returns(httpIdenttyStub.Object); 
     httpIdenttyStub.SetupGet(x => x.Name).Returns("FakeName"); 

     httpContextStub.Setup(x => x.User).Returns(httpUserStub.Object); 
     var sut = new Sut(httpSessionStub.Object); 

     var result = sut.GetCartId(httpContextStub.Object); 

     Assert.AreEqual("FakeName",result); 
    } 
} 

检查SetupSequence方法,该方法可让您找到控制同一存根呼叫时返回的不同值。 对于从HttpContext解耦您的会话同样重要,因为您始终可能遇到问题。

public class SessionSettings : ISessionSettings 
{ 
    private readonly HttpSessionStateBase _session; 
    public SessionSettings(HttpSessionStateBase session) 
    { 
     _session = session; 
    } 

    public T Get<T>(string key) 
    { 
     return (T)_session[key]; 
    } 

    public void Set<T>(string key, T value) 
    { 
     _session[key] = value; 
    } 
} 

public interface ISessionSettings 
{ 
    T Get<T>(string key); 
    void Set<T>(string key, T value); 
} 

public class Sut 
{ 
    private ISessionSettings _sessionSettings; 
    public Sut(ISessionSettings sessionSettings) 
    { 
     _sessionSettings = sessionSettings; 
    } 
    public string GetCartId(HttpContextBase context) 
    { 
     if (_sessionSettings.Get<string>(CartSessionKey) == null) 
     { 
      if (!string.IsNullOrWhiteSpace(context.User.Identity.Name)) 
      { 
       _sessionSettings.Set<string>(CartSessionKey, context.User.Identity.Name); 
      } 
      else 
      { 
       // Generate a new random GUID using System.Guid class 
       Guid tempCartId = Guid.NewGuid(); 
       // Send tempCartId back to client as a cookie 
       _sessionSettings.Set<string>(CartSessionKey, tempCartId.ToString()); 
      } 
     } 
     return _sessionSettings.Get<string>(CartSessionKey); 
    } 

    private string CartSessionKey = "key"; 
} 

这样代码更具可读性,更易于理解。