2017-09-15 33 views
1

我有许多派生自抽象类的类。在一个方法中,我收到一个对象,它是派生类之一。我需要检查一个对象的类型并分配给一个正确的属性。直接的解决方案的工作,但看起来像它可以重构。我不知道如何处理它,但:C#重构:检查派生类的类型并将其分配给同一类的变量

public MyDerived1 derived1; 
    public MyDerived2 derived2; 
    // .... 
    public MyDerivedX derivedX; 

    public void AssignValue(MyBaseClass entity) 
    { 
     var derivedOne = entity as MyDerived1; 
     if (derivedOne != null) 
     { 
      derived1 = derivedOne; 
      return; 
     } 

     var derivedTwo = entity as MyDerived2; 
     if (derivedTwo != null) 
     { 
      derived2 = derivedTwo; 
      return; 
     } 

     // .... 

     var derivedEx = entity as MyDerivedX; 
     if (derivedEx != null) 
     { 
      derivedX = derivedEx; 
      return; 
     } 
    } 
+1

为什么不使用'is'关键字?有关详细信息,请参阅此处:https://msdn.microsoft.com/en-us/library/scekt9xw(v=vs.110).aspx –

+0

您可能只有一堆语句,如'derived1 = entity as MyDerived1;' – DavidG

回答

2

您可以创建AssignValue通用版本是这样的:

MyDerived1 derived1; 
MyDerived2 derived2; 

var _ = AssignValue(entity, out derived1) 
    || AssignValue(entity, out derived2); 

private static bool AssignValue<T>(MyBaseClas entity, out T derived) where T : MyBaseClas 
{ 
    var t = entity as T; 
    if (t == null) 
    { 
     derived = null; 
     return false; 
    } 

    derived = t; 
    return true; 
} 

现在你可以通过这种方式使用它

通用函数返回bool以跳过第一次匹配的待处理类型检查

+0

这会工作,但它确实感觉像一个讨厌的黑客。 – DavidG

0

也许你正在寻找类似的东西:

public void AssignValue(MyBaseClass entity) 
    { 
     var item = this.GetType().GetFields().FirstOrDefault(x => x.FieldType == entity.GetType()); 
     if (item != null) 
     { 
      item.SetValue(this, entity); 
     } 
    } 
相关问题