最佳方式重构如果语句

Question

我有以下代码：

      if (adSetting.Core_standard_application_role) 
          { 
           rc = new IntegrationRoleCompany(); 
           rc.RoleCompany = firmSettings.FirmNo.ToString(); 
           rc.RoleName = "Core standard application role"; 
           rcList.Add(rc); 
          } 
          if (adSetting.Expense_Invoice_Application_Access) 
          { 
           rc = new IntegrationRoleCompany(); 
           rc.RoleCompany = firmSettings.FirmNo.ToString(); 
           rc.RoleName = "Expense Invoice Application Access"; 
           rcList.Add(rc); 
          } 

的问题是，我有20个，如果的检查，我检查addSetting.Property。我们的问题是：

什么是if语句来重构这个最好和最有效的方法是什么？

Answer 1

你可以有一个20X2阵列与adSetting.STUFF_AS_STRING - > rc.RoleName映射。

然后循环遍历数组for循环

伪代码：

for (var i=0; i<theArray.length; i++) { 
    adSettingStr, RoleName = theArray[i] 
    if (adSetting[adSettingStr]) { 
     rc = new IntegrationRoleCompany(); 
     rc.RoleCompany = firmSettings.FirmNo.ToString(); 
     rc.RoleName = RoleName; 
     rcList.Add(rc); 
    } 

}