2012-06-27 70 views
2

我试图创建一个OOP友好的Java二十一点游戏的进展我的知识。OOP二十一点游戏(创建甲板)

我碰了壁,我只是不知道不够看的问题。想知道是否有人能指出我的问题。

此外,谷歌搜索关于这个话题的相关后,我发现人们一次又一次的说用枚举会更有利,因为初学者会这样建议?或者我应该暂时坚持使用字符串数组。

谢谢。

我的代码:

public class BlackJack{ 

BlackJack() { 
    Deck deck = new Deck(); 
    deck.createDeck(); 
    System.out.println(deck.deckList); 
} 

public static void main(String[] args) { 

    new BlackJack(); 


    } 
} 


public class Card{ 

private String valueCard; 
private String suitCard; 

public Card(String value, String suit) { 
    this.valueCard = value; 
    this.suitCard = suit; 
} 

public String getValue() { 
    return valueCard; 
} 
public String getSuit() { 
    return suitCard; 
    } 
} 

import java.util.ArrayList; 


public class Deck { 

ArrayList<Card> deckList = new ArrayList<Card>(); 

String[] value = {"Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", 
     "Jack", "Queen", "King", "Ace"}; 
String[] suit = {"Hearts", "Clubs", "Spades", "Diamonds"}; 


Deck() { 

    deckList = new ArrayList<Card>(); 

} 

public void createDeck() { 
    for (int i = 0; i < value.length; i++) { 
     for (int x = 0; x < suit.length; x++) { 
      Card card = new Card(value[i], suit[x]); 
      deckList.add(card); 

      } 
     } 
    } 
} 

编辑:此刻我出把从我的println是: [卡@ addbf1,卡@ 42e816,卡@ 9304b1,......等] 什么这个意思?

谢谢你的时间。

编辑:任何人谁也需要一个答案,这在未来:

补充说:

@Override 
public String toString(){ 
    return valueCard + " of " + suitCard; 
} 
} 

到我的卡类,然后在甲板类中使用它:

import java.util.ArrayList; 


public class Deck { 

ArrayList<Card> deckList = new ArrayList<Card>(); 

String[] value = {"Two", "Three", "Four", "Five", "Six", "Seven", "Eight", "Nine", "Ten", 
     "Jack", "Queen", "King", "Ace"}; 
String[] suit = {"Hearts", "Clubs", "Spades", "Diamonds"}; 


Deck() { 

    deckList = new ArrayList<Card>(); 

} 

public void createDeck() { 
    for (int i = 0; i < value.length; i++) { 
     for (int x = 0; x < suit.length; x++) { 
      Card card = new Card(value[i], suit[x]); 
      deckList.add(card); 
      card.toString(); 
     } 
    } 
} 
} 

ENUM: 公开课CardEnum {

public enum Rank { DEUCE, THREE, FOUR, FIVE, SIX, 
    SEVEN, EIGHT, NINE, TEN, JACK, QUEEN, KING, ACE } 

public enum Suit { CLUBS, DIAMONDS, HEARTS, SPADES } 


} 


public class Card{ 

private CardEnum.Rank rank; 
private CardEnum.Suit suit; 

public Card(CardEnum.Rank rank, CardEnum.Suit suit) { 
    this.rank = rank; 
    this.suit = suit; 
} 

public Rank getRank() { 
    return rank; 
} 
public Suit getSuit() { 
    return suit; 
} 

@Override 
public String toString(){ 
    return rank + " of " + suit; 
} 
} 
+3

如果你的目标是更多的“面向对象”,你应该考虑把你的卡片打包成枚举。查看卡片组示例的http://docs.oracle.com/javase/1.5.0/docs/guide/language/enums.html – assylias

+0

@assylias感谢您的链接,很棒的信息!现在实现枚举。谢谢。 – speak

回答

5

根据您的编辑,我看你的代码打印出由对象的toString()方法,这是当前对象的类和对象的hashCode名返回的默认值。为了纠正这种情况并让你的字符串有意义,你必须给你的每个类别一个public String toString()方法覆盖。该卡类应该有一个返回描述当前牌的花色和值的String一个toString()方法和甲板类应该通过每个迭代卡,并调用卡的toString()。

喜欢的东西:

@Override 
public String toString() { 
    return /* code in here to get the contents of the fields held by the Card object */ 
} 

编辑有关:

I'm just about to delv into enum's I was just curious as I am looking at: docs.oracle.com/javase/1.5.0/docs/guide/language/enums.html But I have two separate classes: Card & Deck. Do I have to copy both sets of enums into both classes for this to work? So I have Card{ enum declaration, private final's, card(Value value, Suit suit) {} then in the deck class will I have to copy the list of enums there again? Bit confused how my deck and card class will be using the enums. Thanks for your patience with a noobie!

不,在例子中,枚举的行为,好像他们是声明的公共静态的 - 所以他们不需要卡实例访问并在Card类之外提供。你只需要限定他们使用它们。即Card.Rank.FOUR访问Rank的FOUR实例。总而言之,您不必在任何地方重新声明枚举。我个人认为把每个枚举放在自己的文件中,与Card类在同一个包中,但不在同一个文件中更清晰。

编辑2幽州:

OK I've created public class CardEnum { public enum RANK {//ranks} public enum Suit { //suits} how do I get it to interact with my Card class?

你会为插卡两个私人领域,CardEnum.Rank类型之一(请注意,枚举名字不应该是所有帽)和CardEnum之一.Suit类型。然后你可以在Card的构造函数中分配这些值。我会让这个班级变成“不可变的”,这意味着一旦你设置了排行榜和卡牌套装,就不应该允许它改变。所以我会给每个这些领域的getter方法,但我不会给它一个setter方法。

所以

public class Card { 
    private CardEnum.Suit suit; 
    private CardEdum.Rank rank; 

    public Card(CardEnum.Suit suit, CardEnum.Rank rank) { 
    this..... etc... 
    } 

    // getter methods here, but no setter methods 

    // .... 

编辑3

one last issue with my get methods: public Rank getRank() { return rank; } gives the error: "rank cannot be resolved" I have editted my main post with my current code to make it easy to read.

您嵌入您的排名枚举一个CardEnum类的内部,让你有资格等级和花色与CardEnum类名。因此,你会怎么做:

public CardEnum.Rank getRank() { 
    return rank; 
} 

一个建议,以摆脱所有多余的废话 - 只是得到完全摆脱CardEnum的,而是放在自己的文件中的每个枚举,一个Rank.java文件和诉讼。 java文件。即

// this guy goes in the Suit.java file 
public enum Suit { 
    CLUBS, DIAMONDS, HEARTS, SPADES 
} 

然后当你指的西装,你不需要调用它CardEnum.Suit。

+1

我刚试过:public String toString(){ \t \t return valueCard + suitCard; \t}编辑:是的,现在效果很好,谢谢! – speak

+1

return this.value +“of”+ this.suit; – steelshark

+0

顺便说一句,你可以很容易地在互联网上看这些东西.. – steelshark