2016-12-05 62 views
0

我有一个名为的ExcelFile,他的工作是管理excel文件(读取,提取数据和堆栈中的不同事物)。管理异常处理

我想实现一个管理错误/异常的系统。

例如,ExcelFile为方法负载(),像一个 “设置”

def load(self): 
     """ 
      Setup for excel file 
      Load workbook, worksheet and others characteristics (data lines, header...) 
      :return: Setup successfully or not 
      :rtype: bool 

      Current usage 
      :Example: 

      > excefile = ExcelFile('test.xls') 
      > excefile.load() 
       True 
      > excefile.nb_rows() 
       4 
     """ 
     self.workbook = xlrd.open_workbook(self.url) 
     self.sheet = self.workbook.sheet_by_index(0) 
     self.header_row_index = self.get_header_row_index() 

     if self.header_row_index == None: # If file doesn't have header (or not valid) 
      return False 

     self.header_fields = self.sheet.row_values(self.header_row_index) 
     self.header_fields_col_ids = self.get_col_ids(self.header_fields) # Mapping between header fields and col ids 
     self.nb_rows = self.count_rows() 
     self.row_start_data = self.header_row_index + self.HEADER_ROWS 
     return True 

正如你可以看到,我会遇到2个型动物错误:

  1. 的文件不是excel文件(raise xlrd.XLRDError)
  2. 该文件有一个无效的标题(所以我返回False)

我想实现一个良好的ExcelFile错误管理系统,因为这个类在堆栈中使用了很多。

这是处理我的第一个想法是:

实现一个标准的异常

class ExcelFileException(Exception): 

    def __init__(self, message, type=None): 
     self.message = message 
     self.type = type 

    def __str__(self): 
     return "{} : {} ({})".format(self.__class__.__name__, self.message, self.type) 

重写负载方法

def load(self): 
    """ 
     Setup for excel file 
     Load workbook, worksheet and others characteristics (data lines, header...) 
     :return: Setup successfully or not 
     :rtype: bool 

     Current usage 
     :Example: 

     > excefile = ExcelFile('test.xls') 
     > excefile.load() 
      True 
     > excefile.nb_rows() 
      4 
    """ 
    try: 
     self.workbook = xlrd.open_workbook(self.url) 
    except xlrd.XLRDError as e: 
     raise ExcelFileException("Unsupported file type", e.__class__.__name__) 

    self.sheet = self.workbook.sheet_by_index(0) 
    self.header_row_index = self.get_header_row_index() 

    if self.header_row_index == None: # If file doesn't have header (or not valid) 
     raise ExcelFileException("Invalid or empty header") 

    self.header_fields = self.sheet.row_values(self.header_row_index) 
    self.header_fields_col_ids = self.get_col_ids(self.header_fields) # Mapping between header fields and col ids 
    self.nb_rows = self.count_rows() 
    self.row_start_data = self.header_row_index + self.HEADER_ROWS 
    return True 

而且在呼叫方法,这样的例子,一个很大的问题是我必须管理一个名为“报告”的字典,用法语出错,为客户的成功和其他。

... 
def foo(): 
    ... 
    file = ExcelFile(location) 

    try: 
     file.load() 
    except ExcelFileException as e: 
     log.warn(e.__str__()) 
     if e.type == 'XLRDError' 
      self.report['errors'] = 'Long description of the error, in french (error is about invalid file type)' 
     else: 
      self.report['errors'] = 'Long description of the error, in french (error is about invalid header)' 
... 

您对此有何看法?你有更好的方法吗? 谢谢

回答

1

你可以改变你的异常登录错误您dict

class ExcelFileException(Exception): 

    def __init__(self, message, report, type=None): 
     report['errors'].append(message) 
     self.message = message 
     self.type = type 

    def __str__(self): 
     return "{} : {} ({})".format(self.__class__.__name__, self.message, self.type) 

当你将raiseexception

raise ExcelFileException("Invalid or empty header", report) 

的误差将出现在self.dictionnary['errors']

+0

谢谢你,但我有一个条件:1)在报告中的信息必须是在法国和非常明确的(为客户的成功和团队的其他成员) – Alexandre

+0

并不是一个很好的办法:'raise ExcelFileException(“Error message”,“French description”)' – Alexandre

+0

如果你有错误信息存储在某个地方,你可以使用一个'dict'和一个法语描述错误信息,类似'report ['errors']。append(your_dict_with_french_descriptions [message])' – user312016