如何清理我在Java中编写的这种方法？

Question

我正在编写迷宫生成器。我有一个“小区”类，这是如下：

public class Cell { 
    public boolean northWall; 
    public boolean southWall; 
    public boolean eastWall; 
    public boolean westWall; 

    public Cell north; 
    public Cell south; 
    public Cell east; 
    public Cell west; 

    public boolean visited; 

    public Cell() { 
     northWall = true; 
     southWall = true; 
     eastWall = true; 
     westWall = true; 
     visited = false; 
    } 

    public boolean hasUnvisitedNeighbors() { 
     return ((north != null && !north.Visited) 
       || (south != null && !south.Visited) 
       || (east != null && !east.Visited) || (west != null && !west.Visited)); 
    } 

    public Cell removeRandomWall() { 
     List<Cell> unvisitedNeighbors = new ArrayList<Cell>(); 
     if (north != null && !north.Visited) 
      unvisitedNeighbors.add(north); 
     if (south != null && !south.Visited) 
      unvisitedNeighbors.add(south); 
     if (west != null && !west.Visited) 
      unvisitedNeighbors.add(west); 
     if (east != null && !east.Visited) 
      unvisitedNeighbors.add(east); 



     if (unvisitedNeighbors.size() == 0) { 
      return null; 
     } else { 
      Random randGen = new Random(); 
      Cell neighbor = unvisitedNeighbors.get(randGen 
        .nextInt((unvisitedNeighbors.size()))); 

      if (neighbor == north) { 
       northWall = false; 
       north.southWall = false; 
       return north; 
      } else if (neighbor == south) { 
       southWall = false; 
       south.northWall = false; 
       return south; 
      } else if (neighbor == west) { 
       westWall = false; 
       west.eastWall = false; 
       return west; 
      } else if (neighbor == east) { 
       eastWall = false; 
       east.westWall = false; 
       return east; 
      } 

      return null; 
     } 

    } 
} 

在我的节目A迷宫只是细胞的2D维阵列。创建阵列后，我手动进入并设置所有对相邻单元（北，南，东，西）的引用。

我想清理的是removeRandomWall（）。假设随机选择其访问标志设置为false的相邻小区，并删除该小区和连接它们的相邻小区的墙。

因此，它需要考虑所有未访问过的邻居单元，随机选择一个，然后将该单元格中的墙和相邻单元格设置为false，以便它们之间存在路径。我在上面尝试过，但看起来非常粗糙。

任何人都可以帮我吗？

Answer 1

代替具有4个独立的构件：

public Cell North; 
public Cell South; 
public Cell East; 
public Cell West; 

只是有1个阵列其中：

public Cell [] cells = new Cell[4]; 

和4常数：

public final int NORTH = 0; 
public final int EAST = 1; 
public final int SOUTH = 2; 
public final int WEST = 3; 

它使事情等除去随机壁非常容易。

Answer 2

对方向进行枚举，然后通过指定方向访问墙壁和邻居。

你应该让你的成员变量是私人的，并写成小写。

Answer 3

第一次尝试，我想使成员变量的私人最后，如果你可以：

public class Cell { 
    public boolean NorthWall; 
    public boolean SouthWall; 
    public boolean EastWall; 
    public boolean WestWall; 

    public Cell North; 
    public Cell South; 
    public Cell East; 
    public Cell West; 

    public boolean Visited; 

    public Cell() { 
     NorthWall = true; 
     SouthWall = true; 
     EastWall = true; 
     WestWall = true; 
     Visited = false; 
    } 

    public boolean hasUnvisitedNeighbors() { 
     return unvisited(North) || unvisited(South) || unvisited(East) || unvisited(West); 
    } 

    private List<Cell> getUnvisitedNeighbors() { 
     List<Cell> result = new ArrayList<Cell>(); 
     if (unvisited(North)) 
      result.add(North); 
     if (unvisited(South)) 
      result.add(South); 
     if (unvisited(West)) 
      result.add(West); 
     if (unvisited(East)) 
      result.add(East); 
     return result; 
    } 

    private boolean unvisited(Cell cell) { 
     return cell != null && !cell.Visited; 
    } 

    private Cell getRandomUnvisitedNeighbor() { 
     Random randGen = new Random(); 
     List<Cell> unvisitedNeighbors = getUnvisitedNeighbors(); 
     return unvisitedNeighbors.get(randGen.nextInt((unvisitedNeighbors.size()))); 
    } 

    public Cell removeRandomWall() { 
     if (!hasUnvisitedNeighbors()) { 
      return null; 
     } 
     Cell neighbor = getRandomUnvisitedNeighbor(); 
     if (neighbor == North) { 
      NorthWall = false; 
      North.SouthWall = false; 
     } else if (neighbor == South) { 
      SouthWall = false; 
      South.NorthWall = false; 
     } else if (neighbor == West) { 
      WestWall = false; 
      West.EastWall = false; 
     } else if (neighbor == East) { 
      EastWall = false; 
      East.WestWall = false; 
     } 

     return neighbor; 

    } 
} 

Answer 4

尝试删除检查空，使用“空单元格”对象......

public static final Cell NULL_CELL = new Cell(); 

因此，如果您将使用null来指示不存在此类单元，则现在可以使用NULL_CELL。

现在可以更换

if (north != null && !north.Visited) 
       unvisitedNeighbors.add(north); 

与

if (!north.isVisited()) { 
    unvisitedNeighbors.add(north); 
} 

通常在Java中，成员变量是私有的，并使用 “干将” 来访问它们...

private boolean northWall; 
private boolean southWall; 
private boolean eastWall; 
private boolean westWall; 

private Cell north; 
private Cell south; 
private Cell east; 
private Cell west; 

private boolean visited; 

public boolean hasNorthWall() { 
    return northWall; 
} 

public Cell getNorthCell() { 
    return north; 
} 

// etc.