如何干这个红宝石代码

Question

我想干这个代码。我似乎无法弄清楚如何。

def get_all_verb_nodes 
    all_verb_nodes = @all_nodes_ins_del_nodes.select { |node| 
    previous_node = node.xpath('preceding-sibling::w:r').last 
    base_word = previous_node.text.split.last.strip.delete('.!?,:') if previous_node 
    words = get_node_text(node) 
    next_node = node.next_element 
    next_node_is_insert_or_delete = is_insert_or_delete?(next_node.name) if next_node 
    next_node_word = next_node.text.strip if next_node 
    words.length <= 2 && words.any? { |word| is_a_verb?(base_word+word) || is_a_verb?(word) && !is_pluralized?(base_word+word, base_word+next_node_word) } && !next_node_is_insert_or_delete 
    } 
end 


def get_all_article_nodes 
    all_article_nodes = @all_nodes_ins_del_nodes.select { |node| 
    previous_node = node.xpath('preceding-sibling::w:r').last 
    base_word = previous_node.text.split.last.strip.delete('.!?,:') if previous_node 
    words = get_node_text(node) 
    next_node = node.next_element 
    next_node_is_insert_or_delete = is_insert_or_delete?(next_node.name) if next_node 
    next_node_word = next_node.text.strip if next_node 
    words.length <= 2 && words.any? { |word| @articleset.include?(word) || (@articleset.include?(base_word) if word == 'n') } && !@articleset.include?(next_node_word) && !next_node_is_insert_or_delete 
    } 
end 

两者几乎相同，只是最后一行定义了函数的具体要求。

任何想法赞赏。

Answer 1

这是对它的第一次剪裁。我移动了所有东西，所以它们按逻辑分组，并促进收益率。

def get_all_nodes 
    @all_nodes_ins_del_nodes.select do |node| 
    previous_node = node.xpath('preceding-sibling::w:r').last 
    base_word = previous_node.text.split.last.strip.delete('.!?,:') if previous_node 

    next_node = node.next_element 
    next_node_is_insert_or_delete = is_insert_or_delete?(next_node.name) if next_node 
    next_node_word = next_node.text.strip if next_node 

    words = get_node_text(node) 
    words.length <= 2 && 
    !next_node_is_insert_or_delete && 
    yield(words, base_word, next_node_word) 
    end 
end 

all_verb_nodes = get_all_nodes do |words, base_word, next_node_word| 
    words.any? do |word| 
    is_a_verb?(base_word + word) || 
    is_a_verb?(word) && 
    !is_pluralized?(base_word + word, base_word + next_node_word) 
    end 
end 

all_article_nodes = get_all_nodes do |words, base_word, next_node_word| 
    !@articleset.include?(next_node_word) && 
    words.any? do |word| 
    @articleset.include?(word) || (@articleset.include?(base_word) if word == 'n') 
    end 
end