循环链表 - 无限循环

教我自己编程，我决定做一个简单的瓦数计算器。每个州有不同的（平均）价格/ KWh。我的问题在代码中启动了第34行。 curr-> next不会为空。循环链表 - 无限循环

我在做什么错？

#include<stdio.h> 
#include<stdlib.h> 
#include<string.h> 


float calculate(float w, float cents, float h); 

struct states 
{ 
    char *name; 
    char *price; 
    struct states *next; 
}; 

int main() 
{ 
    float watts,hours,cents; 
    int a = 0; 
    struct states *curr, dict[52]; 
    char st_ab[52][3] = {"ID","ND","WA","AR","UT","LA","WY","SD","NE","KY","WV","OK","OR","MT","MS","TN","IN","NC","MS","IA","KS","VA","NM","MN","SC","AZ","GA","AL","CO","OH","TX","IL","FL","NV","MI","WI","PA","MD","DC","DE","MA","RI","CA","ME","VT","NJ","NH","AK","CT","NY","HI"}; 
    char st_pr[52][5] = {"8.0","8.1","8.2","8.7","8.8","8.9","8.9","9.0","9.0","9.0","9.2","9.2","9.4","9.6","9.7","9.8","10.0","10.2","10.3","10.5","10.5","10.5","10.7","10.9","11.0","11.1","11.1","11.1","11.2","11.2","11.3","11.7","11.7","11.7","13.0","13.0","13.2","13.7","13.7","13.7","14.8","14.9","15.2","15.5","16.1","16.3","16.5","17.5","18.1","18.1","33.2"}; 
    char state[2]; 

    for(a=0;a<=52;a++) 
    { 
     memset(&dict[a],0,sizeof(struct states)); /* zero out structure */ 
     if(a==52) 
     { 
      break; /* if this is the last struct, leave it NULL so we can loop through linked list */ 
     } 
     dict[a].next=&dict[a+1];   
    } 

    for(curr = dict;curr ->next != NULL;curr = curr->next) /* fill our list with state abbr. and cost/KWh */ 
    { 
     curr->name = st_ab[a]; 
     curr->price = st_pr[a]; 
     a++; 
    } 

    puts("Dictionary loaded!"); 
    printf(" Two letter state code: ");     /* get info from user */ 
    scanf("%s",state); 

    printf(" Wattage of appliance: "); 
    scanf("%f",&watts); 

    printf(" Hours of use per day: "); 
    scanf("%f",&hours); 

    for(curr = dict; curr->next != NULL; curr=curr->next) 
    { 
     printf("comparing %s with %s\n", curr->name,state); /* search for our state, set cents respectively */ 
     if((strcmp(curr->name,state)) == 0) 
     { 
      printf("State found! -- %s\n",state); 
      cents=atof(curr->price); 
      printf("%f cents\n",cents); 
      break; 
     } else { 
      printf("state didn't match\n"); 
      continue; 
     } 
    } 

    printf("\nAverage cost per day: %.2f\n", calculate(watts,cents,hours)); 
    printf("Average cost per year: %.2f\n\n", (calculate(watts,cents,hours)) * 365);  

    return 0; 

} 

float calculate(float w, float c, float h) 
{ 
    float kwh = (w/1000) * h; 
    float cos = kwh*(c/100); 
    return(cos); 
}

来源

2013-03-28 elixxir

'for（a = 0; a <= 52; a ++）'最后一个有效索引是51. –

的问题是在

dict[a].next = &dict[a+1];

C标准保证&dict[a+1]是从未NULL，即使它是一个过去的阵列的端部。这会导致下一个循环经过列表的末尾，导致未定义的行为（程序可能执行任何操作）。第一个循环后，做

dict[51].next = NULL;

结束链接列表。

编辑：与for(a=0;a<=52;a++)实际上你走过了数组末尾的两个元素，所以行为在两个地方是未定义的。为了解决这个问题，你需要循环到a<52。

来源

2013-03-28 14:43:57

非常感谢您的快速响应！经过一些其他小调整后，它现在工作非常好！ – elixxir

“curr->接下来就是从不为空” - 好了，你怎么能指望你的for循环停止，如果你停止条件是curr->下次等于空？

来源

2013-03-28 14:43:43 SomeWittyUsername

循环链表 - 无限循环

回答

相关问题