2016-09-19 70 views
1

以下是我的ADT。注意主要的是块可以嵌套(看children财产。模式匹配和递归问题

trait Cda { 
    def format: String = this match { 
    case f: Field => f.value 
    case Block(fields, children) => fields.map(f => f.format).mkString("|") + "|" + children.map(b => b.format).mkString("|") 
    case Record(keys, blocks) => blocks.map(b => b.format).mkString("|") 
    } 
} 

trait Field extends Cda { 
    val name: String 
    val value: String 
} 

case class StringField(name: String, value: String) extends Field 
case class DateField(name: String, value: String) extends Field 
case class TimeField(name: String, value: String) extends Field 
case class MatchKey(keyFields: Seq[Field]) extends Cda 
case class Block(fields: Seq[Field], children: Seq[Block] = Seq()) extends Cda 
case class Record(key: MatchKey, blocks: Seq[Block]) extends Cda 

以下是ADT

//Block - AI 
val aiBlockId = StringField("blockId", "AI") 
val addlFieldPos = StringField("AdditionalFieldPosition", "addlFieldPos") 
val addlFieldName = StringField("AdditionalFieldName", "addlFieldName") 
val AI = Block(Seq(aiBlockId, addlFieldPos, addlFieldName)) 

//Block - RPS 
val rpsBlockId = StringField("blockId", "RPS") 
val dateOfStatus = DateField("DateOfStatus", "19240811") 
val timeOfStatus = TimeField("TimeOfStatus", "023829") 

val rpsBlocks = Seq(rpsBlockId, dateOfStatus, timeOfStatus) 

val rpsNestedBlocks = Seq(AI) 

val RPS = Block(rpsBlocks, rpsNestedBlocks) 

我期待的格式返回RPS|19240811|023829|AI|addlFieldPos|addlFieldName的实例例示,但我得到一个额外的管|在最后:RPS|19240811|023829|AI|addlFieldPos|addlFieldName|

如何改变递归函数format(特别是case Block(fields,children))更正此问题?

回答

5

首先结合seqs。使用迭代器会更便宜,它不会创建中间集合。

scala> val as = Seq(1,2,3) ; val bs = Seq.empty[Int] 
as: Seq[Int] = List(1, 2, 3) 
bs: Seq[Int] = List() 

scala> (as ++ bs).mkString("|") 
res0: String = 1|2|3 

scala> (as.iterator ++ bs).mkString("|") 
res1: String = 1|2|3 

也就是说,

case Block(fields, children) => (fields.iterator ++ children).map(_.format).mkString("|") 
3
trait Cda { 
    def format: String = this match { 
    case f: Field => f.value 
    case Block(fields, children) => fields.map(f => f.format).mkString("|") + {if (!children.isEmpty) {"|" + children.map(b => b.format).mkString("|")} else ""} 
    case Record(keys, blocks) => blocks.map(b => b.format).mkString("|") 
    } 
}