返回未定义的方法'each'for nil：NilClass？

Question

这是我的视图中的代码：show.html.erb

<ul> 
<% @bullets.each do |r| %> 
    <li><%= r.content %></li> 
<% end %> 
</ul> 

这是我的代码中，所述控制器：users_controller.rb

if cookies[:bullets].nil? 
    @bullets = Bullet.all.shuffle.first(4) 
    cookies[:bullets] = @bullets.collect(&:id) 
else 
@bullets = [] 
cookies[:bullets].each do |id| 
    @bullets << Bullet.find(id) 
end 
end 

这将返回未定义的方法“各自”的零： NilClass上

<% @bullets.each do |r| %> 

我想知道为什么它这样做，我怎么能解决这个问题，从命名数据库（sqlite3的）表发布4项随机固定子弹内容“子弹”（列是内容）。

编辑：这是整个控制器：

class StudentsController < ApplicationController 
    #GET/
    def index 
     @students = Student.all 

     respond_to do |format| 
     format.html # index.html.erb 
     format.json { render json: @students } 
     end 
    end 

    #GET /new 
    def new 
     @student = Student.new 
    end 

    #POST 
    def create 
     @student = Student.new(params[:student]) 
      if @student.save 
     render :file => 'app/views/success' 
     else 
     render :file => 'app/views/students/fail' 
     end 
     end 

    #GET /students/{:id} 
    def show 
     @student = Student.find_by_url(params[:id]) 

      respond_to do |format| 
     format.html # show.html.erb 
     format.json { render json: @student } 
      end 
    end 

    #BULLETS Randomizing /students/new.html.erb 
    if cookies[:bullets].nil? 
     @bullets = Bullet.all.shuffle.first(4) 
     cookies[:bullets] = @bullets.collect(&:id) 
    else 
    @bullets = [] 
    cookies[:bullets].each do |id| 
     @bullets << Bullet.find(id) 
    end 
    end 

    #GET /students/1/edit 
    def edit 
     @student = Student.find_by_url(params[:id]) 
    end 

    def update 
     @student = Student.find_by_url(params[:id]) 
     respond_to do |format| 
     if @student.update_attributes(params[:student]) 
      format.html { redirect_to @student, notice: 'Student was successfully updated.'} 
     else 
      format.html { render action: "edit" } 
      format.json { render json: @student.errors, status: :unprocessable_entity } 
     end 
     end 
    end 

    #DELETE 
    def destroy 
    @student = Student.find_by_url(params[:id]) 
    @student.destroy 

     respond_to do |format| 
     format.html { redirect_to students_url } 
     format.json { head :no_content } 
     end 
    end 
end 

编辑＃2：像这样吗？

#GET /students/{:id} 
    def show 
     @student = Student.find_by_url(params[:id]) 

     #BULLETS Randomizing /students/show.html.erb 
    if cookies[:bullets].nil? 
     @bullets = Bullet.all.shuffle.first(4) 
     cookies[:bullets] = @bullets.collect(&:id) 
    else 
    @bullets = [] 
    cookies[:bullets].each do |id| 
     @bullets << Bullet.find(id) 
    end 
    end 

      respond_to do |format| 
     format.html # show.html.erb 
     format.json { render json: @student } 
      end 
    end 

Answer 1

看起来应该是：

#GET /students/{:id} 
def show 

    @student = Student.find_by_url(params[:id]) 

    #BULLETS Randomizing /students/new.html.erb 
    if cookies[:bullets].nil? 
    @bullets = Bullet.all.shuffle.first(4) 
    cookies[:bullets] = @bullets.collect(&:id) 
    else 
    # simpler to use an 'in list' for only 4 id's 
    Bullet.where("id in (?)", cookies[:bullets]) 
    end 

    respond_to do |format| 
    format.html # show.html.erb 
    format.json { render json: @student } 
    end 
end 

通知我转换你的循环在cookies阵列分为单个语句的“列表” - 应该简化生成的SQL查找。

虽然，这是值得商榷的，这个码应该被推到模型：

class Bullet < ActiveRecord::Base 

    NUM_USER_BULLETS = 4 
    # fetch a random set of 
    def self.user_bullets 
    Bullet.all.shuffle.first(NUM_USER_BULLETS) 
    end 
end 

或者类似的东西。那么你的控制器就更简单了：

#GET /students/{:id} 
def show 

    @student = Student.find_by_url(params[:id]) 

    #BULLETS Randomizing /students/new.html.erb 
    if cookies[:bullets].nil? 
    @bullets = Bullet.user_bullets 
    cookies[:bullets] = @bullets.collect(&:id) 
    else 
    # simpler to use an 'in list' for only 4 id's 
    Bullet.where("id in (?)", cookies[:bullets]) 
    end 

    respond_to do |format| 
    format.html # show.html.erb 
    format.json { render json: @student } 
    end 
end 

随着代码迁移到你的模型中，你的控制器就更简单了。

Answer 2

class StudentsController < ApplicationController 
    before_filter :get_bullets, :only => [:show] 


    def show 

    end 

    ... 


    protected 

    def get_bullets 
    #BULLETS Randomizing /students/new.html.erb 
    if cookies[:bullets].nil? 
     @bullets = Bullet.all.shuffle.first(4) 
     cookies[:bullets] = @bullets.collect(&:id) 
    else 
    @bullets = [] 
    cookies[:bullets].each do |id| 
     @bullets << Bullet.find(id) 
    end 
    end 

    end 



end 

Answer 3

我建议重构你的“随机子弹”的代码放到一个before_filter为show行动，并在数据库中进行随机化，这将是比加载整个表，并执行在Ruby中随机化速度快：

class UsersController < ApplicationController 
    before_filter :assign_bullets, :only => :show 

    # ... 

private 

    def assign_bullets 
    if cookies[:bullets] 
     @bullets = cookies[:bullets].map { |id| Bullet.find(id) } 
    else 
     @bullets = Bullet.order('RANDOM()').limit(4) 
     cookies[:bullets] = @bullets.map(&:id) 
    end 
    end 
end