request.getParameter正在检索'null'

Question

我正试图在我的项目中实现CRUD功能。我能够在jsp上显示数据库表，但是当我尝试删除一个条目时，出现这个错误：（我发现servlet中有一行存在问题，但不明白为什么它不能够检索bookingID）：

Warning: StandardWrapperValve[UserController]: Servlet.service() for servlet UserController threw exception 
 
java.lang.NumberFormatException: null 
 
\t at java.lang.Integer.parseInt(Integer.java:542) 
 
\t at java.lang.Integer.parseInt(Integer.java:615) 
 
\t at com.daniel.controller.UserController.doGet(UserController.java:34) 
 
\t at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) 
 
\t at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) 
 
\t at org.apache.catalina.core.StandardWrapper.service(StandardWrapper.java:1682) 
 
\t at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:318) 
 
\t at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:160) 
 
\t at org.apache.catalina.core.StandardPipeline.doInvoke(StandardPipeline.java:734) 
 
\t at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:673) 
 
\t at com.sun.enterprise.web.WebPipeline.invoke(WebPipeline.java:99) 
 
\t at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:174) 
 
\t at org.apache.catalina.connector.CoyoteAdapter.doService(CoyoteAdapter.java:416) 
 
\t at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:283) 
 
\t at com.sun.enterprise.v3.services.impl.ContainerMapper$HttpHandlerCallable.call(ContainerMapper.java:459) 
 
\t at com.sun.enterprise.v3.services.impl.ContainerMapper.service(ContainerMapper.java:167) 
 
\t at org.glassfish.grizzly.http.server.HttpHandler.runService(HttpHandler.java:206) 
 
\t at org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:180) 
 
\t at org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.java:235) 
 
\t at org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:119) 
 
\t at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:283) 
 
\t at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:200) 
 
\t at org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:132) 
 
\t at org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultFilterChain.java:111) 
 
\t at org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:77) 
 
\t at org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:536) 
 
\t at org.glassfish.grizzly.strategies.AbstractIOStrategy.fireIOEvent(AbstractIOStrategy.java:112) 
 
\t at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:117) 
 
\t at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.access$100(WorkerThreadIOStrategy.java:56) 
 
\t at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.run(WorkerThreadIOStrategy.java:137) 
 
\t at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:591) 
 
\t at org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:571) 
 
\t at java.lang.Thread.run(Thread.java:745)

Booking.java

package com.daniel.model; 
 

 
public class Booking { 
 
\t 
 
\t private int bookingID = -1; 
 
\t private String bookingDate = null; 
 
\t private String reasoning = null; 
 
\t private String bookingStatus = null; 
 
\t private String bookingReview = null; 
 
\t 
 
\t public int getBookingID() { 
 
\t \t return bookingID; 
 
\t } 
 
\t public void setBookingID(int bookingID) { 
 
\t \t this.bookingID = bookingID; 
 
\t } 
 
\t public String getBookingDate() { 
 
\t \t return bookingDate; 
 
\t } 
 
\t public void setBookingDate(String bookingDate) { 
 
\t \t this.bookingDate = bookingDate; 
 
\t } 
 
\t public String getReasoning() { 
 
\t \t return reasoning; 
 
\t } 
 
\t public void setReasoning(String reasoning) { 
 
\t \t this.reasoning = reasoning; 
 
\t } 
 
\t public String getBookingStatus() { 
 
\t \t return bookingStatus; 
 
\t } 
 
\t public void setBookingStatus(String bookingStatus) { 
 
\t \t this.bookingStatus = bookingStatus; 
 
\t } 
 
\t public String getBookingReview() { 
 
\t \t return bookingReview; 
 
\t } 
 
\t public void setBookingReview(String bookingReview) { 
 
\t \t this.bookingReview = bookingReview; 
 
\t } 
 
\t @Override 
 
\t public String toString() { 
 
\t \t return "Booking [bookingID=" + bookingID + ", bookingDate=" + bookingDate 
 
\t     + ", reasoning=" + reasoning + ", bookingStatus=" + bookingStatus + ", bookingReview=" 
 
\t     + bookingReview + "]"; 
 

 
\t } 
 

 

 
\t 
 
}

BookingDao.java

package com.daniel.dao; 
 

 
import java.sql.Connection; 
 
import java.sql.PreparedStatement; 
 
import java.sql.ResultSet; 
 
import java.sql.SQLException; 
 
import java.sql.Statement; 
 
import java.util.ArrayList; 
 
import java.util.List; 
 

 
import com.daniel.model.Booking; 
 
import com.daniel.util.DbUtil; 
 

 

 
public class BookingDao { 
 
\t 
 
\t private Connection connection; 
 

 
    public BookingDao() { 
 
     connection = DbUtil.getConnection(); 
 
    } 
 

 
    public void addUser(Booking booking) { 
 
     try { 
 
      PreparedStatement preparedStatement = connection 
 
        .prepareStatement("insert into booking(booking_id,booking_date,reasoning,booking_status) values (?, ?, ?, 'Upcoming')"); 
 
      // Parameters start with 1 
 
      preparedStatement.setInt(1, booking.getBookingID()); 
 
      preparedStatement.setString(2, booking.getBookingDate()); 
 
      preparedStatement.setString(3, booking.getReasoning()); 
 
      preparedStatement.executeUpdate(); 
 

 
     } catch (SQLException e) { 
 
      e.printStackTrace(); 
 
     } 
 
    } 
 

 
    public void deleteUser(int bookingID) { 
 
     try { 
 
      PreparedStatement preparedStatement = connection 
 
        .prepareStatement("delete from booking where booking_id=?"); 
 
      // Parameters start with 1 
 
      preparedStatement.setInt(1, bookingID); 
 
      preparedStatement.executeUpdate(); 
 

 
     } catch (SQLException e) { 
 
      e.printStackTrace(); 
 
     } 
 
    } 
 

 
    public void updateUser(Booking booking) { 
 
     try { 
 
      PreparedStatement preparedStatement = connection 
 
        .prepareStatement("update booking set booking_date=?, reasoning=?" + 
 
          "where booking_id=?"); 
 
      // Parameters start with 1 
 
      preparedStatement.setString(1, booking.getBookingDate()); 
 
      preparedStatement.setString(2, booking.getReasoning()); 
 
      preparedStatement.setInt(3, booking.getBookingID()); 
 
      preparedStatement.executeUpdate(); 
 

 
     } catch (SQLException e) { 
 
      e.printStackTrace(); 
 
     } 
 
    } 
 

 
    public List<Booking> getAllUsers() { 
 
     List<Booking> bookings = new ArrayList<Booking>(); 
 
     try { 
 
      Statement statement = connection.createStatement(); 
 
      ResultSet rs = statement.executeQuery("select * from booking"); 
 
      while (rs.next()) { 
 
       Booking booking = new Booking(); 
 
       booking.setBookingID(rs.getInt(1)); 
 
       booking.setBookingDate(rs.getString(2)); 
 
       booking.setReasoning(rs.getString(3)); 
 
       booking.setBookingStatus(rs.getString(4)); 
 
       booking.setBookingReview(rs.getString(5)); 
 
       bookings.add(booking); 
 
       System.out.println(booking); 
 
      } 
 
     } catch (SQLException e) { 
 
      e.printStackTrace(); 
 
     } 
 

 
     return bookings; 
 
    } 
 

 
    public Booking getUserById(int bookingID) { 
 
     Booking booking = new Booking(); 
 
     try { 
 
      PreparedStatement preparedStatement = connection. 
 
        prepareStatement("select * from booking where booking_id=?"); 
 
      preparedStatement.setInt(1, bookingID); 
 
      ResultSet rs = preparedStatement.executeQuery(); 
 

 
      if (rs.next()) { 
 
      \t booking.setBookingID(rs.getInt(1)); 
 
       booking.setBookingDate(rs.getString(2)); 
 
       booking.setReasoning(rs.getString(3)); 
 
       booking.setBookingStatus(rs.getString(4)); 
 
       booking.setBookingReview(rs.getString(5)); 
 
      } 
 
     } catch (SQLException e) { 
 
      e.printStackTrace(); 
 
     } 
 

 
     return booking; 
 
    } 
 

 

 
}

UserController.java

package com.daniel.controller; 
 

 

 
import java.io.IOException; 
 

 

 
import javax.servlet.RequestDispatcher; 
 
import javax.servlet.ServletException; 
 
import javax.servlet.http.HttpServlet; 
 
import javax.servlet.http.HttpServletRequest; 
 
import javax.servlet.http.HttpServletResponse; 
 

 
import com.daniel.dao.BookingDao; 
 
import com.daniel.model.Booking; 
 

 
public class UserController extends HttpServlet { 
 
\t 
 
\t private static final long serialVersionUID = 1L; 
 
\t  private static String INSERT_OR_EDIT = "/user.jsp"; 
 
\t  private static String LIST_USER = "/listUser.jsp"; 
 
\t  private BookingDao dao; 
 

 
\t  public UserController() { 
 
\t   super(); 
 
\t   dao = new BookingDao(); 
 
\t  } 
 

 
\t  protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { 
 
\t   String forward=""; 
 
\t   String action = request.getParameter("action"); 
 

 
\t   if (action.equalsIgnoreCase("delete")){ 
 
\t   \t System.out.println(request.getParameter("bookingID")); 
 
\t    int bookingID = Integer.parseInt(request.getParameter("bookingID")); 
 
\t    dao.deleteUser(bookingID); 
 
\t    forward = LIST_USER; 
 
\t    request.setAttribute("users", dao.getAllUsers());  
 
\t   } else if (action.equalsIgnoreCase("edit")){ 
 
\t    forward = INSERT_OR_EDIT; 
 
\t    int bookingID = Integer.parseInt(request.getParameter("bookingID")); 
 
\t    Booking booking = dao.getUserById(bookingID); 
 
\t    request.setAttribute("booking", booking); 
 
\t   } else if (action.equalsIgnoreCase("listUser")){ 
 
\t    forward = LIST_USER; 
 
\t    request.setAttribute("users", dao.getAllUsers()); 
 
\t   } else { 
 
\t    forward = INSERT_OR_EDIT; 
 
\t   } 
 

 
\t   RequestDispatcher view = request.getRequestDispatcher(forward); 
 
\t   view.forward(request, response); 
 
\t  } 
 

 
\t  protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { 
 
\t   Booking booking = new Booking(); 
 
\t   booking.setBookingDate(request.getParameter("bookingDate")); 
 
\t   booking.setReasoning(request.getParameter("reasoning")); 
 
\t   String bookingID = request.getParameter("bookingID"); 
 
\t   if(bookingID == null || bookingID.isEmpty()) 
 
\t   { 
 
\t    dao.addUser(booking); 
 
\t   } 
 
\t   else 
 
\t   { 
 
\t   booking.setBookingID(Integer.parseInt(bookingID)); 
 
\t    dao.updateUser(booking); 
 
\t   } 
 
\t   RequestDispatcher view = request.getRequestDispatcher(LIST_USER); 
 
\t   request.setAttribute("users", dao.getAllUsers()); 
 
\t   view.forward(request, response); 
 
\t  } 
 

 

 
}

listUser.jsp

<%@ page language="java" contentType="text/html; charset=EUC-KR" pageEncoding="EUC-KR"%> 
 
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c"%> 
 
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt"%> 
 
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> 
 

 
<html> 
 
<head> 
 
<meta http-equiv="Content-Type" content="text/html; charset=EUC-KR"> 
 
<title>Show All Users</title> 
 
</head> 
 
<body> 
 
    <table border=1> 
 
     <thead> 
 
      <tr> 
 
       <th>User Id</th> 
 
       <th>First Name</th> 
 
       <th>Last Name</th> 
 
       <th>DOB</th> 
 
       <th>Email</th> 
 
       <th colspan=2>Action</th> 
 
      </tr> 
 
     </thead> 
 
     <tbody> 
 
      <c:forEach items="${users}" var="booking"> 
 
       <tr> 
 
        <td><c:out value="${booking.bookingID}" /></td> 
 
        <td><c:out value="${booking.bookingDate}" /></td> 
 
        <td><c:out value="${booking.reasoning}" /></td> 
 
        <td><c:out value="${booking.bookingStatus}" /></td> 
 
        <td><c:out value="${booking.bookingReview}" /></td> 
 
        <td><a href="UserController?action=edit&userId=<c:out value="${booking.bookingID}"/>">Update</a></td> 
 
        <td><a href="UserController?action=delete&userId=<c:out value="${booking.bookingID}"/>">Delete</a></td> 
 
       </tr> 
 
      </c:forEach> 
 
     </tbody> 
 
    </table> 
 
    <p><a href="UserController?action=insert">Add User</a></p> 
 
</body> 
 
</html>

Answer 1

在模板中设置的链接与参数userId=<c:out value="${booking.bookingID}"/>，然后尝试回读参数与request.getParameter("bookingID")。

由于参数名为userId而不是bookingID对getParameter的调用返回null，因此该名称的参数不存在。

这可以通过确保您在两个地方使用相同的名称来解决。

Answer 2

您的链接删除使用以下网址：

UserController?action=delete&userId=<c:out value="${booking.bookingID}"/> 

而且你的代码使用

request.getParameter("bookingID") 

所以，很显然，该bookingID参数为空，因为在URL中有这样的参数。该参数被命名为userId。

请注意，使用链接删除的东西是一个非常非常糟糕的主意。任何人都可以向您发送包含删除网址的链接，如果您点击该链接：Boom！你已经删除了一个用户。

更糟的是：如果该页面被公开，GoogleBot（和所有其他搜索引擎机器人）将点击页面中的每个链接来抓取您的网站，从而删除每个用户。

使用与POST一起提交的表单。