2013-07-02 13 views
1

对python和一般编程非常不熟悉。回文产生器

我试图创建一个函数,生成一个回文数列表达到指定的限制。

当我运行下面的代码时,它返回一个空列表[]。不确定这是为什么。

def palin_generator(): 
    """Generates palindromic numbers.""" 

    palindromes=[] 
    count=0 
    n=str(count) 

    while count<10000: 
     if n==n[::-1] is True: 
      palindromes.append(n) 
      count+=1 
     else: 
      count+=1 

    print palindromes 

回答

3

您的if声明确实不是做你认为它确实如此。

你申请运营商链接和正在测试两两件事:

(n == n[::-1]) and (n[::-1] is True) 

这将始终False因为'0' is TrueTrue。演示:

>>> n = str(0) 
>>> n[::-1] == n is True 
False 
>>> n[::-1] == n 
True 

comparisons documentation

比较可以被任意链的,例如,x < y <= z相当于x < y and y <= z,不同之处在于y只计算一次(但在这两种情况下z不是在评价全部在x < y被发现是错误的)。

你做需要测试is True这里; Python的if说法是完全有能力测试,对自身的:

if n == n[::-1]: 

你的下一个问题是,你永远不会改变n,所以现在你会追加1000个'0'字符串列表。

你会更好使用for遍历xrange(1000)并设置每次迭代n

def palin_generator(): 
    """Generates palindromic numbers.""" 

    palindromes=[] 

    for count in xrange(10000): 
     n = str(count) 
     if n == n[::-1]: 
      palindromes.append(n) 

    print palindromes 

现在你的函数的工作原理:

>>> palin_generator() 
['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '11', '22', '33', '44', '55', '66', '77', '88', '99', '101', '111', '121', '131', '141', '151', '161', '171', '181', '191', '202', '212', '222', '232', '242', '252', '262', '272', '282', '292', '303', '313', '323', '333', '343', '353', '363', '373', '383', '393', '404', '414', '424', '434', '444', '454', '464', '474', '484', '494', '505', '515', '525', '535', '545', '555', '565', '575', '585', '595', '606', '616', '626', '636', '646', '656', '666', '676', '686', '696', '707', '717', '727', '737', '747', '757', '767', '777', '787', '797', '808', '818', '828', '838', '848', '858', '868', '878', '888', '898', '909', '919', '929', '939', '949', '959', '969', '979', '989', '999', '1001', '1111', '1221', '1331', '1441', '1551', '1661', '1771', '1881', '1991', '2002', '2112', '2222', '2332', '2442', '2552', '2662', '2772', '2882', '2992', '3003', '3113', '3223', '3333', '3443', '3553', '3663', '3773', '3883', '3993', '4004', '4114', '4224', '4334', '4444', '4554', '4664', '4774', '4884', '4994', '5005', '5115', '5225', '5335', '5445', '5555', '5665', '5775', '5885', '5995', '6006', '6116', '6226', '6336', '6446', '6556', '6666', '6776', '6886', '6996', '7007', '7117', '7227', '7337', '7447', '7557', '7667', '7777', '7887', '7997', '8008', '8118', '8228', '8338', '8448', '8558', '8668', '8778', '8888', '8998', '9009', '9119', '9229', '9339', '9449', '9559', '9669', '9779', '9889', '9999'] 
+0

很好的答案,谢谢你的回应。 – Chris

0

if块检查是否n是回文,而n值不会改变。它只分配一次。

此外,您可以消除is True部分,因为这是多余的。

但这不是你现在问题的根源。事实上,您的if失败的原因是运营商优先。你现在写的东西相当于if n==(n[::-1] is True):这是if n==False:,这永远不会发生。

+0

但是,它会追加1000次'0'。 –

+0

@MartijnPieters:是的。我添加了一个关于'is'的解释。 – recursive

1

通过所有的数字去是非常低效的。你可以这样产生回文:

#!/usr/bin/env python 
from itertools import count 

def getPalindrome(): 
    """ 
     Generator for palindromes. 
     Generates palindromes, starting with 0. 
     A palindrome is a number which reads the same in both directions. 
    """ 
    yield 0 
    for digits in count(1): 
     first = 10 ** ((digits - 1) // 2) 
     for s in map(str, range(first, 10 * first)): 
      yield int(s + s[-(digits % 2)-1::-1]) 

def allPalindromes(minP, maxP): 
    """Get a sorted list of all palindromes in intervall [minP, maxP].""" 
    palindromGenerator = getPalindrome() 
    palindromeList = [] 
    for palindrome in palindromGenerator: 
     if palindrome > maxP: 
      break 
     if palindrome < minP: 
      continue 
     palindromeList.append(palindrome) 
    return palindromeList 

if __name__ == "__main__": 
    print(allPalindromes(4456789, 5000000)) 

这段代码比上面的代码快得多。

另请参阅:Python 2.x remarks