ReactJS和

Question

我有这个代码的问题进行并发API调用干：

let tmpContributors = [...this.state.contributors]; 
 
for (let i = 0; i < 10; i++) {//10 most active contributors because of performance and github limits 
 
    contributorPropertiesPromises.push(axios.get(`${this.state.contributors[i].followers_url}?per_page=100&${API_KEY}`) 
 
    .then(res => { 
 
     if(res.data.length > 100) { 
 
      tmpContributors[i].contributorFollowers = res.data.length; 
 
     } 
 
     else { 
 
      for(let page = 1; page <= 5; page++) {//5 pages because of github limitation - can be done by recursion checking if res.headers.link.includes('rel="next"') 
 
       axios.get(`${this.state.contributors[i].followers_url}?page=${page}&per_page=100&${API_KEY}`) 
 
       tmpContributors[i].contributorFollowers += res.data.length; 
 
      } 
 
     } 
 
    })) 
 
} 
 
for (let i = 0; i < 10; i++) {//10 most active contributors because of performance and github limits 
 
    contributorPropertiesPromises.push(axios.get(`${this.state.contributors[i].repos_url}?per_page=100&${API_KEY}`) 
 
    .then(res => { 
 
     if(res.data.length > 100) { 
 
      tmpContributors[i].contributorRepositories = res.data.length; 
 
     } 
 
     else { 
 
      for(let page = 1; page <= 5; page++) {//5 pages because of github limitation - can be done by recursion checking if res.headers.link.includes('rel="next"') 
 
       axios.get(`${this.state.contributors[i].repos_url}?page=${page}&per_page=100&${API_KEY}`) 
 
       tmpContributors[i].contributorRepositories += res.data.length; 
 
      } 
 
     } 
 
    })) 
 
} 
 
for (let i = 0; i < 10; i++) {//10 most active contributors because of performance and github limits 
 
    contributorPropertiesPromises.push(axios.get(`${this.state.contributors[i].gists_url}?per_page=100&${API_KEY}`) 
 
    .then(res => { 
 
     if(res.data.length > 100) { 
 
      tmpContributors[i].contributorGists = res.data.length; 
 
     } 
 
     else { 
 
      for(let page = 1; page <= 5; page++) {//5 pages because of github limitation - can be done by recursion checking if res.headers.link.includes('rel="next"') 
 
       axios.get(`${this.state.contributors[i].gists_url}?page=${page}&per_page=100&${API_KEY}`) 
 
       tmpContributors[i].contributorGists += res.data.length; 
 
      } 
 
     } 
 
    })) 
 
}

它的工作原理，但它不是很干。我试着用两个参数（例如propertyUrl，contributorProperty）和字符串作为参数来调用一个函数。不适合我。 你们能帮我解决吗？

Answer 1

function getStuff(propertyUrl, contributorProperty) { 
    for (let i = 0; i < 10; i++) { 
     contributorPropertiesPromises.push(axios.get(`${this.state.contributors[i][propertyUrl]}?per_page=100&${API_KEY}`) 
      .then(res => { 
       if(res.data.length > 100) { 
        tmpContributors[i][contributorProperty]= res.data.length; 
       } 
       else { 
        for(let page = 1; page <= 5; page++) { 
         axios.get(`${this.state.contributors[i][propertyUrl]}?page=${page}&per_page=100&${API_KEY}`) 
         tmpContributors[i][contributorProperty] += res.data.length; 
        } 
       } 
      }) 
     ) 
    } 
} 

然后调用它三次，

getStuff('gists_url', 'contributorGists') 
//... etc 

Answer 2

这个什么：

let tmpContributors = [...this.state.contributors]; 
const getAxiosPromise = (index, path, query = '') => 
    axios.get(
    `${this.state.contributors[index][path]}?${query}per_page=100&${API_KEY}` 
); 

const dealWithResp = (res, path, index) => { 
    if (res.data.length > 100) { 
    tmpContributors[index].contributorFollowers = res.data.length; 
    } else { 
    for (let page = 1; page <= 5; page++) { 
     getAxiosPromise(index, path, `page=${page}&`); 
     tmpContributors[index].contributorFollowers += res.data.length; 
    } 
    } 
}; 

for (let i = 0; i < 10; i++) { 
    //10 most active contributors because of performance and github limits 
    contributorPropertiesPromises.push(
    getAxiosPromise(i, followers_url).then(res => dealWithResp(res, followers_url, i)) 
); 
    contributorPropertiesPromises.push(
    getAxiosPromise(i, repos_url).then(res => dealWithResp(res, repos_url, i)) 
); 
    contributorPropertiesPromises.push(
    getAxiosPromise(i, repos_url).then(res => dealWithResp(res, gists_url, i)) 
); 
}