2012-12-17 64 views
1

即使更新查询失败,仍然显示成功,我无法获得最后2个回应。如果任何人有任何关于此代码的任何建议,以改善任何行,请做!显示错误消息PHP Mysql

<?php 
     if(!empty($_POST['username']) && !empty($_POST['answer'])) { 
      $username = $_POST['username']; 
      $idfetch = mysql_query("SELECT id FROM users WHERE username ='$username'") //check it 
      or die(mysql_error()); 
      $fetched = mysql_fetch_array($idfetch); 
      $id = $fetched['id']; //get users id for checking 
      $answer = $_POST['answer']; 
      $password = (mysql_real_escape_string($_POST['password'])); 
      $confpass = (mysql_real_escape_string($_POST['confpass'])); 
      if ($password != $confpass) { 
       echo ("Passwords do not match, please try again."); 
       exit; 
      } 
      $updatequery = mysql_query("UPDATE users SET PASSWORD='$password' WHERE id='$id' AND username='$username' AND answer='$answer'"); 
      if($updatequery) { 
       echo "<h1>Success</h1>"; 
       echo "<p>Your account password was successfully changed. Please <a href=\"login.php\">click here to login</a>.</p>"; 
      } 
      else { 
       echo "<h1>Error</h1>"; 
       echo "<p>Sorry, but a field was incorrect.</p>"; 
      } 
     } 
?> 

在此先感谢!

+0

请不要在新的应用程序中使用'mysql_query'。如果不使用*完全*这是非常危险的,这是一个巨大的麻烦,尽管我已经看到你至少在这里尝试。不过,你逃脱了三个变量中的两个并引入了一个巨大的注入漏洞。公共互联网上足够接近并不够好。至少你应该使用[PDO](http://bobby-tables.com/php),除非你有一个很好的理由,因为当使用SQL占位符时,这些错误通常是不存在的。 – tadman

+0

感谢您的评论,我很欣赏它,我会研究这一点。我没有看到任何东西,但我的研究生病了! – sparkones

+0

感谢大家对我所感谢的所有评论。 – sparkones

回答

2
mysql_query("UPDATE users SET PASSWORD='$password' WHERE id='$id' AND username='$username' AND answer='$answer'") or die(mysql_error()."update failed"); 

,并使用

mysql_affected_rows() 

Returns the number of affected rows on success, and -1 if the last query failed. 
0

使用

if(mysql_num_rows($updatequery) > 0) { 
    // success 
} else { 
    // error 
} 

$updatequery永远是真(非NULL),直到有您的查询错误

+1

不会** [mysql_affected_rows()](http://php.net/manual/en/function.mysql-affected-rows.php)**是正确的功能吗? –

+0

@DamienPirsy是正确的。从手册:['mysql_affected_rows()'](http://php.net/manual/en/function.mysql-affected-rows.php) - 获取最后一次INSERT,UPDATE,REPLACE或DELETE查询。 ['mysql_num_rows()'](http://php.net/manual/en/function.mysql-num-rows.php) - 检索结果集中的行数。该命令仅对像SELECT或SHOW这样的返回实际结果集的语句有效。要检索受INSERT,UPDATE,REPLACE或DELETE查询影响的行数,请使用mysql_affected_rows()。 – Sean

0

使用或模具(mysql_error()),因为它会显示MySQL错误如果您的查询出现错误。

$updatequery = mysql_query("UPDATE users SET PASSWORD='$password' WHERE id='$id' AND username='$username' AND answer='$answer'") or die(mysql_error());

1

使用尝试捕捉,并试图让错误启用错误在PHP报告还

<?php 
     error_reporting(E_ALL); 
     ini_set('display_errors','On'); 
     if(!empty($_POST['username']) && !empty($_POST['answer'])) { 
     $username = $_POST['username']; 
     $idfetch = mysql_query("SELECT id FROM users WHERE username ='$username'") //check it 
     or die(mysql_error()); 
     $fetched = mysql_fetch_array($idfetch); 
     $id = $fetched['id']; //get users id for checking 
     $answer = $_POST['answer']; 
     $password = (mysql_real_escape_string($_POST['password'])); 
     $confpass = (mysql_real_escape_string($_POST['confpass'])); 
     if ($password != $confpass) { 
     echo ("Passwords do not match, please try again."); 
     exit;} 

     try{ 
     $updatequery = mysql_query("UPDATE users SET PASSWORD='$password' WHERE id='$id' AND username='$username' AND answer='$answer'"); 
     if($updatequery) { 
     echo "<h1>Success</h1>"; 
     echo "<p>Your account password was successfully changed. Please <a href=\"login.php\">click here to login</a>.</p>"; } 
     else { 
     echo "<h1>Error</h1>"; 
     echo "<p>Sorry, but a field was incorrect.</p>"; 
     } 

     }catch(Exception $e){ 
      print_R($e); 
     } 
     } 
0

试试这个:

$idfetch = mysql_query("SELECT id FROM users WHERE username ='$username'"); 
if(!idfetch){ 
    die(mysql_error()); 
} 

执行相同的所有其他查询过。

0

尝试此操作,首先将行计数值计数为1然后继续登录过程。

<?php 
    if(!empty($_POST['username']) && !empty($_POST['answer'])) { 
     $username = $_POST['username']; 
     $idfetch = mysql_query("SELECT id FROM users WHERE username ='$username'") //check it 
     or die(mysql_error()); 
     $fetched = mysql_fetch_array($idfetch); 

     $count= mysql_num_rows($idfetch); 

     if($count>0){ 
     $id = $fetched['id']; //get users id for checking 
     $answer = $_POST['answer']; 
     $password = (mysql_real_escape_string($_POST['password'])); 
     $confpass = (mysql_real_escape_string($_POST['confpass'])); 
     if ($password != $confpass) { 
      echo ("Passwords do not match, please try again."); 
      exit; 
     } 

     $updatequery = mysql_query("UPDATE users SET PASSWORD='$password' WHERE id='$id' AND username='$username' AND answer='$answer'"); 

      if($updatequery) { 
      echo "<h1>Success</h1>"; 
      echo "<p>Your account password was successfully changed. Please <a href=\"login.php\">click here to login</a>.</p>"; 
     } 
      else { 
      echo "<h1>Error</h1>"; 
      echo "<p>Sorry, but a field was incorrect.</p>"; 
      } 
    } } ?>