脚本来更新数据库

Question

我有更新Oracle数据库下面这段Perl脚本的。它工作得很好;但是，我想知道如何来简化这个脚本：

use DBI; 
my $dbh; 
my $bad_form = "text.txt"; 

open (OUT, $bad_form) or die "Could not open $bad_form"; 
while (<OUT>){ 
    chomp $_; 
    my ($item_id, $description, $form_id_1, $form_id_3) = split(/\|/, $_); 

    my $new_form_id_1 = form_1($form_id_1); 
    my $new_form_id_3 = form_3($form_id_3); 

    if ($new_form_id_1 ne 'null'){ 
      my $sql = "update item_table set form_id_1 = '$new_form_id_1' where item_id = '$item_id'"; 
      my $item = $dbh->prepare($sql) or (log_error("Couldn't prepare statement: " . $dbh->errstr) and return 2); 
      $item->execute() or (log_error("Couldn't execute statement: " . $item->errstr) and return 2); 
    }else{ 
      $form_id_1 = "correct value"; 
      $new_form_id_1 = "no updated"; 
    } 

    if ($new_form_id_3 ne 'null'){ 
      my $sql = "update item_table set form_id_3 = '$new_form_id_3' where item_id = '$item_id'"; 
      my $item = $dbh->prepare($sql) or (log_error("Couldn't prepare statement: " . $dbh->errstr) and return 2); 
      $item->execute() or (log_error("Couldn't execute statement: " . $item->errstr) and return 2); 

    }else{ 
      $form_id_3 = "correct value"; 
      $new_form_id_3 = "no updated"; 
    } 
} 

其中功能form_1（）和form_3（）用于生成新值form_id_1,3。

任何帮助，将不胜感激。非常感谢您的帮助。

Answer 1

使用严格的;

将你的两个prepare()出去了的while循环，使用?作为占位符。然后在循环内部只需调用execute($new_form_id_x, $item_id)以获取适当的预处理语句句柄。