我有三个文件:分配大小无效? C++
Text.h
#include <string>
namespace w3
{
class Text
{
std::string file_name;
std::string* handler;
int records;
public:
Text();
Text(char*);
size_t size() const;
Text(const Text&);
Text& operator=(const Text&);
Text(Text&&);
Text&& operator=(Text &&);
~Text();
};
}
Text.cpp
#include <iostream>
#include <string>
#include <fstream>
#include <cstring>
#include "Text.h"
namespace w3
{
Text::Text()
{
file_name = "";
handler = nullptr;
records = 0;
}
Text::Text(char* file)
{
file_name = file;
if (file[0]='\0')
{
file_name=" ";
std::cout << "can not find file name !!" <<std::endl;
}
else
{
std::fstream f(file_name);
std::string line;
if (f.is_open()) //ERROR
{
while (std::getline(f,line,'\n'))
{
records++;
}
}
else
{
std::cout << "file not open !!" <<std::endl;
}
std::string* handle = new std::string[size()];
f.clear();
f.seekg(0,std::ios::beg);
int counter = 0;
while (std::getline(f,line,'\n'))
{
if (counter != records)
{
handle[counter]=line;
counter++;
}
}
}
}
size_t Text::size() const
{
return (size_t)records;
}
Text::Text(const Text& src)
{
std::string file_name = src.file_name;
int no_of_rec = src.records;
if (src.handler != nullptr)
{
handler = new std::string[src.size()];
handler = src.handler;
}
else
{
handler = nullptr;
}
}
Text& Text::operator=(const Text& src)
{
if (this != &src)
{
int no_of_rec = src.records;
std::string file_name = src.file_name;
if (src.handler != nullptr)
{
handler = new std::string[src.size()];
handler=src.handler;
}
else
{
handler = nullptr;
}
}
return *this;
}
Text::Text(Text&& src)
{
file_name=src.file_name;
handler = src.handler;
records = src.records;
src.file_name = " ";
src.handler = nullptr;
src.records = 0;
}
Text&& Text::operator=(Text&& src)
{
if (&src != this)
{
file_name = src.file_name;
handler = src.handler;
records = src.records;
src.file_name = " ";
src.handler = nullptr;
src.records = 0;
}
return std::move(*this);
}
Text::~Text()
{
//delete [] handler;
}
}
w3.cpp
#include <iostream>
#include <iomanip>
#include <utility>
#include <ctime>
#include "Text.h"
#define TIME(start, end) double((end) - (start))/CLOCKS_PER_SEC
int main (int argc, char* argv[]) {
if (argc == 1) {
std::cerr << argv[0] << ": missing file operand\n";
return 1;
}
else if (argc != 2) {
std::cerr << argv[0] << ": too many arguments\n";
return 2;
}
std::clock_t cs, ce;
{
std::cout << std::fixed << std::setprecision(3);
cs = std::clock();
w3::Text a;
ce = std::clock();
std::cout << "Constructor " << TIME(cs, ce) << " seconds";
std::cout << " - a.size = " << a.size() << std::endl;
cs = std::clock();
w3::Text b(argv[1]);
ce = std::clock();
std::cout << "Constructor " << TIME(cs, ce) << " seconds";
std::cout << " - b.size = " << b.size() << std::endl;
cs = std::clock();
a = b;
ce = std::clock();
std::cout << "Copy Assignment " << TIME(cs, ce) << " seconds";
std::cout << " - a.size = " << a.size() << std::endl;
cs = std::clock();
a = std::move(b);
ce = std::clock();
std::cout << "Move Assignment " << TIME(cs, ce) << " seconds";
std::cout << " - a.size = " << a.size() << std::endl;
cs = std::clock();
w3::Text c = a;
ce = std::clock();
std::cout << "Copy Constructor " << TIME(cs, ce) << " seconds";
std::cout << " - c.size = " << c.size() << std::endl;
cs = std::clock();
w3::Text d = std::move(a);
ce = std::clock();
std::cout << "Move Constructor " << TIME(cs, ce) << " seconds";
std::cout << " - d.size = " << d.size() << std::endl;
cs = std::clock();
}
ce = std::clock();
std::cout << "Destructor " << TIME(cs, ce) << " seconds\n";
}
我在函数文本得到一个错误:: if(f.is_open())行的文本(char *文件)。
现在,我调试并得出结论,错误导致无效的分配大小。
当我进一步检查错误时,我发现记录值会有一个荒谬的负数,例如-858993460!
我需要指导如何解决这个问题。
正在打开的文本文件是一个非常大的文件...
谢谢。应该说你能消除这种代码的主要部分,再加上有,如果你使用std::vector<std::string>
作为handler
成员发生错误的可能性很小,而不是std::string*
'正在打开的文本文件是一个非常大的文件...'超过2GB? (随机猜测,还没有看过代码) – deviantfan
为什么不使用'std :: vector'而不是原始数组? –
crashmstr
@Shrooms您正在创建本地'handle'变量,并且不会分配给'handler'成员。 – Arpegius