@RequestMapping(value = "/product/baselist", method = RequestMethod.POST)
public ResponseEntity<Object> baseListProductFilters(@RequestBody final ObjectNode json) {
LOGGER.debug("Gettig all product filters");
try {
final int offset = json.get("offset") == null ? OFFSET_AUTOCOMPL
: json.get("offset").asInt(OFFSET_AUTOCOMPL);
final int limit = json.get("limit") == null ? LIMIT_AUTOCOMPL : json.get("limit").asInt(LIMIT_AUTOCOMPL);
return ResponseEntity.status(HttpStatus.OK)
.body(filterService.getList(getUsername(), ResourceType.PRODUCT, offset, limit));
} catch (Exception e) {
LOGGER.error("Error getting product filter list: ", e);
return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(e);
}
}
所以这里是我的代码。我安装了PMD代码分析器。它暗示我应该只有一次返回。 “DD'-异常出现OnlyOne返回没有DD异常
@RequestMapping(value = "/product/baselist", method = RequestMethod.POST)
public ResponseEntity<Object> baseListProductFilters(@RequestBody final ObjectNode json) {
LOGGER.debug("Gettig all product filters");
ResponseEntity<Object> toReturn;
try {
final int offset = json.get("offset") == null ? OFFSET_AUTOCOMPL
: json.get("offset").asInt(OFFSET_AUTOCOMPL);
final int limit = json.get("limit") == null ? LIMIT_AUTOCOMPL : json.get("limit").asInt(LIMIT_AUTOCOMPL);
toReturn = ResponseEntity.status(HttpStatus.OK)
.body(filterService.getList(getUsername(), ResourceType.PRODUCT, offset, limit));
} catch (Exception e) {
LOGGER.error("Error getting product filter list: ", e);
toReturn = ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(e);
}
return toReturn;
}
有没有更多的OnlyOneReturn违规,但是:所以我这样做。我的客户需要OnlyOneReturn不被忽略。任何想法如何解决这个问题?
请考虑添加'pmd'标签,并删除'spring *'标签,因为这个问题不是spring相关的。 – xerx593