2015-09-21 54 views
-1

我试图编写一个程序,提示用户他们输入的信息是重复的。但开发-C++始终告诉我“类学生”没有名为“P”成员,所以我猜有一些错误的算法或代码,请看看:算法来搜索重复的信息?

Student.h

#ifndef STUDENT_H_ 
#define STUDENT_H_ 

#include "Person.h" 

class Student: public Person { 
    int ent_year; 
    string major; 
    public: 
     Student *next; 
     Student(); 
     Student (int i_pid, string i_fname, string i_dob, string i_addr, int i_ent_year, string i_major); 
     void Show(); 

     void Set_ent_year (int i_ent_year); 
     void Set_major(string i_major); 

     int Get_ent_year(); 
     string Get_major(); 
}; 

#endif 

StudentList.h

#ifndef STUDENTLIST_H_ 
    #define STUDENTLIST_H_ 

    #include "Student.h" 

    class StudentList { 
     private: 
      Student *head, *tail; 

     public: 
      Student p; 
      Student *next; 
      StudentList(); 

      void SList_Init(); 
      void AddTail (Student *p); 
      void SubString (string s); 
      void ListShow(); 
      void ReadFile(); 
      void findID(); 
      void findName(); 
      void findDOB(); 
      void findAddr(); 
      void findMajor(); 
      void findEY(); 
      void changeName(); 
      void changeDOB(); 
      void changeAddr(); 
      void changeMajor(); 
      void changeEY(); 
      void Add_Student(); 

      bool is_duplicate(Student t); 
    }; 

    void Open_file (string file_name); 
    void Close_file(); 

    #endif 

.cpp文件

bool equalStudent(Student s1, Student s2) 
{ 
    return (s1.Get_ent_year() == s2.Get_ent_year()) 
      && ((s1.Get_addr()).compare(s2.Get_addr()) == 0) 
      && ((s1.Get_dob()).compare(s2.Get_dob()) == 0) 
      && ((s1.Get_fname()).compare(s2.Get_fname()) == 0) 
      && ((s1.Get_major()).compare(s2.Get_major()) == 0); 
} 


bool is_duplicate(Student s1) { 
    Student *head; 
    Student *h1 = head; 
    while (h1 != NULL) { 
     if (equalStudent(h1->p, s1)) { 
      return true; 
     } 
     h1 = h1->next; 
    } 
    return false; 
} 

void StudentList:: Add_Student() 
{ 
    int new_pid, new_ent_year; 
    string new_fname, new_dob, new_addr, new_major; 
    cout << endl << "Enter student information:" << endl; 
    cout << "Full name: "; cin.ignore(1); getline (cin,new_fname); 
    cout << "Date of birth: "; getline (cin,new_dob); 
    cout << "Address: "; getline (cin,new_addr); 
    cout << "Entrance year: "; cin >> new_ent_year; 
    cout << "Major: "; cin.ignore(1); getline (cin,new_major); 

bool duplicate = is_duplicate(new_pid, new_ent_year, new_fname, new_dob, new_addr, new_major); // call function to check for duplicate info 
if (duplicate) { 
    string proceed; 
    cout << "Duplicated! Continue? Proceed? [y/n] "; cin.ignore(1); getline (cin, proceed); 
    if (proceed != "y") { 
     return; 
    } 
} 
Student *p = new Student (new_pid, new_fname, new_dob, new_addr, new_ent_year, new_major); 
AddTail (p); 

f.seekg(0, ios::end); 
f << endl << new_pid << ":" << new_fname << ":" << new_dob << ":" << new_addr << ":" << new_ent_year << ":" << new_major; 

} 

这里是整个错误消息:

In function 'bool is_duplicate(Student)': 
[Error] 'class Student' has no member named 'p' 
In member function 'void StudentList::Add_Student()': 
[Error] no matching function for call to 'StudentList::is_duplicate(int&, int&, std::string&, std::string&, std::string&, std::string&)' 
[Note] candidate is: 
In file included from StudentList.cpp 
[Note] bool StudentList::is_duplicate(Student) 
[Note] candidate expects 1 argument, 6 provided 
+0

你会告诉我们'学生'类,因为错误是关于它吗? – SingerOfTheFall

+0

是的,我编辑过。 – Marco

+1

从你显示的内容看,'Student'类没有名为'p'的成员。哪一行产生错误? – Andy

回答

1
private: 
     Student *head, *tail; 

    public: 
     Student p; 

你的 'P' 是你StudentList类类型学生的对象。 你在代码中说的是从Student而不是StudentList中获得对象'p'。

最重要的是,我不是完全确定,但我想你想“P”是你在你的CPP定义指针后

2

我想你应该改变你的is_duplicate

bool StudentList::is_duplicate(Student s1) { //this is a class member function, hence the StudentList:: 
    Student *h1 = head; //starting with the head of the list, just 1 variable is enough to iterate 
    while (h1 != NULL) { 
     //comparing current student with s1 
     if (equalStudent(*h1, s1)) { 
      return true; 
     } 
     h1 = h1->next; 
    } 
    return false; 
} 

还要注意你的函数定义。虽然你的Add_Student被定义为正确(void StudentList::Add_Student()),但其余功能缺少StudentList::部分,这使得它们只是全局函数,而不是成员函数。

+0

我实际上已经试过了,它说“头部没有在这个范围内声明”,我想我已经宣布了它。 – Marco

+0

@Marco,那是因为你的'is_duplicate'只是一个全局函数。为了提供作为类的一部分的函数的定义,它应该看起来像'return_type ClassName :: functionName(<...>){<...>}'。你也应该这样修复其他功能。 – SingerOfTheFall

0
bool is_duplicate(Student s1) { 
    Student *head; 
    Student *h1 = head; 
    while (h1 != NULL) { 
     if (equalStudent(h1->p, s1)) { 
      return true; 
     } 
     h1 = h1->next; 
    } 
    return false; 
} 

问题:通过在方法的范围内声明的副本Student *head;Student *h1 = head;是要初始化H1到未初始化的局部变量,而不是类成员。