我目前正在使用以下方法和单元测试的方法。我认为测试可以/应该被分解成更多的测试,但我不确定有多少测试要写出来,或者更重要的部分是什么,尤其是考虑到该方法使用sql查询等来建立Connection
。 。所有帮助表示赞赏。JAVA最佳实践单元测试与JUnit
Java方法:
public static ArrayList<HashMap<String, String>> executeSelect(
Connection conn, Statement stmt, Query query) {
ResultSet rs = null;
ArrayList<HashMap<String, String>> serviceRequests = new ArrayList<HashMap<String, String>>();
try {
long queryStart = System.nanoTime();
rs = stmt.executeQuery(query.getQuery());
long queryEnd = System.nanoTime();
long queryDuration = queryEnd-queryStart;
queryTime = String.valueOf(queryDuration);
while (rs.next()) {
HashMap<String, String> serviceRequestData = new HashMap<>();
if (QueryUtil.hasColumn(rs, "ID")) {
String id = rs.getString("ID");
serviceRequestData.put("ID", id);
}
else{
serviceRequestData.put("ID", " ");
}
if (QueryUtil.hasColumn(rs, "FN_Contact")) {
String firstName = rs.getString("FN_Contact");
serviceRequestData.put("FN_Contact", firstName);
}
else{
serviceRequestData.put("FN_Contact", " ");
}
if (QueryUtil.hasColumn(rs, "LN_Contact")) {
String lastName = rs.getString("LN_Contact");
serviceRequestData.put("LN_Contact", lastName);
}
else{
serviceRequestData.put("LN_Contact", " ");
}
if (QueryUtil.hasColumn(rs, "Notes")) {
String notes = rs.getString("Notes");
serviceRequestData.put("Notes", notes);
}
else{
serviceRequestData.put("Notes", " ");
}
if (QueryUtil.hasColumn(rs, "Email")) {
String email = rs.getString("Email");
serviceRequestData.put("Email", email);
}
else{
serviceRequestData.put("Email", " ");
}
serviceRequests.add(serviceRequestData);
}
} catch (SQLException e) {
e.printStackTrace();
sqlException = true;
}
return serviceRequests;
}
JUnit测试:
@Test
public void testFirstName() {
ArrayList<HashMap<String, String>> testMap = new ArrayList<HashMap<String,String>>();
Connection conn = null;
Statement stmt = null;
try {
Class.forName("com.mysql.jdbc.Driver");
String connectionUrl = "jdbc:mysql://localhost:3306/gc_image";
String connectionUser = "root";
String connectionPassword = "GCImage";
conn = DriverManager.getConnection(connectionUrl, connectionUser,
connectionPassword);
conn.
stmt = conn.createStatement();
Query testQuery = new Query();
testQuery
.setQuery("select * from service_request where FN_contact = 'Trevor'");
testMap = QueryController.executeSelect(conn, stmt, testQuery);
assertEquals("Janke", testMap.get(0).get("LN_Contact"));
assertEquals("Hello World", testMap.get(0).get("Notes"));
assertEquals("[email protected]", testMap.get(0).get("Email"));
assertEquals("ID", testMap.get(0).get("7"));
} catch (ClassNotFoundException e) {
e.printStackTrace();
} catch (SQLException e) {
e.printStackTrace();
} finally {
try {
stmt.close();
conn.close();
} catch (SQLException e) {
e.printStackTrace();
}
}
}
非常丰富和全面的答案。谢谢 – GregH
不客气。我想“TL; DR”总是努力将尽可能少的代码放入测试方法中。越少,意图就越清晰,并且更好地相信所要测试的是实际上正在测试的东西:) – Keith
你是什么意思做'失败(e.getMessage))'? 'fail()'不在JUnit库中?这个函数应该包含什么? – GregH