节点JS合并值基本实行

Question

我试图做类似下面的，但合并功能与行的问题

content = content.replace(content, "Hi" + values.first_name + "! Thanks for completing this code challenge :)");

文件名：app.js

var utilities = require("./utilities"); 

var mailValues = {}; 

mailValues.first_name = "Janet"; 

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)"; 

var mergedContent = utilities.merge(emailTemplate, mailValues); 

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)"; 

文件名：utilities.js

function merge(content, values) { 

    content = content.replace(content, "Hi" + values.first_name + "! Thanks for completing this code challenge :)"); 
    return content; 
} 


module.exports.merge = merge; 

Answer 1

你的合并函数不好，它做了一个奇怪的事情，如果你传递另一个模板，肯定会返回一个奇怪的字符串。你用“Hi ....”字符串替换了整个输入字符串，但是最后插入了first_name，你的函数太具体了，不能处理额外的参数或另一个模板/字符串。

function merge(content, values) { 
 
    // loop over all the keys in the values object 
 
    Object.keys(values).forEach(function(key) { 
 
    // look for the key surrounded by % in the string 
 
    // and replace it by the value from values 
 
    content = content.replace('%' + key + '%', values[key]); 
 
    }); 
 
    return content; 
 
} 
 

 
var mailValues = {}; 
 
mailValues.first_name = "Janet"; 
 
mailValues.last_name = "Doe"; 
 
var emailTemplate = "Hi %first_name% %last_name%! Thanks for completing this code challenge :)"; 
 
var mergedContent = merge(emailTemplate, mailValues); 
 

 
document.write(mergedContent);

试 “运行的代码片断” 按钮。

for ... in版本，信息，更好地使用以前的版本。

function merge(content, values) { 
 
    // loop over all the keys in the values object 
 
    for (var key in values) { 
 
    // look for the key surrounded by % in the string 
 
    // and replace it by the value from values 
 
    content = content.replace('%' + key + '%', values[key]); 
 
    } 
 
    return content; 
 
} 
 

 
var mailValues = {}; 
 
mailValues.first_name = "Janet"; 
 
mailValues.last_name = "Doe"; 
 
var emailTemplate = "Hi %first_name% %last_name%! Thanks for completing this code challenge :)"; 
 
var mergedContent = merge(emailTemplate, mailValues); 
 

 
document.write(mergedContent);