2017-03-28 21 views
1

我正在使用以下代码来获取报告。SQL Server:问题存在查询替换连接

DECLARE @CountryID smallint = 100 
DECLARE @UTCTDIM smallint = 330 
DECLARE @MarketProfileID smallint = 2 
DECLARE @StartDate datetime = '2017-01-01' 
DECLARE @EndDate datetime = '2017-01-03' 
DECLARE @CustomerTypeID smallint = 1 

SET NOCOUNT ON 
DECLARE @AirportList TABLE (ID bigint) 
INSERT INTO @AirportList (ID) 
SELECT 
    DISTINCT Airport.ID 
FROM 
    Airport 
    INNER JOIN CityList ON Airport.CityID = CityList.ID 
    INNER JOIN CountryList ON CityList.CountryID = CountryList.ID 
where 
    CountryList.NameEN in ('San Marino','Serbia','Slovakia','Slovenia','Spain','Sweden','Switzerland','Turkey','Ukraine','United Kingdom','Vatican CityList') 

DECLARE @TempSales TABLE 
( 
    [Type] varchar(50), 
    [From] char(3), 
    [To] char(3), 
    [Tickets] bigint, 
    [Average fare] decimal(18,3), 
    [Net sale] decimal(18,3) 
) 

INSERT INTO @TempSales 
SELECT 
    [AirTrips].[NameEN] AS [Type], 
    [Airport1].[IATACode] AS [From], 
    [Airport2].[IATACode] AS [To], 
    NULL, 
    AVG(ISNULL([AirTraveler].[FareBaseAmount], 0)) + AVG(ISNULL([AirTraveler].[Taxes], 0)) AS [Average fare], 
    SUM(ISNULL([AirTraveler].[AmountNetRemit], 0)) AS [Net sale] 
FROM 
    [BookingDetails] WITH (READPAST) 
    INNER JOIN [Bookings] WITH (READPAST) ON Booking.BookingFileID = BookingFile.ID 
    INNER JOIN [AirTrips] WITH (READPAST) ON Booking.AirTripTypeID = AirTrips.ID 
    INNER JOIN [AirTraveler] WITH (READPAST) ON AirTraveler.BookingID = Booking.ID 
    INNER JOIN [AirOrigin] WITH (READPAST) ON AirOrigin.BookingID = Booking.ID 
    INNER JOIN [Airport] AS [Airport1] WITH (READPAST) ON [Airport1].[ID] = [AirOrigin].[DepartureAirportID] 
    INNER JOIN [Airport] AS [Airport2] WITH (READPAST) ON [Airport2].[ID] = [AirOrigin].[ArrivalAirportID] 
WHERE 
    [Bookings].[BookingStatusID] IN (16, 20, 22, 23) 
    AND [Bookings].[IsActive] = 1 
    AND [AirOrigin].[AirTripDirectionTypeID] = 1 
    AND (ISNULL([AirTraveler].[BaseAmountNetRemit], 0) + ISNULL([AirTraveler].[TaxesNetRemit], 0)) <> 0 
    AND [Bookings].[RemitDate] BETWEEN @StartDate AND @EndDate 
    AND [BookingDetails].[MarketProfileID] = @MarketProfileID 
    AND [BookingDetails].[BookedForOrganizationID] IS NULL 
    AND (
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport1].ID) 
     OR 
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport2].ID) 
    ) 
GROUP BY 
    [AirTrips].[NameEN], 
    [Airport1].[IATACode], 
    [Airport2].[IATACode] 

INSERT INTO @TempSales 
SELECT 
    [AirTrips].[NameEN] AS [Type], 
    [Airport1].[IATACode] AS [From], 
    [Airport2].[IATACode] AS [To], 
    COUNT(*) [Tickets], 
    NULL, 
    NULL 
FROM 
    [BookingDetails] WITH (READPAST) 
    INNER JOIN [Bookings] WITH (READPAST) ON Booking.BookingFileID = BookingFile.ID 
    INNER JOIN [AirTrips] WITH (READPAST) ON Booking.AirTripTypeID = AirTrips.ID 
    INNER JOIN [AirTraveler] WITH (READPAST) ON AirTraveler.BookingID = Booking.ID 
    INNER JOIN [AirOrigin] WITH (READPAST) ON AirOrigin.BookingID = Booking.ID 
    INNER JOIN [Airport] AS [Airport1] WITH (READPAST) ON [Airport1].[ID] = [AirOrigin].[DepartureAirportID] 
    INNER JOIN [Airport] AS [Airport2] WITH (READPAST) ON [Airport2].[ID] = [AirOrigin].[ArrivalAirportID] 
WHERE 
    [Bookings].[BookingStatusID] IN (16, 22, 23) 
    AND [Bookings].[IsActive] = 1 
    AND [AirOrigin].[AirTripDirectionTypeID] = 1 
    AND (ISNULL([AirTraveler].[BaseAmountNetRemit], 0) + ISNULL([AirTraveler].[TaxesNetRemit], 0)) <> 0 
    AND [Bookings].[RemitDate] BETWEEN @StartDate AND @EndDate 
    AND [BookingDetails].[MarketProfileID] = @MarketProfileID 
    AND [BookingDetails].[BookedForOrganizationID] IS NULL 
    AND (
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport1].ID) 
     OR 
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport2].ID) 
    ) 
GROUP BY 
    [AirTrips].[NameEN], 
    [Airport1].[IATACode], 
    [Airport2].[IATACode] 

SELECT 
    [Type], 
    [From], 
    [To], 
    COALESCE(SUM([Tickets]), 0) AS [Tickets], 
    COALESCE(SUM([Average fare]), 0) AS [Average fare], 
    COALESCE(SUM([Net sale]), 0) AS [Net sale] 
FROM 
    @TempSales 
GROUP BY 
    [Type], 
    [From], 
    [To] 
ORDER BY 
    [Tickets] DESC, 
    [Type] ASC, 
    [From] ASC, 
    [To] ASC 

我在数据库中有百万条记录。 对于小记录(2,3)天,它工作正常。 但对于大型记录(10天),我正在获取资源锁定/超时错误。

我发现一个问题是与下面的代码:

AND (
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport1].ID) 
     OR 
     EXISTS (SELECT A.ID FROM @AirportList A WHERE A.ID = [Airport2].ID) 
    ) 

如果我删除此code.I我没有面临太大的问题。 请帮我找到写这个代码或租期,提高它

+1

我不认为它可以做解决你的问题,但我认为你可以重写你的病情为'EXISTS( \t \t \t SELECT A.ID \t \t \t从@AirportList一个 \t \t \t WHERE A.ID IN(Airport1.ID,Airport2.ID) \t \t \t)' \t \t \t ,然后再试一次。 你可以发布解释计划吗? – etsa

+1

您是否曾尝试将@AirportList表添加到@AirportList表中,其中A.ID将等于[Airport1] .ID或[Airport2] .ID? –

+0

@etsa:没有什么区别 –

回答

0

添加主键到临时表

DECLARE @AirportList TABLE (ID bigint primary key) 
0

试试这个的另一种方法:

DECLARE @CountryID smallint = 100 
    DECLARE @UTCTDIM smallint = 330 
    DECLARE @MarketProfileID smallint = 2 
    DECLARE @StartDate datetime = '2017-01-01' 
    DECLARE @EndDate datetime = '2017-01-03' 
    DECLARE @CustomerTypeID smallint = 1 

    SET NOCOUNT ON 
    DECLARE @AirportList TABLE (ID bigint) 
    INSERT INTO @AirportList (ID) 
    SELECT 
     DISTINCT Airport.ID 
    FROM 
     Airport 
    INNER JOIN CityList ON Airport.CityID = CityList.ID 
    INNER JOIN CountryList ON CityList.CountryID = CountryList.ID 
    where 
     CountryList.NameEN in ('San Marino','Serbia','Slovakia','Slovenia','Spain','Sweden','Switzerland','Turkey','Ukraine','United Kingdom','Vatican CityList') 

DECLARE @TempSales TABLE 
( 
    [Type] varchar(50), 
    [From] char(3), 
    [To] char(3), 
    [Tickets] bigint, 
    [Average fare] decimal(18,3), 
    [Net sale] decimal(18,3) 
) 

INSERT INTO @TempSales 
SELECT 
    [AirTrips].[NameEN] AS [Type], 
    [Airport1].[IATACode] AS [From], 
    [Airport2].[IATACode] AS [To], 
    NULL, 
    AVG(ISNULL([AirTraveler].[FareBaseAmount], 0)) + AVG(ISNULL([AirTraveler].[Taxes], 0)) AS [Average fare], 
    SUM(ISNULL([AirTraveler].[AmountNetRemit], 0)) AS [Net sale] 
FROM 
    [BookingDetails] WITH (READPAST) 
    INNER JOIN [Bookings] WITH (READPAST) ON Booking.BookingFileID = BookingFile.ID 
    INNER JOIN [AirTrips] WITH (READPAST) ON Booking.AirTripTypeID = AirTrips.ID 
    INNER JOIN [AirTraveler] WITH (READPAST) ON AirTraveler.BookingID = Booking.ID 
    INNER JOIN [AirOrigin] WITH (READPAST) ON AirOrigin.BookingID = Booking.ID 
    INNER JOIN [Airport] AS [Airport1] WITH (READPAST) ON [Airport1].[ID] = [AirOrigin].[DepartureAirportID] 
    INNER JOIN [Airport] AS [Airport2] WITH (READPAST) ON [Airport2].[ID] = [AirOrigin].[ArrivalAirportID] 
    INNER JOIN @AirportList AS A ON A.ID = [AirOrigin].[DepartureAirportID] OR A.ID = [AirOrigin].[ArrivalAirportID] 
WHERE 
    [Bookings].[BookingStatusID] IN (16, 20, 22, 23) 
    AND [Bookings].[IsActive] = 1 
    AND [AirOrigin].[AirTripDirectionTypeID] = 1 
    AND (ISNULL([AirTraveler].[BaseAmountNetRemit], 0) + ISNULL([AirTraveler].[TaxesNetRemit], 0)) <> 0 
    AND [Bookings].[RemitDate] BETWEEN @StartDate AND @EndDate 
    AND [BookingDetails].[MarketProfileID] = @MarketProfileID 
    AND [BookingDetails].[BookedForOrganizationID] IS NULL 
GROUP BY 
    [AirTrips].[NameEN], 
    [Airport1].[IATACode], 
    [Airport2].[IATACode] 

INSERT INTO @TempSales 
SELECT 
    [AirTrips].[NameEN] AS [Type], 
    [Airport1].[IATACode] AS [From], 
    [Airport2].[IATACode] AS [To], 
    COUNT(*) [Tickets], 
    NULL, 
    NULL 
FROM 
    [BookingDetails] WITH (READPAST) 
    INNER JOIN [Bookings] WITH (READPAST) ON Booking.BookingFileID = BookingFile.ID 
    INNER JOIN [AirTrips] WITH (READPAST) ON Booking.AirTripTypeID = AirTrips.ID 
    INNER JOIN [AirTraveler] WITH (READPAST) ON AirTraveler.BookingID = Booking.ID 
    INNER JOIN [AirOrigin] WITH (READPAST) ON AirOrigin.BookingID = Booking.ID 
    INNER JOIN [Airport] AS [Airport1] WITH (READPAST) ON [Airport1].[ID] = [AirOrigin].[DepartureAirportID] 
    INNER JOIN [Airport] AS [Airport2] WITH (READPAST) ON [Airport2].[ID] = [AirOrigin].[ArrivalAirportID] 
    INNER JOIN @AirportList AS A ON A.ID = [AirOrigin].[DepartureAirportID] OR A.ID = [AirOrigin].[ArrivalAirportID] 
WHERE 
    [Bookings].[BookingStatusID] IN (16, 22, 23) 
    AND [Bookings].[IsActive] = 1 
    AND [AirOrigin].[AirTripDirectionTypeID] = 1 
    AND (ISNULL([AirTraveler].[BaseAmountNetRemit], 0) + ISNULL([AirTraveler].[TaxesNetRemit], 0)) <> 0 
    AND [Bookings].[RemitDate] BETWEEN @StartDate AND @EndDate 
    AND [BookingDetails].[MarketProfileID] = @MarketProfileID 
    AND [BookingDetails].[BookedForOrganizationID] IS NULL 
GROUP BY 
    [AirTrips].[NameEN], 
    [Airport1].[IATACode], 
    [Airport2].[IATACode] 

SELECT 
    [Type], 
    [From], 
    [To], 
    COALESCE(SUM([Tickets]), 0) AS [Tickets], 
    COALESCE(SUM([Average fare]), 0) AS [Average fare], 
    COALESCE(SUM([Net sale]), 0) AS [Net sale] 
FROM 
    @TempSales 
GROUP BY 
    [Type], 
    [From], 
    [To] 
ORDER BY 
    [Tickets] DESC, 
    [Type] ASC, 
    [From] ASC, 
    [To] ASC 
+0

它进入了无限循环。 –

+0

请检查新的更新。 –