为什么我的程序在输入字符时会出现无限循环？

Question

#include<iostream> 
#include<cstdlib> 
#include<ctime> 
#include<string> 

using namespace std; 

int main() 
{ 
    char replay; 
    int userInput; 
    cout<< "Let's play Rock, Paper, Scissors"<<endl; 
    do 
{ 
    cout<<"Enter 1 for Rock, 2 for Paper, 3 for Scissors"<< endl; 
    cin>> userInput; 

    switch(userInput) 
    { 
     case 1: 
     cout <<"You chose rock" << endl; 
     break; 

     case 2: 
     cout <<"You chose paper" <<endl; 
     break; 

     case 3: 
     cout <<"You chose scissors" << endl; 
     break; 

     default: 
     cout << userInput << " is not a valid choice"<< endl; 
     break; 
    } 
    cout<<"Would you like to play again (Y for yes, N for no)?"<<endl; 
    cin >> replay; 
} while((replay=='Y') || (replay=='y')); 

    return 0; 

} 

当我在输入数字的回答中输入一个字符时，当我被问及是否要再次玩时，输入的字符不是Y，Y，N或n时，进入无限循环

Answer 1

userInput定义为int。当您尝试读取int时，流中的实际内容是char，它将失败（但char仍在缓冲区中）。您必须清除错误状态，而忽略坏的输入：

if (!(cin >> userInput)) 
{ 
    cin.clear(); // clears the error state 
    cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); // remove the bad input from the buffer 
} 
else 
{ 
    // the code if the input was valid 
} 

Answer 2

只是一个建议，但如下我会重新安排你的代码：

#include<iostream> 
#include<cstdlib> 
#include<ctime> 
#include<string> 

using namespace std; 

int main() 
{ 
    char replay; 
    char userInputChar; 
    int userInput; 
    cout<< "Let's play Rock, Paper, Scissors"<<endl; 
    for(;;) 
    { 
     cout << "Enter 1 for Rock, 2 for Paper, 3 for Scissors"<< endl; 
     cin >> userInputChar; 

     userInput = userInputChar - '0'; 

     switch(userInput) 
     { 
      case 1: 
      cout <<"You chose rock" << endl; 
      break; 

      case 2: 
      cout <<"You chose paper" <<endl; 
      break; 

      case 3: 
      cout <<"You chose scissors" << endl; 
      break; 

      default: 
      cout << userInput << " is not a valid choice"<< endl; 
      break; 
     } 
     cout<<"Would you like to play again (Y for yes, N for no)?"<<endl; 
     cin >> replay; 

     if((replay!='Y') || (replay!='y')) 
      break; 
    } 

    return 0; 

} 

注意我是如何带着char输入转换为照顾一个int。

如果你想用你的电流回路声明userInput作为char，然后让你的switch语句是这样的：switch(userInput - '0')