具有不同参数的工厂模式实现

Question

我正在尝试创建一个使用相同基类（或接口）但具体工厂需要不同参数集的类的工厂。如果觉得我做错了什么，因为这些不同的枚举需要额外的代码。这能做得更好吗？要创建

类：

public interface IShapeData {} 

public abstract class ShapeDataWithCorners : IShapeData 
{ 
    public double Width { get; set; } 
} 

class Square : ShapeDataWithCorners {} 

class Rectangle : ShapeDataWithCorners 
{ 
    public double Height { get; set; } 
} 

class Circle : IShapeData 
{ 
    public double Radius { get; set; } 
} 

class Oval : IShapeData 
{ 
    public double Radius1 { get; set; } 
    public double Radius2 { get; set; } 
} 

工厂：

public enum RoundShapeTypes 
{ 
    Circle, 
    Oval 
} 

public enum CornerShapeTypes 
{ 
    Square, 
    Rectangle 
} 

public class RoundShapeDataFactory : IShapeDataFactory 
{ 
    private readonly RoundShapeTypes m_shapeType; 

    public RoundShapeDataFactory (RoundShapeTypes shapeType) 
    { 
     m_shapeType = shapeType; 
    } 

    public IShapeData CreateShapeData() 
    { 
     switch (m_shapeType) 
     { 
      case RoundShapeTypes.Circle: 
       return new Circle(); 
      case RoundShapeTypes.Oval: 
       return new Oval(); 
     } 
    } 
} 

public class CornerShapeDataFactory : IShapeDataFactory 
{ 
    private readonly CornerShapeTypes m_shapeType; 

    public CornerShapeDataFactory (CornerShapeTypes shapeType) 
    { 
     m_shapeType = shapeType; 
    } 

    public IShapeData CreateShapeData() 
    { 
     switch (m_shapeType) 
     { 
      case CornerShapeTypes.Square: 
       return new Square(); 
      case CornerShapeTypes.Rectangle: 
       return new Rectangle(); 
     } 
    } 
} 

类调​​用工厂：

public class RoundShapeManager 
{ 
    public IShapeData CurrentShapeData{get; set; } 

    public void SetShapeType (RoundShapeTypes shapeType) 
    { 
     RoundShapeDataFactory factory = new RoundShapeDataFactory (shapeType); 
     CurrentShapeData = factory.CreateShapeData(); 
    } 
} 

public class CornerShapeManager 
{ 
    public IShapeData CurrentShapeData {get; set; } 

    public void SetShapeType (CornerShapeTypes shapeType) 
    { 
     CornerShapeDataFactory factory = new CornerShapeDataFactory (shapeType); 
     CurrentShapeData = factory.CreateShapeData(); 
    } 
} 

这些 “经理人” 实际上是WPF的ViewModels，将可以改变他们的代表在运行时显示数据。为了简洁，我删除了viewmodel特定的代码。

Answer 1

你可以把它降低到这样的：

public interface IShapeData { } 

public abstract class ShapeDataWithCorners : IShapeData 
{ 
    public double Width { get; set; } 
} 

public class Square : ShapeDataWithCorners { } 

public class Rectangle : ShapeDataWithCorners 
{ 
    public double Height { get; set; } 
} 

public class Circle : IShapeData 
{ 
    public double Radius { get; set; } 
} 

public class Oval : IShapeData 
{ 
    public double Radius1 { get; set; } 
    public double Radius2 { get; set; } 
} 

public enum ShapeType 
{ 
    Circle, 
    Oval, 
    Square, 
    Rectangle 
} 

public interface IShapeDataFactory 
{ 
    IShapeData CreateShapeData(ShapeType shapeType); 
} 

public class ShapeDataFactory : IShapeDataFactory 
{ 
    public IShapeData CreateShapeData(ShapeType shapeType) 
    { 
     switch (shapeType) 
     { 
      case ShapeType.Circle: 
       return new Square(); 
      case ShapeType.Oval: 
       return new Oval(); 
      case ShapeType.Rectangle: 
       return new Rectangle(); 
      case ShapeType.Square: 
       return new Square(); 
      default: 
       throw new ArgumentException("invalid shape type"); 
     } 
    } 
} 

这样一个工厂，一个枚举所有形状类型，你可以有一个经理，基本上做到这一点：

IShapeDataFactory s = new ShapeDataFactory(); 
IShapeData temp = s.CreateShapeData(ShapeType.Square);