运行存储过程/ UDF X号，当PROC插入行

Question

我有一个存储过程是这样的：

create proc spInsertDrugQuestions 
@drugId int 
as 
begin 
declare @drugName varchar(50)= (select distinct drugName 
     from Drugs 
     where DrugId = @drugId) 
--class question and answer 
declare @drugClassQuestion varchar(250) = 
     'What is the drug class of your ' + @drugName   

declare @drugClassAnswer varchar(50) = (select distinct drugClass 
      from drugs 
      where drugId = @drugId) 
--dosage question and answer 
declare @drugDosageQuestion varchar(250) = 
     'What is the dosage of your ' + @drugName 

declare @drugDosageAnswer varchar(50) = (select distinct drugDosage 
      from drugs 
      where drugId = @drugId) 

--QuizQuestionTypeId is a foreign key to another table not shown 
--but indicates the general type of question (dosage, class, etc.) 
insert into DrugQuestions(DrugId,DrugQuestion,CorrectAnswer,QuizQuestionTypeId) 
values (@drugId,@drugClassQuestion,@drugClassAnswer,3) 
    ,(@drugId,@drugDosageQuestion,@drugDosageAnswer,1) 
end 

此存储过程是谁在新的信息进入Drugs最终用户表和DrugQuestions表中的相应问题将被添加。但是，目前我需要能够为Drugs表中当前存在的每个DrugId运行此存储过程。我认为最好的方法是使用UDF和CROSS APPLY加入一个数字表格，每个表格上都会有DrugId。不过，我不是太熟悉的UDF和下面的尝试

create function fnInsertDrugQuestions(@drugId int) 
returns int --think can't be right, but it didn't give me any read squigglies 
as begin 
declare @drugName varchar(50)= (select distinct drugName 
     from Drugs 
     where DrugId = @drugId) 
--class question and answer 
declare @drugClassQuestion varchar(250) = 
     'What is the drug class of your ' + @drugName   

declare @drugClassAnswer varchar(50) = (select distinct drugClass 
      from drugs 
      where drugId = @drugId) 
--dosage question and answer 
declare @drugDosageQuestion varchar(250) = 
     'What is the dosage of your ' + @drugName 

declare @drugDosageAnswer varchar(50) = (select distinct drugDosage 
      from drugs 
      where drugId = @drugId) 
insert into DrugQuestions(DrugId,DrugQuestion,CorrectAnswer,QuizQuestionTypeId) 
values (@drugId,@drugClassQuestion,@drugClassAnswer,3) 
    ,(@drugId,@drugDosageQuestion,@drugDosageAnswer,1) 

end 

给我的错误：

Msg 443, Level 16, State 15, Procedure fnInsertDrugQuestions, Line 21 
Invalid use of a side-effecting operator 'INSERT' within a function. 
Msg 455, Level 16, State 2, Procedure fnInsertDrugQuestions, Line 21 
The last statement included within a function must be a return statement. 

我需要知道的几件事情：

1.) Is it possible to insert data like this using a UDF? 
2.) Is it possible to used `CROSS APPLY` with a stored procedure? 
3.) Do I really want to loop through all the `DrugId`s to do this? 

Answer 1

1. 否 - 如果要插入数据，请使用存储过程，如果需要，您还可以从存储过程返回数据。
2. 是的 - 您可以在存储过程中使用CROSS APPLY。
3. 没有 - 你可以只使用下面的方法插入所有目前的药物， 尤其是如果它正在做的一关：

---

INSERT DrugQuestions (DrugId, DrugQuestion, CorrectAnswer, QuizQuestionTypeId) 
SELECT DrugID, 
     DrugQuestion = t.Question + drugs.DrugName, 
     CorrectAnswer = t.Answer, 
     t.QuizQuestionTypeId 
FROM drugs 
     CROSS APPLY 
     ( VALUES 
       ('What is the drug class of your ', drugs.DrugClass, 3), 
       ('What is the dosages of your ', drugs.drugDosage, 1) 
     ) t (Question, Answer, QuizQuestionTypeId); 

如果你是批量插入药，即多种药物而不是为每一种新药重复相同的功能，您可以使用输出条款收集新的drugID，然后结合上面的内容添加新的问题：

DECLARE @NewDrugIDs TABLE (ID INT NOT NULL); 
INSERT Drugs (DrugName, DrugDosage, DrugClass, ...) 
OUTPUT inserted.drugID INTO @NewDrugIDs 
SELECT/VALUES ... 

INSERT DrugQuestions (DrugId, DrugQuestion, CorrectAnswer, QuizQuestionTypeId) 
SELECT DrugID, 
     DrugQuestion = t.Question + drugs.DrugName, 
     CorrectAnswer = t.Answer, 
     t.QuizQuestionTypeId 
FROM drugs 
     CROSS APPLY 
     ( VALUES 
       ('What is the drug class of your ', drugs.DrugClass, 3), 
       ('What is the dosages of your ', drugs.drugDosage, 1) 
     ) t (Question, Answer, QuizQuestionTypeId) 
WHERE drugs.DrugID IN (SELECT ID FROM @NewDrugIDs);