2017-04-03 32 views
0

我正在为ATmega16编写这个程序集,我只是想让按钮按下时闪烁10次LED。不幸的是,当达到RET指令时,它将我带到第一个代码(start),而不是在调用LONG_DELAY时返回它的左边。RET指令没有返回到它所谓的子程序 - AVR程序集

有人可以帮我吗?谢谢。

start: 
    /* set the PINB0 data direction to 0 for input */ 
    /* This one simulates the key */ 
    ldi R16, (0 << PB0) ; Load 0b00000001 in R16 
    out DDRB,R16 ; Configure the PINB0 as input 

    /* set the PORTB7 data direction to 1 for output */ 
    /* this one causes the LED to be ON/OFF */ 
    ldi R17, (1 << PB7) ; Load 0b10000000 in R17 
    out DDRB,R17 ; Configure the PORTB7 as output 

OFF_MODE: 
    /* Put the PORTB7 to 0 */ 
    ldi R18,(0 << PB7) 
    out PORTB,R18 
    /* Check the content of PINB0 */ 
    /* Wait for the PINB to get pressed by the user */ 
    sbis PINB,0 
    brne OFF_MODE ; Branch to the OFF_MODE if the key isn't pressed yet 

BLINK_MODE: 
    /* Define a counter */ 
    ldi R20,0 
    /* Turn on the LED */ 
    /* Put the PORTB7 to 1 */ 
    ldi R18,(1 << PB7) 
    out PORTB,R18 

    /* Create a delay */ 
    call LONG_DELAY 

    /* Turn off the LED */ 
    ldi R18,(0 << PB7) 
    out PORTB,R18 

    /* Increment the counter */ 
    inc R20 

    /* Check the content of the counter */ 
    cpi R20,0x0A 
    brne BLINK_MODE 
    /* Clear the input to avoid duplicate press virtualization */ 
    cbi PINB,0 
    jmp OFF_MODE 
rjmp start 

    /* Delay function */ 
LONG_DELAY: 
    ldi r25,10 
LOOP: 
    nop 
    dec R25 
    cpi R25,0 
    brne LOOP 
    ret 
+0

不能当场什么错乍一看,你怎么知道它可以追溯到'start'? – Jester

+0

@Jester我正在用AtmelStudio 7调试它。 – aligholamee

+1

你应该初始化堆栈指针。 – Jester

回答

0

有一些错误的,所以在这里你是:

; Replace with your application code 
start: 
    //stack setup 
    ldi r16, 0 
    out SPH, r16 
    ldi r16, 0xf0 
    out SPL, r16 
    /* set the PINB0 data direction to 0 for input */ 
    /* This one simulates the key */ 
    ldi R16, (0 << PB0) ; Load 0b00000001 in R16 
    out DDRB,R16 ; Configure the PINB0 as input 

    /* set the PORTB7 data direction to 1 for output */ 
    /* this one causes the LED to be ON/OFF */ 
    ldi R17, (1 << PB7) ; Load 0b10000000 in R17 
    out DDRB,R17 ; Configure the PORTB7 as output 

OFF_MODE: 
    /* Put the PORTB7 to 0 */ 
    ldi R18,(0 << PB7) 
    out PORTB,R18 
    /* Check the content of PINB0 */ 
    /* Wait for the PINB to get pressed by the user */ 
    sbis PINB,0 
    brne OFF_MODE ; Branch to the OFF_MODE if the key isn't pressed yet 
//Here was mistake 
    ldi R20, 10 

BLINK_MODE: 
    /* Turn on the LED */ 
    /* Put the PORTB7 to 1 */ 
    ldi R18,(1 << PB7) 
    out PORTB,R18 

    /* Create a delay */ 
    call LONG_DELAY 

    /* Turn off the LED */ 
    ldi R18,(0 << PB7) 
    out PORTB,R18 

    /* Increment the counter */ 
    dec R20 
    brne BLINK_MODE 
    /* Clear the input to avoid duplicate press virtualization */ 
    cbi PINB,0 
    jmp OFF_MODE 
rjmp start 

    /* Delay function */ 
LONG_DELAY: 
    ldi r25,10 
LOOP: 
    dec R25 
//here was redundant instruction 
    brne LOOP 
    ret 
+0

为什么cpi是多余的?不应该与比较一起工作吗? – aligholamee

+0

'dec'自己改变z标志,不需要'cpi'。供参考使用:http://www.atmel.com/webdoc/avrassembler/avrassembler.wb_DEC.html – nopasara

+0

工作,谢谢。 – aligholamee