2014-02-06 71 views
1

大家好我有一个问题,选择随机数来刷一副扑克牌。随机随机洗牌,我们试图在每个循环中选择一张随机卡,但似乎如果我们用完了一种,我们不能随机选择一种。它进入无限循环。有什么建议么?在c中挑选随机数字#

(翻译:玛卡=铲,sinek =俱乐部,KUPA =心脏,卡罗=钻石,淡水河谷=插孔,KIZ =女王,papaz =国王)

public class KartKarma : MonoBehaviour { 
    public GameObject[] Deste; 
    public static GameObject KupaAs, Kupa2, Kupa3, Kupa4, Kupa5, Kupa6, Kupa7, Kupa8, Kupa9, Kupa10, KupaVale, KupaKiz, KupaPapaz; 
    public static GameObject KaroAs, Karo2, Karo3, Karo4, Karo5, Karo6, Karo7, Karo8, Karo9, Karo10, Karo11, Karo12, Karo13; 
    public static GameObject SinekAs, Sinek2, Sinek3, Sinek4, Sinek5, Sinek6, Sinek7, Sinek8, Sinek9, Sinek10, Sinek11, Sinek12, Sinek13; 
    public static GameObject MacaAs, Maca2, Maca3, Maca4, Maca5, Maca6, Maca7, Maca8, Maca9, Maca10, Maca11, Maca12, Maca13; 
    public GameObject[] Kupa = {KupaAs, Kupa2, Kupa3, Kupa4, Kupa5, Kupa6, Kupa7, Kupa8, Kupa9, Kupa10, KupaVale, KupaKiz, KupaPapaz}; 
    public GameObject[] Karo = {KaroAs, Karo2, Karo3, Karo4, Karo5, Karo6, Karo7, Karo8, Karo9, Karo10, Karo11, Karo12, Karo13}; 
    public GameObject[] Sinek = {SinekAs, Sinek2, Sinek3, Sinek4, Sinek5, Sinek6, Sinek7, Sinek8, Sinek9, Sinek10, Sinek11, Sinek12, Sinek13}; 
    public GameObject[] Maca = {MacaAs, Maca2, Maca3, Maca4, Maca5, Maca6, Maca7, Maca8, Maca9, Maca10, Maca11, Maca12, Maca13}; 
    List<GameObject> deste = new List<GameObject>(); 

// Use this for initialization 
void Start() { 
    int i = 0; 
    while(i < 26){ 
     int a = Random.Range(1,5); 
     if (a == 1) { 
      int b = Random.Range(0,13); 
      if(Maca != null){ 
       while(Maca[b] == null){ 
        b = Random.Range(0,13); 
       } 
       deste.Add(Maca[b]); 
       Maca[b] = null; 
      } 
      else { 
       while(a == 1) 
        a = Random.Range(2,5); 
      } 
     } 

     if (a == 2) { 
      int b = Random.Range(0,13); 
      if(Sinek != null){ 
       while(Sinek[b] == null) 
        b = Random.Range(0,13); 
       deste.Add (Sinek[b]); 
       Sinek[b] = null; 
      } 
      else { 
       while(a == 2) 
        a = Random.Range(1,5); 
      } 
     } 

     if (a == 3) { 
      int b = Random.Range(0,13); 
      if(Karo != null){ 
       while(Karo[b] == null) 
        b = Random.Range(0,13); 
       deste.Add (Karo[b]); 
       Karo[b] = null; 
      } 
      else { 
       while(a == 3) 
        a = Random.Range(1,5); 
      } 
     } 

     if (a == 4) { 
      int b = Random.Range(0,13); 
      if(Kupa != null){ 
       while(Kupa[b] == null){ 
        b = Random.Range(0,13); 
       } 
       deste.Add(Kupa[b]); 
       Kupa[b] = null; 
      } 
      else { 
            while(a == 4) 
        a = Random.Range(1,5); 
      } 
     } 
     i++; 
    } 
} 

void Update() { 

} 

}

+2

什么是Random.Range?通常,不要在方法中创建新的随机实例,而是重新使用实例变量或将其作为参数传递。否则,你会得到相同的值,因为随机会被循环中重复调用的当前时间播种。 –

+0

代表'Random.Range'使用'Random.Next'然后尝试。 –

+0

此外,您的代码只处理1到4的'a',而Range方法则发送参数1和5,无论它们是什么意思。你从哪里得到那5个? – Tarec

回答

3

使用合适的洗牌算法,如Knuth's (aka Fisher-Yates)

/// <summary>Used to shuffle collections.</summary> 

public class Shuffler 
{ 
    /// <summary>Shuffles the specified array.</summary> 
    /// <typeparam name="T">The type of the array elements.</typeparam> 
    /// <param name="array">The array to shuffle.</param> 

    public void Shuffle<T>(IList<T> array) 
    { 
     for (int n = array.Count; n > 1;) 
     { 
      int k = _rng.Next(n); 
      --n; 
      T temp = array[n]; 
      array[n] = array[k]; 
      array[k] = temp; 
     } 
    } 

    private readonly Random _rng = new Random(); 
} 

然后:

var shuffler = new Shuffler(); 
... 
shuffler.Shuffle(deste); 

由于@Paul发布的链接确实表明 - 请注意,Random不是一个特别好的随机数生成器。如果你愿意,你可以用一个更好的替代,但底层洗牌算法保持不变。

+0

此代码不返回混洗的数组? – Max

+1

@MaxMommersteeg这是一个就地洗牌。 –

+0

所以名为'deste'的套牌在呼叫者级别是shuffeld吗? – Max

0

我认为有

while(a == 1) 
while(a == 2) 
while(a == 3) 
while(a == 4) 

线导致此问题。请重新检查你的逻辑。

2
while(a == 1) 
    a = Random.Range(2,5); 

这是你的无限循环原因。此外,该部分:

while(Sinek[b] == null) 
    b = Random.Range(0,13); 

也是讨厌的,因为它不能保证条件将永远满足。