我有一个C#winform应用程序,我试图将我的插入语句转换为参数化的SQL存储过程。当我ExecuteNonQuery,我回到-1,我似乎无法找出原因。参数化SQL插入失败
SQL过程:
CREATE PROCEDURE CreateReceiver
-- Add the parameters for the stored procedure here
@DBNAME sysname,
@SiteID varchar(25),
@Receiver varchar(25),
@StatusID int,
@ExpDelDate Date,
@CreateDate DateTime,
@CreateUserID varchar(25),
@CreateUserName varchar(25),
@ModDate DateTime,
@ModUserName varchar(25),
@ModUserID varchar(25),
@UserField5 varchar(25)
AS
BEGIN
DECLARE @sql NVARCHAR(MAX);
SET @sql = '
INSERT INTO @DBNAME (SiteId, ReceiverNumber, StatusId, ExpectedDeliveryDate, CreatedDate, CreatedUserID,
CreatedUserName, ModifiedDate, ModifiedUserID, ModifiedUserName, UserField5) VALUES (@SiteID,@Receiver,@StatusID,
@ExpDelDate,@CreateDate,@CreateUserID,@CreateUserName,@ModDate,@ModUserID,@ModUserName,@UserField5)
';
SET @sql = REPLACE(@sql, '@DBNAME', @DBNAME);
exec sp_executesql @sql,
N'@SiteID varchar(25), @Receiver varchar(25), @StatusID int, @ExpDelDate Date, @CreateDate DateTime, @CreateUserID varchar(25),
@CreateUserName varchar(25), @ModDate DateTime, @ModUserID varchar(25), @ModUserName varchar(25), @UserField5 varchar(25)',
@[email protected], @[email protected], @[email protected], @[email protected], @[email protected],
@[email protected], @[email protected], @[email protected], @[email protected],
@[email protected], @[email protected];
END
GO
这里是调用过程的C#代码:
internal static bool BuildReturnReceiver(string pReturnTrackingNumber, string pCustomer, string pSiteId, SqlArgs pSqlArgs)
{
var pwd = GetPwd();
var sqlCred = new SqlCredential(Sqluser, pwd);
var tCatalog = GetDB(pSqlArgs.sqlDB);
var sqlConnection = new SqlConnection
{
ConnectionString = $"Data Source={SqlServer};Initial Catalog=TSC-Telaid;",
Credential = sqlCred
};
var dbName = $"[{tCatalog}].dbo.[{pSqlArgs.sqlTable}]";
var tExpDelDate = CalculateDays();
var name = GetUser();
var sqlCommand = new SqlCommand
{
Connection = sqlConnection,
CommandType = CommandType.StoredProcedure,
CommandText = "CreateReceiver",
Parameters = { new SqlParameter("@DBNAME", dbName), new SqlParameter("@SiteID", pSiteId),
new SqlParameter("@Receiver", pSqlArgs.sqlFilterValue), new SqlParameter("@StatusID", 56), new SqlParameter("@ExpDelDate", tExpDelDate),
new SqlParameter("@CreateDate", DateTime.Now), new SqlParameter("@CreateUserID", WindowsIdentity.GetCurrent().Name),
new SqlParameter("@CreateUserName", name), new SqlParameter("@ModDate", DateTime.Now), new SqlParameter("@ModUserID", WindowsIdentity.GetCurrent().Name),
new SqlParameter("@ModUserName", name), new SqlParameter("@UserField5", pSqlArgs.sqlUpdateValue)},
};
try
{
sqlConnection.Open();
return sqlCommand.ExecuteNonQuery().Equals(1);
}
catch (SqlException ex)
{
MessageBox.Show(@"Error: " + ex.Message, @"Exception", MessageBoxButtons.OK,
MessageBoxIcon.Exclamation);
return false;
}
finally
{
sqlConnection.Close();
}
}
- 编辑 -
更正SQL程序:
Alter PROCEDURE CreateReceiver
-- Add the parameters for the stored procedure here
@DBNAME sysname,
@SiteID varchar(MAX),
@Receiver varchar(MAX),
@StatusID int,
@ExpDelDate Date,
@CreateDate DateTime,
@CreateUserID varchar(MAX),
@CreateUserName varchar(MAX),
@ModDate DateTime,
@ModUserName varchar(MAX),
@ModUserID varchar(MAX),
@UserField5 varchar(MAX)
AS
BEGIN
DECLARE @sql NVARCHAR(MAX);
SET @sql = N'
INSERT INTO ' + @DBNAME + '(SiteId, ReceiverNumber, StatusId, ExpectedDeliveryDate, CreatedDate, CreatedUserID,
CreatedUserName, ModifiedDate, ModifiedUserID, ModifiedUserName, UserField5) VALUES (@SiteID,@Receiver,@StatusID,
@ExpDelDate,@CreateDate,@CreateUserID,@CreateUserName,@ModDate,@ModUserID,@ModUserName,@UserField5)
';
--SET @sql = REPLACE(@sql, '@DBNAME', @DBNAME);
exec sp_executesql @sql,
N'@SiteID varchar(MAX), @Receiver varchar(MAX), @StatusID int, @ExpDelDate Date, @CreateDate DateTime, @CreateUserID varchar(MAX),
@CreateUserName varchar(MAX), @ModDate DateTime, @ModUserID varchar(MAX), @ModUserName varchar(MAX), @UserField5 varchar(MAX)',
@[email protected], @[email protected], @[email protected], @[email protected], @[email protected],
@[email protected], @[email protected], @[email protected], @[email protected],
@[email protected], @[email protected];
END
GO
所以...你有错误信息吗? – SqlZim
如果我做'var t = sqlCommand.ExecuteNonQuery',我得到-1 –