2013-03-08 170 views
8

我最近开始在应用程序中使用hibernate和c3p0作为ORM。但是,当我关闭会话工厂时,连接池不会自动关闭!这是唯一的地方在我的应用程序,我做任何事情与会议。休眠:关闭会话工厂不关闭c3p0连接池

StatelessSession session = null; 
    Transaction transaction = null; 


    try { 
     session = sessionFactory.openStatelessSession(); 
     transaction = session.beginTransaction(); 

     List<Thingy> list = session.getNamedQuery("getAvailableThingy").list(); 

     transaction.commit(); 
     return list; 

    } catch (Exception error) { 
     if (transaction != null) { 
      transaction.rollback(); 
     } 
     throw error; 
    } finally { 
     if (session != null) { 
      session.close(); 
     } 
    } 

这是我hibernate.cfg.xml配置文件

<?xml version='1.0' encoding='utf-8'?> 
<!DOCTYPE hibernate-configuration PUBLIC 
"-//Hibernate/Hibernate Configuration DTD//EN" 
"http://www.hibernate.org/dtd/hibernate-configuration-3.0.dtd"> 


<hibernate-configuration> 
    <session-factory> 
     <property name="hibernate.connection.driver_class">org.postgresql.Driver</property> 
     <property name="hibernate.dialect">org.hibernate.dialect.PostgreSQLDialect</property> 
     <property name="javax.persistence.validation.mode">none</property> 
     <property name="hibernate.connection.release_mode">after_transaction</property> 

     <property name="hibernate.c3p0.minPoolSize">1</property> 
     <property name="hibernate.c3p0.maxPoolSize">2</property> 
     <property name="hibernate.c3p0.acquireIncrement">1</property> 
     <property name="hibernate.c3p0.initialPoolSize">1</property> 
     <property name="hibernate.c3p0.timeout">30</property> 
     <property name="hibernate.c3p0.maxIdleTimeExcessConnections">5</property> 
     <property name="hibernate.c3p0.idleConnectionTestPeriod">300</property> 
    </session-factory> 
</hibernate-configuration> 

注意,对于非常短的空闲连接它,它的唯一的方式的原因,我发现还没有让我的集成测试通过。他们打开和关闭会话工厂很多,因此我总是用完连接。当我们处于项目的开始阶段时,我认为从长远来看这不是一个非常可持续的策略。

一个“有趣”的事情要注意的是,尽管我将初始连接池设置为1,但c3p0仍尝试在开始时打开两个连接。我的猜测是某种隐藏的会话不会关闭(但是在哪里?打败我)。

那么,如何才能让烦人的连接池关闭?

附加信息: 我如何创建和销毁我的会话工厂

import static com.google.common.base.Preconditions.*; 

import javax.inject.Inject; 
import javax.inject.Provider; 
import javax.inject.Singleton; 
import org.hibernate.SessionFactory; 
import org.hibernate.cfg.Configuration; 
import org.hibernate.service.ServiceRegistry; 
import org.hibernate.service.ServiceRegistryBuilder; 
import org.slf4j.Logger; 
import org.slf4j.LoggerFactory; 

import com.google.inject.Provides; 


@Singleton 
public class PostgisConnection implements Provider<SessionFactory>, AutoCloseable { 
    private final Logger logger = LoggerFactory.getLogger(getClass()); 
    private final ConnectionInfo connectionInfo; 
    private SessionFactory sessionFactory = null; 

    @Inject 
    public PostgisConnection(ConnectionInfo connectionInfo) { 
     this.connectionInfo = connectionInfo; 
    } 

    public AutoCloseable open() { 
     checkState(sessionFactory == null, "Connections to postgis are already open"); 

     logger.info("Creating sessionFactory for connection to postgis: {}", connectionInfo.getJdbcUrl()); 
     sessionFactory = newPostgisSessionFactory(connectionInfo); 

     return this; 
    } 

    @Override 
    public void close() throws Exception { 
     try { 
      if (sessionFactory != null) { 
       logger.info("Closing sessionFactory for postgis: {}", connectionInfo.getJdbcUrl()); 
       sessionFactory.close(); 
       checkState(sessionFactory.isClosed(), "Session factory should be closed at this point"); 
      } 
     } catch (Exception error) { 
      logger.error("Error closing SessionFactory", error); 
     } 
    } 

    @Provides 
    public SessionFactory get() { 
     return sessionFactory; 
    } 

    public static SessionFactory newPostgisSessionFactory(ConnectionInfo connectionInfo) { 
     Configuration configuration = configurationWith(connectionInfo); 
     return configuration.buildSessionFactory(registryFrom(configuration)); 
    } 

    private static Configuration configurationWith(ConnectionInfo connectionInfo) { 
     Configuration configuration = new Configuration(); 
     setConnectionInfo(connectionInfo, configuration); 
     configuration.addURL(PostgisConnection.class.getResource("mapping.hbm.xml")); 
     configuration.configure(PostgisConnection.class.getResource("hibernate.cfg.xml")); 

     return configuration; 
    } 

    private static void setConnectionInfo(ConnectionInfo connectionInfo, Configuration configuration) { 
     configuration.setProperty("hibernate.connection.url", connectionInfo.getJdbcUrl()); 
     configuration.setProperty("hibernate.connection.username", connectionInfo.getUsername()); 
     configuration.setProperty("hibernate.connection.password", connectionInfo.getPassword()); 
    } 

    private static ServiceRegistry registryFrom(Configuration configuration) { 
     return new ServiceRegistryBuilder() 
       .applySettings(configuration.getProperties()) 
       .buildServiceRegistry(); 
    } 

} 
  • Hibernate的版本:4.1.10.Final
  • C3P0版本:0.9.1.2
+0

为什么要关闭连接池?如果关闭,您将无法从中选择新的连接。 – dotvav 2013-03-08 16:46:25

+0

SessionFactory在我的一些集成测试之间关闭并重新启动,以避免可能影响它们的延迟状态。我也关闭了我的WebServer,关闭了一些Unix Socket连接,放下测试数据库......一切都是真的。当我开始第二次测试时,它应该是纯净的。当然,在制作过程中,我不会花时间关闭和重新开始那些事情,那样会毫无用处。每个hibernate的文档都有 – 2013-03-08 16:55:47

+0

,SessionFactor.close()应该关闭池:“销毁这个SessionFactory并释放所有资源(缓存,连接池等)。” [http://docs.jboss.org/hibernate/orm/4.1/javadocs/org/hibernate/SessionFactory.html]你可以在你的日志中看到你期望的close()方法吗?一些想法:1)c3p0-0.9.1.2在牙齿上有点长,尝试升级到相当成熟的c3p0-0.9.2; 2)请注意,c3p0 close()不一定是瞬时的:c3p0管理一堆被中断的线程,并在关闭时清理东西,必须返回未完成的cxns – 2013-03-09 08:20:34

回答

13

我同样的问题,并成功地使用了解决办法in this bug report

private void closeSessionFactory(SessionFactory factory) { 
    if(factory instanceof SessionFactoryImpl) { 
     SessionFactoryImpl sf = (SessionFactoryImpl)factory; 
     ConnectionProvider conn = sf.getConnectionProvider(); 
     if(conn instanceof C3P0ConnectionProvider) { 
     ((C3P0ConnectionProvider)conn).close(); 
     } 
    } 
    factory.close(); 
} 

你必须引用hibernate-c3p0-4.x.x jar。

+0

谢谢,我们结束了一个稍微复杂的工作,这将是有益的。 – 2013-07-17 16:34:33

0

我有同样的问题,并成功地运用了ehnanced(2014年1月)的变通提供in this bug report

private static boolean closeSessionFactoryIfC3P0ConnectionProvider(SessionFactory factory) { 

    boolean done = false; 
    if(factory instanceof SessionFactoryImpl) { 
     SessionFactoryImpl sf = (SessionFactoryImpl)factory; 
     ConnectionProvider conn = sf.getConnectionProvider(); 
     if(conn instanceof C3P0ConnectionProvider) { 
      ((C3P0ConnectionProvider)conn).close(); 
      try { 
       Thread.sleep(2000); //Let give it time...it is enough...probably 
      } catch (InterruptedException e) { 
       e.printStackTrace(); 
      } 
      done = true; 
     } 
     factory.close(); 
    } 
    return done; 

} 

您必须引用休眠-c3p0-4.x.x罐子。