2016-08-06 82 views
1

我正在编码randon报价机器,并且在点击“新报价”按钮时出现问题。为了简洁起见,quotes,colorsanimations变量的数据已被简化并缩小。所以问题是这样的。随着我不断点击按钮和一组较小的数据,我注意到响应时间变长了,颜色,引号和/或动画不会改变。这是显而易见的,动画并不总是运行。有了这一小套数据,我明白新输出可能与之前的输出完全一样,但动画仍然可以运行,有时却不会。如果没有loadQuotes()函数并且没有window.onload = loadQuotes();,并且我按下键盘上的F5重新加载页面,则此代码正确运行。当我将代码放在loadQuotes()函数中并在页面底部使用window.onload = loadQuotes();来获得初始输出时,问题就开始了。我尝试将loadQuotes()函数之外的所有变量和randomNum()函数(因为我假设它们是全局函数),而当我在初始页面加载后执行该操作时,单击该按钮根本不会执行任何操作。所以我关心的是如何通过按F5来按照上面所述加载页面,但是通过单击按钮。按钮没有正确更新输出

function loadQuotes() { 
 
    function randomNum(min, max) { 
 
    return Math.floor(Math.random() * (max - min + 1)) + min; 
 
    } 
 

 
    var quotes = [ 
 
    ["This is quote number one.", "Person 1"], 
 
    ["This is quote number two.", "Person 2"], 
 
    ["This is quote number three.", "Person 3"], 
 
    ["This is quote number four.", "Person 4"], 
 
    ["This is quote number five.", "Person 5"] 
 
    ] 
 

 
    var colors = [ 
 
    ["#096986", "#F69679"], 
 
    ["#000866", "#FFF799"], 
 
    ["#7D3563", "#82CA9C"] 
 
    ] 
 

 
    var animations = ["animated bounce", "animated flash", "animated pulse"] 
 

 
    var getQuotes = randomNum(0, quotes.length - 1); 
 
    var getColors = randomNum(0, colors.length - 1); 
 

 
    var newColor0 = colors[getColors][0]; 
 
    var newColor1 = colors[getColors][1]; 
 
    var newAnimation1 = animations[randomNum(0, animations.length - 1)] 
 
    var newAnimation2 = animations[randomNum(0, animations.length - 1)] 
 

 
    document.getElementById("quote").innerHTML = "<h1>" + quotes[getQuotes][0] + "</h1>"; 
 
    document.getElementById("author").innerHTML = "<h3>" + "--- " + quotes[getQuotes][1] + "</h3>"; 
 

 
    $(document).ready(function() { 
 
    $(".side-panel").css("background-color", newColor0); 
 
    $(".middle").css("background-color", newColor1); 
 
    $("#quote").addClass(newAnimation1); 
 
    $("#author").addClass(newAnimation2); 
 
    $(".btn").on("click", function() { 
 
     loadQuotes(); 
 
    }); 
 
    }); 
 
} 
 

 
window.onload = loadQuotes();
h1 { 
 
    text-align: center; 
 
    font-size: 3.5em; 
 
} 
 
h3 { 
 
    font-size: 1.5em; 
 
} 
 
/* div { border: 1px solid black; } */ 
 

 
.full-height { 
 
    height: 100vh; 
 
} 
 
.side-panel { 
 
    background-color: newColor0; 
 
} 
 
.middle { 
 
    background-color: newColor1; 
 
} 
 
.quote-box { 
 
    position: absolute; 
 
    top: 50%; 
 
    left: 50%; 
 
    transform: translate(-50%, -50%); 
 
    width: 80%; 
 
    height: 65%; 
 
    border-radius: 7.5%; 
 
    background-color: #FFFFFF; 
 
} 
 
.quote-text { 
 
    position: absolute; 
 
    top: 50%; 
 
    left: 50%; 
 
    transform: translate(-50%, -50%); 
 
    width: 90%; 
 
    height: 50%; 
 
}
<!DOCTYPE html> 
 

 
<html lang="en-us"> 
 

 
<head> 
 
    <title>Random Quote Machine</title> 
 
    <meta name="viewport" content="width=device-width, initial-scale=1"> 
 
    <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css" /> 
 
    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/3.5.2/animate.min.css" /> 
 
    <link rel="stylesheet" href="style.css" /> 
 

 
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.0/jquery.min.js"></script> 
 
</head> 
 

 
<body> 
 
    <div class="container-fluid"> 
 
    <div class="row"> 
 
     <div class="col-xs-1 side-panel full-height"></div> 
 
     <div class="col-xs-10 middle full-height"> 
 
     <div class="quote-box"> 
 
      <div class="quote-text"> 
 
      <p id="quote"></p> 
 
      <p id="author"></p> 
 
      <button type="button" class="btn btn-lg pull-right">New Quote</button> 
 
      </div> 
 
     </div> 
 
     </div> 
 
     <div class="col-xs-1 side-panel full-height"></div> 
 
    </div> 
 
    </div> 
 
</body> 
 

 
</html>

+0

我已编辑并移动到一切的片断,但重新运行并点击按钮正在改变引号。你可以解释一下确切的问题。 – Iceman

+0

我试图垃圾邮件的按钮,它几乎崩溃我的浏览器。 – technico

回答

2

你的问题是你嵌套你的职责的方式。

我已经移动了你的逻辑并整理了一些东西。

这里是你的代码只是放在正确的地方。

https://jsfiddle.net/hj5w5rdq/

var quotes =[ 
    ["This is quote number one.", "Person 1"], 
    ["This is quote number two.", "Person 2"], 
    ["This is quote number three.", "Person 3"], 
    ["This is quote number four.", "Person 4"], 
    ["This is quote number five.", "Person 5"] 
]; 

var colors = [ 
["#096986", "#F69679"], 
["#000866", "#FFF799"], 
["#7D3563", "#82CA9C"] 
]; 

var animations = [ 
    "animated bounce", 
    "animated flash", 
    "animated pulse" 
]; 

var getQuotes, 
     getColors, 
    newColor0, 
    newColor1, 
    newAnimation1, 
    newAnimation2; 

function loadQuotes(){ 

    getQuotes = randomNum(0, quotes.length - 1); 
    getColors = randomNum(0, colors.length - 1); 
    newColor0 = colors[getColors][0] ; 
    newColor1 = colors[getColors][1]; 
    newAnimation1 = animations[randomNum(0, animations.length - 1)] 
    newAnimation2 = animations[randomNum(0, animations.length - 1)] 

    document.getElementById("quote").innerHTML = "<h1>" + quotes[getQuotes][0] + "</h1>"; 
    document.getElementById("author").innerHTML = "<h3>" + "--- " + quotes[getQuotes][1] + "</h3>"; 

    $(".side-panel").css("background-color", newColor0); 
    $(".middle").css("background-color", newColor1); 
    $("#quote").addClass(newAnimation1); 
    $("#author").addClass(newAnimation2); 
} 

function randomNum(min, max) { 
    return Math.floor(Math.random() * (max - min + 1)) + min; 
} 

$(document).ready(function() { 
    $(".btn").on("click", function() { 
    loadQuotes(); 
    }); 

    loadQuotes(); 
}); 
1

您所遇到的问题是因为你调用内部本身loadQuotes功能,这使得在点击的点击循环。我的浏览器上去RAM使用3GB点击几下后,所以你需要拿到了

我已经在这里做了一些改变,这将帮助你: https://jsfiddle.net/qv5he9z0/6/

首先我从移动的JavaScript html到javascript面板。

所有代码现在incapsulated内:

$(document).ready(function() { }); 

所有的变量都在此之上的,所以您可以在您需要的和更改不同功能的值更新它们。现在他们是全球性的。

我也更换(因为我们拥有jQuery的):

document.getElementById("quote").innerHTML = "<h1>" + quotes[getQuotes][0] + "</h1>"; 

$("#quote").html("<h1>" + quotes[getQuotes][0] + "</h1>"); 

document.getElementById("author").innerHTML = "<h3>" + "--- " + quotes[getQuotes][1] + "</h3>"; 

$("#author").html("<h3>" + "--- " + quotes[getQuotes][1] + "</h3>"); 

我也将以下代码之外loadQuotes功能(所以我们没有在点击的点击循环):

$(".btn").on("click", function() { 
    loadQuotes(); 
});