2013-06-26 132 views
4

我一直在试图使此功能现在工作两个小时,但无法找到错误所在。Javascript表单验证器功能无法正常工作

这表现出乎意料。

当表单中的任何一个字段被填充后,表单将被发布到php文件 ,并且只有当所有字段都为空时(即5个错误)才显示错误(如预期的那样)。

但是,当填写6个字段中的任何一个时,无论表单中的其他错误如何,都会发布表单。

请帮我验证一下这个表格。

error是我将向用户显示的错误信息。 errors是找到的错误数量。

JavaScript function

function formValidator(){ 

    var elementValue = document.getElementById("first-name").value; 
    var elementName = document.getElementById("first-name"); 
    var errors = 0; 
    var error = " "; 

    if (elementValue == "" || elementValue == " " || elementValue== NULL){ 
     error = "First Name shouldn't be left empty."; 
     errors = 1; 
    } 

    var elementValue = document.getElementById("last-name").value; 
    var elementName = document.getElementById("last-name"); 

    if (elementValue == "" || elementValue == " " || elementValue== NULL){ 
     if (errors == 0){ 
      error = "Last Name shouldn't be left empty."; 
     } 
     else{ 
      error += "<br>Last Name shouldn't be left empty."; 
     } 
     errors+=1; 
    } 
    var elementValue = document.getElementById("email-for-registration").value; 
    var elementName = document.getElementById("email-for-registration"); 
    var email_err = "false"; 
    if (elementValue == "" || elementValue == " " || elementValue== NULL){ 
     email_err = "true"; 
    } 
    var elementValue = document.getElementById("phone-for-registration").value; 
    if ((elementValue == "" || elementValue == " " || elementValue== NULL) && email_err == "true"){ 
     if (errors == 0){ 
      error = "Both email and contact cannot be left empty."; 
     } 
     else{ 
      error += "<br>Both email and contact cannot be left empty."; 
     } 
     errors+=1; 
    } 
    var elementValue = document.getElementById("password-for-registration").value; 
    var elementName = document.getElementById("password-for-registration"); 
    if (elementValue == "" || elementValue == " " || elementValue== NULL){ 
     if (errors == 0){ 
      error = "Password shouldn't be left empty.\nSelect a strong password atleast 6 characters long."; 
     } 
     else{ 
      error += "<br>Password shouldn't be left empty.Select a strong password atleast 6 characters long."; 
     } 
     errors+=1; 
    } 
    else if (elementValue.length<6){ 
     if (errors == 0){ 
      error = "Password less than 6 characters aren't allowed for security reasons."; 
     } 
     else{ 
      error += "<br>Password less than 6 characters aren't allowed for security reasons."; 
     } 
     errors+=1; 
    } 
    email_err = document.getElementById("confirm-password-for-registration").value; 
    var elementName = document.getElementById("confirm-password-for-registration"); 
    if (elementValue != email_err){ 
     if (errors == 0){ 
      error = "The password to confirm doesn't match with your desired password."; 
     } 
     else{ 
      error += "<br>The password to confirm doesn't match with your desired password."; 
     } 
     errors+=1; 
    } 
    var elementValue = document.getElementById("agreed-for-registration"); 
    var elementName = document.getElementById("agreed-for-registration"); 
    if (!elementValue.checked){ 
     if (errors == 0){ 
     error = "Please go through our <a href=''>Terms and Conditions</a>, and make sure you agree to continue."; 
     document.getElementById("agreed-for-registration").focus(); 
     } 
     else{ 
      error += "<br>Please go through our <a href=''>Terms and Conditions</a>, and make sure you agree to continue."; 
     } 
     errors+=1; 
    } 


    alert(errors); 

    if (errors > 1){ 
     document.getElementById("form_errors").innerHTML = "<h4 style='color:red;'>Please remove the following errors from form to continue.</h4>"; 
     document.getElementById("form_errors").innerHTML += "<h5>" + error + "</h5><br>"; 
     return false; 
    } else if (errors == 1){ 
     alert(error); 
     elementName.focus(); 
     return false; 
    } else if (errors == 0){ 
     return true; 
    } 
    return false; 
} 

功能这里所说的。

<form name="registration" class="deco_blu_form" action="<?=$base_url;?>forms/confirm-registration/members.php" method="post" onsubmit="return formValidator();"> 

请询问是否需要任何其他信息,代码或解释。

+0

你得到了'警报(错误);'? – Sergio

+0

@Sergio是的,但正如我所说只有当所有的领域都是空的,我得到5个错误。否则没有。 –

+4

我不知道你使用'NULL'而不是'null'是否是问题。 – RobH

回答

3

FIDDLE

你需要有elementValue === "NULL"elementValue == null

我把console.log,而不是警报和onblur触发器只是为了让我更容易调试。

所以完整的代码:

function formValidator() { 

var elementValue = document.getElementById("first-name").value; 
var elementName = document.getElementById("first-name"); 
var errors = 0; 
var error = " "; 

if (elementValue == "" || elementValue == " " || elementValue === "NULL") { 
    error = "First Name shouldn't be left empty."; 
    errors = 1; 
} 

var elementValue = document.getElementById("last-name").value; 
var elementName = document.getElementById("last-name"); 

if (elementValue == "" || elementValue == " " || elementValue === "NULL") { 
    if (errors == 0) { 
     error = "Last Name shouldn't be left empty."; 
    } else { 
     error += "<br>Last Name shouldn't be left empty."; 
    } 
    errors += 1; 
} 
var elementValue = document.getElementById("email-for-registration").value; 
var elementName = document.getElementById("email-for-registration"); 
var email_err = "false"; 
if (elementValue == "" || elementValue == " " || elementValue === "NULL") { 
    email_err = "true"; 
} 
var elementValue = document.getElementById("phone-for-registration").value; 
if ((elementValue == "" || elementValue == " " || elementValue === "NULL") && email_err == "true") { 
    if (errors == 0) { 
     error = "Both email and contact cannot be left empty."; 
    } else { 
     error += "<br>Both email and contact cannot be left empty."; 
    } 
    errors += 1; 
} 
var elementValue = document.getElementById("password-for-registration").value; 
var elementName = document.getElementById("password-for-registration"); 
if (elementValue == "" || elementValue == " " || elementValue === "NULL") { 
    if (errors == 0) { 
     error = "Password shouldn't be left empty.\nSelect a strong password atleast 6 characters long."; 
    } else { 
     error += "<br>Password shouldn't be left empty.Select a strong password atleast 6 characters long."; 
    } 
    errors += 1; 
} else if (elementValue.length < 6) { 
    if (errors == 0) { 
     error = "Password less than 6 characters aren't allowed for security reasons."; 
    } else { 
     error += "<br>Password less than 6 characters aren't allowed for security reasons."; 
    } 
    errors += 1; 
} 
email_err = document.getElementById("confirm-password-for-registration").value; 
var elementName = document.getElementById("confirm-password-for-registration"); 
if (elementValue != email_err) { 
    if (errors == 0) { 
     error = "The password to confirm doesn't match with your desired password."; 
    } else { 
     error += "<br>The password to confirm doesn't match with your desired password."; 
    } 
    errors += 1; 
} 
var elementValue = document.getElementById("agreed-for-registration"); 
var elementName = document.getElementById("agreed-for-registration"); 
if (!elementValue.checked) { 
    if (errors == 0) { 
     error = "Please go through our <a href=''>Terms and Conditions</a>, and make sure you agree to continue."; 
     document.getElementById("agreed-for-registration").focus(); 
    } else { 
     error += "<br>Please go through our <a href=''>Terms and Conditions</a>, and make sure you agree to continue."; 
    } 
    errors += 1; 
} 


console.log(errors) 

if (errors > 1) { 
    document.getElementById("form_errors").innerHTML = "<h4 style='color:red;'>Please remove the following errors from form to continue.</h4>"; 
    document.getElementById("form_errors").innerHTML += "<h5>" + error + "</h5><br>"; 
    return false; 
} else if (errors == 1) { 
    alert(error); 
    elementName.focus(); 
    return false; 
} else if (errors == 0) { 
    return true; 
} 
return false; 
} 
0

起初,我算以下字段:

  1. 直呼其名
  2. 最后名称
  3. 电子邮件的注册
  4. 电话进行登记
  5. 密码为 - 注册
  6. confirm-password-for-registration
  7. 议定注册

以防万一,如果你做的绝对值的东西。

我已经构建了一个小概念验证脚本,并且遇到这个脚本不起作用,如果你没有一个id为#form_errors的元素。这可能是你的问题吗?通过这种方式调用document.getElementById("form_errors")会导致未定义,并且该函数不会返回false

当然未定义的元素相同的检查适用于其他领域,太;)

+0

对不起,我有他们。感谢您的努力。我有解决方案。 –