2012-12-02 116 views
0

所以我有一个问题,我有一个char * s(声明为)char **数组是动态分配的数组(由calloc),但char * s内它是静态的。释放一个静态字符串的动态数组

,直到我试图释放阵列(调整大小时)也能正常工作对我来说,在这一点上,我得到

*** glibc detected *** ./hash_table_test: free(): invalid next size (normal): 0x0891f028 *** 

我试图将所有的师生比的阵列为NULL,但后来我得到了错误

*** glibc detected *** ./hash_table_test: double free or corruption (!prev): 0x0815b028 *** 

下面是相关代码:

表结构:

struct string_hash_table { 

//Array of c-strings 
char** table; 
//number of elements in the table 
int num_elements; 
//size of table 
int table_size; 

//Primes 
int *primes; 
//Current position in primes array 
int primes_index; 
//the size of the primes array 
int primes_size; 
}; 
//TypeDefs-------------------------------- 
typedef struct string_hash_table HashTable; 

翻版功能(错误的来源)

void rehash_string(HashTable *table) { 

int prev_size = table->table_size; 
int i; 

table->table_size = table->table_size * 2; 

//create new array 
char** new_table = calloc(table->table_size, sizeof(char*)); 
printf("new table created\n"); 
int index; 
printf("before loop prev_size is %d\n", prev_size); 
//add all elements to new_table 
for (i = 0; i < prev_size; i++) { 
    printf("on %d\n", i); 
    index = find_spot_string(new_table, table->table_size, table->table[i]); 
    printf("after find_spot_string\n"); 
    if (index != -1) { 
     table->table[index] = table->table[i]; 
    } 
} 

//free and swap 
printf("before free\n"); 
empty_string_array(table->table, table->table_size); 
free(table->table); 
table->table = new_table; 

初始化哈希表结构的:

//Takes a HashTable and initializes it 
void init_hash_table(HashTable *table) { 

table->primes_index = 0; 
table->num_elements = 0; 
table->primes_size = 297; 
table->primes = prime_list; 

table->table_size = table->primes[0]; 
table->table = calloc(table->table_size, sizeof(char*)); 
} 

内的静态字符串声明:

char* temp = "hello"; 
add_hash_table_string(table, temp); 

temp = "luck"; 
add_hash_table_string(table, temp); 

temp = "stuck"; 
add_hash_table_string(table, temp); 

temp = "buck"; 
add_hash_table_string(table, temp); 

temp = "muck"; 
add_hash_table_string(table, temp); 

temp = "much"; 
add_hash_table_string(table, temp); 

目前我只是测试我的代码在这里,除了上面的重新哈希函数,一切都可以工作。有人有主意吗?或我应该遵循的主角?

编辑:添加代码为add_hash_table_string

void add_hash_table_string(HashTable *table, char* element) { 

    //if non-null element, and element is not in the HashTable 
    if (element != NULL && contains_hash_table_string(table, element) == 1) { 

     //if the table is full 
     if (table->table_size/2 < table->num_elements) { 

      rehash_string(table); 
     } 

     int index = find_spot_string(table->table, table->table_size, element); 

     table->table[index] = element; 
     table->num_elements++; 
    } 
} 

EDIT2:

忘记确切地说,误差在翻版功能与游离(表 - >表)中的线中发生

+2

神圣的降压...... –

+2

你正在使用函数'add_hash_table_string()',我们应该猜测它是什么以及你的代码出错了吗?你需要提供一个SSCCE([Short,Self-Contained,Correct Example](http://sscce.org/)),以便人们可以提供帮助。或者你应该考虑使用['valgrind'](http://valgrind.org/)。 –

+0

只有表是动态分配的,那么'empty_string_array()'应该做什么? – Arjor

回答

3

一个可能的问题,你可以免费使用新尺寸的旧桌子

empty_string_array(table->table, table->table_size); 

另外一个可能是

index = find_spot_string(new_table, table->table_size, table->table[i]); 
printf("after find_spot_string\n"); 
if (index != -1) { 
    table->table[index] = table->table[i]; 

如果这是应该的条目复制到new_table,它不AFAICS。当index大于prev_size时,您写入的内容超出table的末尾。

+0

+1:很好看。 –

+0

哦该死的好眼睛!我修正了,但是,我仍然得到相同的段错误和错误 – Ethan

+1

+1:好眼睛,还没有看到第一个! –