2013-07-18 151 views
1

我是C新手,我正在尝试为我正在小型测试应用程序中工作的程序制定逻辑。结构中的链接列表

它的目的是从将数据添加到结构的数据库中读取值,但在此结构中将包含与顶层结构相关的其他值的链接列表。我似乎在结构和链表中添加了很好的东西,但是当我尝试并检索它崩溃的值时。

下面是我的结构定义

typedef struct CallLogStructure 
{ 
    char * date; 
    char * time; 
    char * bParty; 
    char * aParty; 
    float duration; 
    char * cleardownCause; 
    struct Node *outBoundLegs; 
} callLogStructure; 

typedef struct Node 
{ 
    char * target; 
    float targetDuration; 
    char * targetCleardownCause; 
    struct Node *next; 
}node; 

下面是我怎么了初始化结构,然后调用方法将数据添加到链表。

char *outboundTarget = "0"; 
    float outboundDuration = 0; 
    char *outboundCleardown = "0"; 

    callLogStructure * callLog = NULL; 
    node *temp = NULL; 
    int dataRow = 0; 

    callLog = malloc(dataRow+1 * sizeof(callLog)); 
    //start = (node*)malloc(sizeof(node)); 
    callLog[0].outBoundLegs = NULL; 
    callLog[0].outBoundLegs = (node*)malloc(sizeof(node)); 
    if (callLog[0].outBoundLegs == NULL) 
    { 
     printf("Failed to allocate RAM\n"); 
    } 
    temp = &callLog[0].outBoundLegs; 
    temp->next = NULL; 
    callLog[0].outBoundLegs->target = "0"; 
    callLog[0].outBoundLegs->targetDuration = 0; 
    callLog[0].outBoundLegs->targetCleardownCause = "0"; 

    //Insert first inbound leg 
    callLog[0].date = "16/05/2011"; 
    callLog[0].time = "00:00:03"; 
    callLog[0].aParty = "12345"; 
    callLog[0].bParty = "67890"; 
    callLog[0].duration = 0; 
    callLog[0].cleardownCause = "unanswered"; 

    outboundTarget = "98765"; 
    outboundDuration = 0; 
    outboundCleardown = "Unanswered"; 

    insertOutBoundLeg(&callLog[0].outBoundLegs, outboundTarget, outboundDuration, outboundCleardown); 


    printf("NEWLY INSERTED OUTBOUND TARGET: %s", callLog[0].outBoundLegs->target); //This is where it's crashing. 

下面是insertOutBoundLeg功能

void insertOutBoundLeg(struct Node *pointer, char * target, float targetDuration, char * targetCleardownCause) 
{ 
    if (pointer->target == NULL) 
    { 
     asprintf(&pointer->target, "%s", target); 
     pointer->targetDuration = targetDuration; 
     asprintf(&pointer->targetCleardownCause, "%s", targetCleardownCause); 
     //pointer->target = target; 
     //pointer->targetDuration = targetDuration; 
     //pointer->targetCleardownCause = targetCleardownCause; 
    } 
    else 
    { 
     while (pointer->next != NULL) 
     { 
      pointer = pointer->next; 
     } 
     pointer->next = (node *)malloc(sizeof(node)); 
     pointer = pointer->next; 
     //pointer->target = target; 
     //pointer->targetDuration = targetDuration; 
     //pointer->targetCleardownCause = targetCleardownCause; 
     asprintf(&pointer->target, "%s", target); 
     pointer->targetDuration = targetDuration; 
     asprintf(&pointer->targetCleardownCause, "%s", targetCleardownCause); 
     pointer->next = NULL; 
    } 
} 

的想法是,这是建立最终的情况下,结构,包含在结构中的链接列表一起将被传递到一个单独的功能,这将将数据导出到一个文件中,我通过首先打印outboundlegs(链表)的值尝试过,但是这也会崩溃,但是,顶层结构(callLog)中的值很好。

感谢您提供的任何帮助。

回答

1

有多种问题,开始与

callLog = malloc(dataRow+1 * sizeof(callLog)); 

改变它

callLog = malloc(dataRow+1 * sizeof(*callLog)); 

要么初始化callLog[0].outBoundLegs以0作为memset(callLog[0].outBoundLegs, 0, sizeof(*callLog[0].outBoundLegs))或使用calloc()

callLog[0].outBoundLegs = calloc(1, sizeof(node)); 

callLog[0].outBoundLegs->target = "0"; 

不要初始化字符串的方式,做

callLog[0].outBoundLegs->target = strdup("0"); 

但是,请记住在适当的时候释放内存。

+0

感谢您的帮助。 – Boardy