2014-01-11 104 views
-1

所以我写了一个小Hang子手游戏,但我没有CLUE为什么它不工作。通常我会问一个问题来解决问题,但我根本不知道发生了什么,为什么我会遇到这个问题。没有错误。为什么我的代码不能按预期工作?

这里是我的所有代码:

public static void main(String[] args) { 
    Scanner sc = new Scanner (System.in); 
    String mysteryGuess = "hello"; 
    String userGuess = ""; 
    int wrongGuesses; 


    System.out.println("Hello and welcome to Hang Man!"); 
    loop: 
    for(;;){ 
     String[] wordAsArray = convertToStringArray(mysteryGuess); 
     boolean[] guessed = new boolean[mysteryGuess.length()]; 
     for (int i = 0; i<wordAsArray.length;i++) 
      if(wordAsArray[i] == userGuess) 
       guessed[i]=true; 
     System.out.println("Word so far:" + visibleWord(wordAsArray,guessed)); 
     System.out.println("What is your guess?"); 
     userGuess = sc.next(); 
     if (guess(userGuess,wordAsArray,guessed) == true) 
      System.out.println("Correct"); 
     else 
      System.out.println("Incorrect"); 
     if (didWin(guessed)==true) 
      break loop; 
    } 
} 


//This method creates an array version of the parameter word 
//For example, if word contained the data "hello", then this method 
//would return {"h", "e", "l", "l", "o"} 
//Parameters: word - a single word 
//Returns:  an array containing each letter in word 
public static String[] convertToStringArray(String word) { 
    String [] pWord = new String [word.length()]; 
    for (int i = 0; i<pWord.length; i++){ 
     pWord[i] = word.substring(i,i+1); 
    } 
    return pWord; 

} 


//This method determines whether the player has won the game of HangMan 
//Parameters: guessed - array of boolean values 
//Returns:  true - if every value in guessed is true 
//    false - if at least one value in guessed is false 
public static boolean didWin(boolean[] guessed) { 
    boolean bGuess = true; 
    loop: 
    for (int i = 0; i<guessed.length;i++){ 
     if(guessed[i]==false){ 
      bGuess = false; 
      break loop; 
     } 


    } 
     return bGuess; 
} 


//This method determines what portion of the hidden word is visible 
//For example, if the parameters are as follows: 
//  wordAsArray: {"h", "e", "l", "l", "o"} 
//  guessed: {true, false, false, false, true} 
//Then the method should return "h???o" 
//Parameters: wordAsArray - the individual letters to be guessed 
//    guessed - array of boolean values; a true value means the corresponding letter has been guessed 
//Returns:  A string representing how much of the word has been guessed (unguessed letters are represented by ?'s) 
public static String visibleWord(String[] wordAsArray, boolean[] guessed) { 
    String visibleWord=""; 
    for(int i = 0; i<wordAsArray.length;i++){ 
     if (guessed[i] == true) 
      wordAsArray[i]=wordAsArray[i]; 
     if (guessed[i] == false) 
      wordAsArray[i]="?"; 
    } 
    for(int i = 0; i<wordAsArray.length;i++){ 
     visibleWord=visibleWord+wordAsArray[i]; 
    } 
    return visibleWord; 
} 


//This method checks to see if a player has made a successful guess in the game of Hang Man 
//For example, if the parameters are as follows: 
//  letter: "e" 
//  wordAsArray: {"h", "e", "l", "l", "o"} 
//  guessed: {true, false, false, false, true} 
//Then the guessed array would be changed to: 
//  guessed: {true, true, false, false, true} 
//And the method would return false 
//Parameters: letter - the letter that the user has just guessed 
//    wordAsArray - an array of individual letters that are to be guessed 
//    guessed - array of boolean values; a true value means the corresponding letter has been guessed 
//Returns: true - if letter matches an unguessed letter in wordAsArray 
//   false - otherwise 
public static boolean guess(String letter, String[] wordAsArray, boolean[] guessed) { 
    boolean appearsAtLeastOnce=false; 
    for(int i = 0; i<wordAsArray.length;i++) 
     if(letter.equalsIgnoreCase(wordAsArray[i])){ 
      guessed[i] = true; 
      appearsAtLeastOnce=true; 
     } 
    return appearsAtLeastOnce; 



} 

}

所以,当你输入你的猜测,即使它是正确的,它会说的不正确和“字至今”不会显示你知道它是正确的。有人请向我解释这里有什么问题吗?我相信它是一件简单的事情,我失踪了,但我已经在这上面待了好几个小时。谢谢。

此外,我使用“你好”只是为了测试。我正在寻找输入各种字典单词的列表。

回答

3

变化

if(wordAsArray[i] == userGuess) 

if(wordAsArray[i].equals(userGuess)) //Replace .equals with .equalsIgnoreCase for case insensitive compare. 

你是比较字符串,而不是反对。所以==将不起作用。

希望这会有所帮助。

+0

IMO“你是比较引用类型,而不是基本类型的''==将无法正常工作”更正确的不是“你是比较字符串,而不是反对。所以'=='不会工作“。 – dorukayhan

0

我还没读过你的代码深,但也有你的代码中的一些问题(可能是有一些更多):

  1. 最重要的是要定义猜insideloop, so every time the array is initialized to all返回FALSE。
  2. 您正在使用==作为字符串,这将不起作用,您应该使用String.equals()方法代替,顺便说一句,为什么您不使用char s?
  3. java.lang.String有一个toCharArray()它返回char[]代表每个字符,并且因为char是原始的,您可以使用==运算符。
1

你的线if(wordAsArray[i] == userGuess)是比较两个对象,看看他们是否相等。在这种情况下,两个String对象。此比较检查以查看对象的引用是否相等(内存位置)。即使字符串具有相同的值,但它们是两个不同的对象,因此具有两个不同的存储位置,这将使它们不相等。

你正在试图做的是检查两个对象是否相同。这可以通过使用String.equals()方法来实现: if(wordAsArray[i].equals(userGuess))

一般来说,基本数据类型(整型,浮点,布尔,焦炭......)工作时,==比较工作得很好。但是,在使用对象时,应该使用对象的equals()方法。

更多关于基本类型:http://docs.oracle.com/javase/tutorial/java/nutsandbolts/datatypes.html

相关问题