测试某种方法，并引发异常

Question

我开始使用TDD（和MoQ）。我有一个方法接受订单并为该订单创建唯一的CustomerId。

public class CustomerService 
    { 

     public CustomerService(IOrderRepository orderRepo) 
     { 
      _orderRepo = orderRepo; 
     } 

     public string Create(Order order) 
     { 
      //1. Save the Order that comes in, irrespective of being valid or not. 
      _orderRepo.Save(order); 

      //2. If the order is invalid, throw an exception. 
      if (!isValid(order)) 
       throw new ArgumentException(); 

      //3. Create a Customer, generate a unique CustomerId and return that. 
      return createCustomerAndGenerateCustomerId(order); 
     } 

    } 

下面的测试似乎并不正确工作：

[Test] 
    [ExpectedException(typeof(ArgumentException))] 
    public void Create_WhenPassedInvalidOrder_StillPersistsIt() 
    { 
     //Arrange 
     var order = new Order(); //This is invalid, as it has some mandatory fields missing 
     var mockOrderRepo = new Mock<IOrderRepository>(); 
     var customerService = new CustomerService(mockOrderRepo.Object); 

     //Act 
     customerService.Create(order); //This should call Save() on the order repo, but still throw an exception. 

     //Assert 
     mockOrderRepo.Verify(o => o.Save(order), Times.Once()); 
    } 

这个测试总是通过，即使我不叫_orderRepo.Save（）。我究竟做错了什么？

Answer 1

在这种情况下，您不能使用ExpectedException，因为Nunit会在测试级别尝试/捕获异常，所以您的mockOrderRepo.Verify永远不会被调用。

所以，你需要手动尝试抓住你的customerService.Create电话 - 如果你想在抛出的异常手动断言 - 或者你的Assert.Throws if you're using Nunit 2.5 or higher：

[Test] 
public void Create_WhenPassedInvalidOrder_StillPersistsIt() 
{ 
    //Arrange 
    var order = new Order(); 
    var mockOrderRepo = new Mock<IOrderRepository>(); 
    var customerService = new CustomerService(mockOrderRepo.Object); 

    //Act 
    Assert.Throws<ArgumentException>(() => customerService.Create(order)); 

    //Assert 
    mockOrderRepo.Verify(o => o.Save(order), Times.Once()); 
}