写得更好看，更详细的代码

Question

我得到了下面的代码片段，它的工作原理和做我需要做的。唯一的问题是我认为它有点“冗长”，可以做一些优化。如有可能，有人可以帮助我减少重复性。大部分的代码非常相似......

非常感谢

<?php 

// condition = Less Than; More Than; Between 
// noofweeks = this is the number of weeks chosen by the user 

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno,  $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 

if ($condition== "Between") { 
// I need to get the start and end values as the data in this parameter should look like 1-17 
$betweenArray = explode('-',$conditionWeeks); 
$startWeek = $betweenArray[0]; 
$endWeek = $betweenArray[1]; 
} 


if(($condition == "Less Than") && ($noofweeks < $conditionWeeks) && ($supplementType == 'Subtract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

elseif(($condition == "Less Than") && ($noofweeks < $conditionWeeks) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; } 

elseif(($condition == "More Than") && ($noofweeks > $conditionWeeks) && ($supplementType == 'Subtract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

elseif(($condition == "More Than") && ($noofweeks > $conditionWeeks) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; }  

elseif(($condition == "Between") && ($noofweeks >= $startWeek && $noofweeks <= $endWeek) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; } 

elseif(($condition == "Between") && ($noofweeks >= $startWeek && $noofweeks <= $endWeek) && ($supplementType == 'Substract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

//if no conditions match, just return the unaltered basic price back 

else { return $basicprice ;} 

;} ?> 

Answer 1

这IFS的一个列表可以写成一个嵌套如果。

最重要的变化：

1. ($weekno >= $weekStartno && $weekno <= $weekEndno)是所有 条件的一部分，所以它是在外部如果。
2. 如果使用或 （||），将与给定条件字符串匹配的三个变化条件 放入1中。
3. 内在如果也单数。 Add导致 增加。 Subtract在减法。

所有归结为尽可能少的重复条件，虽然你应该记住，结构仍应该清楚。在某些情况下，这可能会更容易。

<?php 

// condition = Less Than; More Than; Between 
// noofweeks = this is the number of weeks chosen by the user 

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno, $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 
    if ($condition == "Between") { 
    // I need to get the start and end values as the data in this parameter should look like 1-17 
    $betweenArray = explode('-',$conditionWeeks); 
    $startWeek = $betweenArray[0]; 
    $endWeek = $betweenArray[1]; 
    } 

    if ($weekno >= $weekStartno && $weekno <= $weekEndno) 
    { 
    if (($condition == 'Less Than' && $noofweeks < $conditionWeeks) || 
     ($condition == 'More Than' && $noofweeks > $conditionWeeks) || 
     ($condition == 'Between' && $noofweeks >= $startWeek && $noofweeks <= $endWeek)) 
    { 
     // You can use a 'switch' as well, instead of if...elseif. 
     if ($supplementType == 'Subtract') { 
     return $basicprice - $supplementAmnt; 
     } elseif ($supplementType == 'Add' { 
     return $basicprice + $supplementAmnt; 
     } 
    } 
    } 
    return $basicprice; 
} ?> 

在不同的设置中，我把中间结果在单独的变量，我认为 使得它更具有可读性。我在这里加了一点更多的评论，解释了决定：

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno, $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 

    // Create two 'helper' booleans to make the if condition easier. 
    $weekInRange = ($weekno >= $weekStartno && $weekno <= $weekEndno); 
    $noOfWeeksInRange = 
     ($condition == 'Less Than' && $noofweeks < $conditionWeeks) || 
     ($condition == 'More Than' && $noofweeks > $conditionWeeks); 

    // Alternatively, you can break the single line above up in multiple 
    // lines, which makes debugging easier: 
    //$noOfWeeksInRange = ($condition == 'Less Than' && $noofweeks < $conditionWeeks); 
    //$noOfWeeksInRange |= ($condition == 'More Than' && $noofweeks > $conditionWeeks); 

    if ($condition == "Between") { 
    // I need to get the start and end values as the data in this parameter should look like 1-17 
    $betweenArray = explode('-',$conditionWeeks); 
    $startWeek = $betweenArray[0]; 
    $endWeek = $betweenArray[1]; 
    // Overwrite this variable with the condition that goes with 'Between'. 
    // We're already in that if, so we don't need to check 'Condition' again.. 
    // You could use betweenArray[0] and [1] in the condition below, but using 
    // the variables $startWeek and $endWeek does make it more readable. 
    $noOfWeeksInRange = ($noofweeks >= $startWeek && $noofweeks <= $endWeek); 
    } 

    // And not this 'if' is even more readable. 
    if ($weeksInRange && $noOfWeeksInRange) 
    { 
     // You can use a 'switch' as well, instead of if...elseif. 
     if ($supplementType == 'Subtract') { 
     return $basicprice - $supplementAmnt; 
     } elseif ($supplementType == 'Add' { 
     return $basicprice + $supplementAmnt; 
     } 
    } 
    return $basicprice; 
} ?>