2011-04-21 253 views
0

以下查询运行缓慢。对于memberid中的一个值,memberid0,memberid1 ........ memberid9中有多个条目。因此,每条语句都会影响多行更新。 Ofcourse表大小以MB为单位TSql(sql server 2005)查询运行缓慢

Declare @memberName nvarchar(250) 
Declare @memberID bigint 
Declare @dimId int 
Declare @levelId int 
Declare @newName nvarchar(250) 
Declare @updateSQL1 nvarchar(500) 
Declare @updateSQL2 nvarchar(500) 
Declare @cursorStmt nvarchar(300) 
Declare @custCounter bigint 
Declare @prodCounter bigint 
Declare @regCounter bigint 
Declare @memberCounter int 

SET @custCounter = 1 
SET @prodCounter = 1 
SET @regCounter = 1 
SET @memberCounter = 0 

BEGIN TRANSACTION 

While @memberCounter < 3 
Begin 

    Set @cursorStmt = 'Declare memberCursor CURSOR 
     FOR Select name, memberid, dimensionId, levelNumber from member' + CAST(@memberCounter as NVARCHAR(1)) + ' where memberID <> 0 order by memberid' 
    print @cursorStmt 

    exec sp_executesql @cursorStmt 

    OPEN memberCursor 
    FETCH NEXT FROM memberCursor INTO @memberName, @memberId, @dimId, @levelId 

    WHILE @@FETCH_STATUS = 0 
    BEGIN 
     IF @dimId = 0 
      BEGIN 
       SET @newName = 'Customer_' + CAST(@custCounter AS NVARCHAR(10)) + '_LEVEL_' + CAST(@levelId AS NVARCHAR(10)) 
       SET @custCounter = @custCounter + 1 
      END 
     else if @dimId = 1 
      BEGIN 
       SET @newName = 'Product_' + CAST(@prodCounter AS NVARCHAR(10)) + '_LEVEL_' + CAST(@levelId AS NVARCHAR(10)) 
       SET @prodCounter = @prodCounter + 1 
      END 
     else if @dimId = 2 
      BEGIN 
       SET @newName = 'Region_' + CAST(@regCounter AS NVARCHAR(10)) + '_LEVEL_' + CAST(@levelId AS NVARCHAR(10)) 
       SET @regCounter = @regCounter + 1 
      END 

     SET @updateSQL1 = 'Update Member' + CAST(@dimId AS NVARCHAR(5)) + ' set name = ''' + @newName + ''' where memberId = ' + CAST(@memberId AS NVARCHAR(10)) 
     SET @updateSQL2 = 'Update Member' + CAST(@dimId AS NVARCHAR(5)) + ' set memberName' + CAST(@levelId-1 AS NVARCHAR(5)) + ' = ''' + @newName + ''' where memberId' + CAST(@levelId-1 AS NVARCHAR(5)) + ' = ' + CAST(@memberId AS NVARCHAR(10)) 

     --print @updateSQL1 
     --print @updateSQL2 

     exec sp_executesql @updateSQL1 
     exec sp_executesql @updateSQL2 

     FETCH NEXT FROM memberCursor INTO @memberName, @memberId, @dimId, @levelId 

    END 

    CLOSE memberCursor 
    DEALLOCATE memberCursor 

    Set @memberCounter = @memberCounter + 1 

END 
+0

步骤来改善:(1)摆脱光标的 - 这是** **总是会成为sloooooooow - (2)检查执行计划可能帮助的潜在索引(在WHERE或ORDER BY子句中显示的列) – 2011-04-21 09:20:50

回答

0

我加倍marc_s说,但如果你不想这样做, 尝试创建一个牵你的更新语句,然后一表一批次的最低10执行它们每个查询更新。

尝试创建两个表来存储两种不同类型的更新,因此在批处理中,只能更新至少10行。我想在一个查询中尽可能多地更新。在单个SQL查询

多次更新速度更快,请参阅: Why are batch inserts/updates faster? How do batch updates work?