Java迭代器无限循环

Question

无法弄清楚为什么这是循环无限。

public void DLCCheck(IconSet iconSet) { 
    Log.d(TAG, "Got dlc check. Looking to see if we need to remove any notes from the current list."); 
    int foundCount = 0; 
    for(Iterator<Item> i = mItemList.iterator(); i.hasNext();) { 
     if(i instanceof NoteItem && ((NoteItem) i).getIconSet() == iconSet) { 
      i.remove(); 
      foundCount++; 
     } 
    } 
    Log.d(TAG, "Finished searching. Found " + foundCount + "notes in the current list to delete."); 
    //notifyDataSetChanged(); 
    //EventBus.getDefault().post(new MoveNoteListOut()); 
} 

当hasNext返回false时，不应该停止迭代吗？这个列表中只有6个项目，但它永远循环。

Answer 1

你永远不会打电话给i.next()。另外，i是instanceof Iterator，所以i instanceof NoteItem永远不会是true。您应该阅读i.next()中的数据并根据您的条件评估此类元素。

这在代码中应该如何：

for(Iterator<Item> i = mItemList.iterator(); i.hasNext();) { 
    Item item = i.next(); 
    if(item instanceof NoteItem && ((NoteItem) item).getIconSet() == iconSet) { 
           //here ---------------------------^^ 
           //not sure what type returns getIconSet 
           //but if it's not a primitive then you should use equals 
     i.remove(); 
     foundCount++; 
    } 
}